[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148032#comment-16148032 ] Hudson commented on HADOOP-14814: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12277 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12277/]) HADOOP-14814. Fix incompatible API change on FsServerDefaults to (junping_du: rev 41480233a9cfb0bcfb69cc0f1594120e7656f031) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsServerDefaults.java > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Fix For: 2.9.0, 3.0.0-beta1, 2.8.2 > > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147769#comment-16147769 ] Junping Du commented on HADOOP-14814: - Anyway, thanks for reminding, Rushabh. > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147768#comment-16147768 ] Junping Du commented on HADOOP-14814: - Well. the target version here is not necessary to be very precisely as it only get used to remind RM on specific branch that some of blocker/critical issues are still open. Given we will commit the patch soon and 2.9 release is still in feature planning, it should be fine. > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147758#comment-16147758 ] Rushabh S Shah commented on HADOOP-14814: - We should include 2.9.0 also in target version since HADOOP-14104 was committed in 2.9.0 > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147740#comment-16147740 ] Junping Du commented on HADOOP-14814: - Thanks [~andrew.wang] and [~shahrs87] for review and comments. I will commit it shortly if no objections. > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[
https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147247#comment-16147247
]
Rushabh S Shah commented on HADOOP-14814:
-
Thanks [~djp] for finding the bug.
Apologies for introducing the bug.
+1 non-binding. The patch lgtm.
Regarding the test failures:
1. {{org.apache.hadoop.fs.sftp.TestSFTPFileSystem#testGetAccessTime}}: This
failure is being tracked by {{HADOOP-14206}}
Even though in HADOOP-14206, different test is failing but the stack trace is
the same.
2.
{{org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem#testTrashRoot}}
This test passes locally on my box. I think its a case of not cleaning up.
> Fix incompatible API change on FsServerDefaults to HADOOP-14104
> ---
>
> Key: HADOOP-14814
> URL: https://issues.apache.org/jira/browse/HADOOP-14814
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Junping Du
>Assignee: Junping Du
>Priority: Blocker
> Attachments: HADOOP-14814.patch
>
>
> From recently jdiff report:
> https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html.
> We found an incompatible API change: in HADOOP-14104, we remove the
> constructor with replacing with more parameters. This will cause API
> incompatible given FsServerDefaults marked as public.
> We should fix it before 2.8.2 and 3.0-beta kicked out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[
https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146490#comment-16146490
]
Hadoop QA commented on HADOOP-14814:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
20s{color} | {color:red} hadoop-common in trunk failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m
39s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 42s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
18s{color} | {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 3s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 69m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| | hadoop.fs.sftp.TestSFTPFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14814 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884375/HADOOP-14814.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 36934da1e04a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / cf93d60 |
| Default Java | 1.8.0_144 |
| mvnsite |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13126/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
|
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13126/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13126/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13126/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146421#comment-16146421 ] Andrew Wang commented on HADOOP-14814: -- +1 LGTM pending Jenkins, thanks for the find and fix Junping! > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > From recently jdiff report: > https://builds.apache.org/job/Hadoop-2.8-JACC/376/artifact/target/compat-check/report.html. > We found an incompatible API change: in HADOOP-14104, we remove the > constructor with replacing with more parameters. This will cause API > incompatible given FsServerDefaults marked as public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14814) Fix incompatible API change on FsServerDefaults to HADOOP-14104
[ https://issues.apache.org/jira/browse/HADOOP-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146406#comment-16146406 ] Junping Du commented on HADOOP-14814: - The fix is straightforward. > Fix incompatible API change on FsServerDefaults to HADOOP-14104 > --- > > Key: HADOOP-14814 > URL: https://issues.apache.org/jira/browse/HADOOP-14814 > Project: Hadoop Common > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du >Priority: Blocker > Attachments: HADOOP-14814.patch > > > In HADOOP-14104, we remove the constructor with replacing with more > parameters. This will cause API incompatible given FsServerDefaults marked as > public. > We should fix it before 2.8.2 and 3.0-beta kicked out. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
