[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300111#comment-16300111
]
Hudson commented on HADOOP-15113:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13415 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13415/])
HADOOP-15113. NPE in S3A getFileStatus: null instrumentation on using (stevel:
rev ef450df443f1dea1c52082cf281f25db7141972f)
* (add)
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AClosedFS.java
* (edit)
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java
* (edit)
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
> URL: https://issues.apache.org/jira/browse/HADOOP-15113
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 3.1.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
> Fix For: 3.1.0
>
> Attachments: HADOOP-15113-001.patch
>
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299876#comment-16299876
]
Steve Loughran commented on HADOOP-15113:
-
thanks. The one thing weaker in volatile is not using volatile & expecting
things to catch up, though you are into the nuances of when things get cached
and ordered.
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
> URL: https://issues.apache.org/jira/browse/HADOOP-15113
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 3.1.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
> Attachments: HADOOP-15113-001.patch
>
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299130#comment-16299130
]
Aaron Fabbri commented on HADOOP-15113:
---
Looks good to me, +1. (Tested in us west 2)
Volatile seems reasonable here. Seems the cheapest we can get is these memory
barriers on the closed flag. Expensive from CPU perspective but I doubt we'll
notice with the other very slow things (s3 accesses) going on here.
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
> URL: https://issues.apache.org/jira/browse/HADOOP-15113
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 3.1.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
> Attachments: HADOOP-15113-001.patch
>
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291604#comment-16291604
]
genericqa commented on HADOOP-15113:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 54s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 12s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
33s{color} | {color:green} hadoop-aws in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | HADOOP-15113 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902146/HADOOP-15113-001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 593ebb5c7844 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 37efa67 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13835/testReport/ |
| Max. process+thread count | 334 (vs. ulimit of 5000) |
| modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13835/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288185#comment-16288185
]
Steve Loughran commented on HADOOP-15113:
-
new patch fails meaningfully
{code}
2017-12-12 20:04:38,045 [main] INFO diag.S3ADiag (DurationInfo.java:close(57))
- Listing s3a://hwdev-steve-ireland-new/: duration 0:00:001
java.io.IOException: s3a://hwdev-steve-ireland-new: FileSystem is closed!
at
org.apache.hadoop.fs.s3a.S3AFileSystem.checkNotClosed(S3AFileSystem.java:2455)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.entryPoint(S3AFileSystem.java:1106)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.innerListStatus(S3AFileSystem.java:1852)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$listStatus$9(S3AFileSystem.java:1834)
at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:108)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.listStatus(S3AFileSystem.java:1834)
at org.apache.hadoop.fs.s3a.diag.S3ADiag.run(S3ADiag.java:172)
at org.apache.hadoop.fs.s3a.diag.S3ADiag.run(S3ADiag.java:141)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
at org.apache.hadoop.fs.s3a.diag.S3ADiag.exec(S3ADiag.java:249)
at org.apache.hadoop.fs.s3a.diag.S3ADiag.main(S3ADiag.java:260)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:239)
at org.apache.hadoop.util.RunJar.main(RunJar.java:153)
2017-12-12 20:04:38,047 [main] INFO util.ExitUtil
(ExitUtil.java:terminate(210)) - Exiting with status -1: java.io.IOException:
s3a://hwdev-steve-ireland-new: FileSystem is closed!
{code}
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
> URL: https://issues.apache.org/jira/browse/HADOOP-15113
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 3.1.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance
[
https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288155#comment-16288155
]
Steve Loughran commented on HADOOP-15113:
-
This NPE is how operations on a closed FS surface, which is not useful in terms
of debugging
Proposed:
a volatile boolean isClosed; alongside the atomicBoolean
a which checkOpen() call which throws an IOE if closed
Using the volatile makes the check low cost
> NPE in S3A getFileStatus: null instrumentation on using closed instance
> ---
>
> Key: HADOOP-15113
> URL: https://issues.apache.org/jira/browse/HADOOP-15113
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 3.1.0
>Reporter: Steve Loughran
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
