[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-06-04 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501278#comment-16501278
 ] 

Hudson commented on HADOOP-15507:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14362 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14362/])
HADOOP-15507. Add MapReduce counters about EC bytes read. (xiao: rev 
6d5e87aec2f615ed265dc495873bf53ee7d2ace2)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* (edit) 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* (edit) 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/FileSystemCounter.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystemStorageStatistics.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* (edit) 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/org/apache/hadoop/mapreduce/FileSystemCounter.properties
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* (edit) 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileSystemStorageStatistics.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReaderStrategy.java


> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: HADOOP-15507.01.patch, image-2018-05-31-15-29-45-729.png
>
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-06-04 Thread Xiao Chen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501266#comment-16501266
 ] 

Xiao Chen commented on HADOOP-15507:


Thanks for the review Haibo and Fabbri. 

bq. manually tested (i.e. your screenshot is real)
Yes, tested this in a real cluster and the picture is a pure screenshot of a 
job's counter - no image editing. :)

Based on the +1's, I'm committing this. Failed TestTrash looks unrelated and 
passed locally.

> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
> Attachments: HADOOP-15507.01.patch, image-2018-05-31-15-29-45-729.png
>
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-06-04 Thread Aaron Fabbri (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500916#comment-16500916
 ] 

Aaron Fabbri commented on HADOOP-15507:
---

+1 assuming you manually tested (i.e. your screenshot is real) in addition to 
running the updated unit test in the patch. Patch looks fine to me.

> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
> Attachments: HADOOP-15507.01.patch, image-2018-05-31-15-29-45-729.png
>
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-06-04 Thread Haibo Chen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500612#comment-16500612
 ] 

Haibo Chen commented on HADOOP-15507:
-

The MapReduce part looks good to me, but I'm not very familiar with the erase 
code or the file system API to comment on the rest of the patch.

> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
> Attachments: HADOOP-15507.01.patch, image-2018-05-31-15-29-45-729.png
>
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-05-31 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497415#comment-16497415
 ] 

genericqa commented on HADOOP-15507:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 25m 
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m  
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
16m 19s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
18s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 26m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 26m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}  
9m 42s{color} | {color:green} patch has no errors when building and testing our 
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  7m 48s{color} 
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
47s{color} | {color:green} hadoop-hdfs-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
11s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
43s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}149m 48s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.fs.TestTrash |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HADOOP-15507 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12926009/HADOOP-15507.01.patch 
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux f3d1cb52a279 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13 
13:47:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c95b9b5 |
| maven | version

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-05-31 Thread Xiao Chen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497267#comment-16497267
 ] 

Xiao Chen commented on HADOOP-15507:


Added a screenshot of what this would look like

> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
> Attachments: HADOOP-15507.01.patch, image-2018-05-31-15-29-45-729.png
>
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15507) Add MapReduce counters about EC bytes read

2018-05-31 Thread Xiao Chen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497247#comment-16497247
 ] 

Xiao Chen commented on HADOOP-15507:


(Write counters are calculated at FSDataOutputStream, and it's pretty difficult 
to bring HDFS information from DFSOutputStream up here. So for this Jira the 
proposal is to only do read stats)

> Add MapReduce counters about EC bytes read
> --
>
> Key: HADOOP-15507
> URL: https://issues.apache.org/jira/browse/HADOOP-15507
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Xiao Chen
>Assignee: Xiao Chen
>Priority: Major
>
> HDFS has added Erasure Coding support in HDFS-7285. There are HDFS level 
> [ReadStatistics|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReadStatistics.java]
>  so from DFSClient we can know how much reads are EC/replication.
> In order for users to have a better view of how much of their workload is 
> impacted by EC, we can expose EC read bytes to File System Counters, and to 
> MapReduce's job counters. This way, end users can tell from MR jobs directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org