[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618421#comment-16618421
]
Ryan Wu commented on HADOOP-15742:
--
:D
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch,
> HADOOP-15742.003.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618419#comment-16618419
]
Hudson commented on HADOOP-15742:
-
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #14986 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14986/])
HADOOP-15742. Log if ipc backoff is enabled in CallQueueManager. (yqlin: rev
ee051ef9fec1fddb612aa1feae9fd3df7091354f)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch,
> HADOOP-15742.003.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617124#comment-16617124
]
Yiqun Lin commented on HADOOP-15742:
LGTM, +1. Will hold off the commit until at the end of today in case there are
some other comments.
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch,
> HADOOP-15742.003.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617101#comment-16617101
]
Hadoop QA commented on HADOOP-15742:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 22s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 17m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 36s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
58s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}108m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HADOOP-15742 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12939913/HADOOP-15742.003.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 7c5e2ae1e077 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15
17:03:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 95231f1 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15203/testReport/ |
| Max. process+thread count | 1716 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15203/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Log if ipc
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614120#comment-16614120
]
Mingliang Liu commented on HADOOP-15742:
+1
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613579#comment-16613579
]
Yiqun Lin commented on HADOOP-15742:
Other than checkstyle issue, +1 for others.
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613440#comment-16613440
]
Hadoop QA commented on HADOOP-15742:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 25m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
15m 9s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
14s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 0s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 1s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
38s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}121m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HADOOP-15742 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12939541/HADOOP-15742.002.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 2caad98b98f6 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c6e19db |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15186/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15186/testReport/ |
| Max. process+thread count | 1364 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-c
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613293#comment-16613293
]
Ryan Wu commented on HADOOP-15742:
--
Hi,[~linyiqun], I have used string interpolation way in HADOOP-15742.002.patch.
The following output logs were tested in my local.
{quote}
2018-09-13 18:05:32,077 INFO ipc.CallQueueManager
(CallQueueManager.java:(84)) - Using callQueue: class
org.apache.hadoop.ipc.FairCallQueue, queueCapacity: 8, scheduler: class
org.apache.hadoop.ipc.DecayRpcScheduler, ipcBackoff: false.
{quote}
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613291#comment-16613291
]
Hadoop QA commented on HADOOP-15742:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 21m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 51s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 20m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 13s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
35s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
39s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}113m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HADOOP-15742 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12939515/HADOOP-15742.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux beda6886cca0 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15
17:03:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c6e19db |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15185/testReport/ |
| Max. process+thread count | 1592 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/15185/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Log if ipc
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613159#comment-16613159
]
Yiqun Lin commented on HADOOP-15742:
[~jianliang.wu]， could you use string interpolation way as [~ste...@apache.org]
mentioned? Update this like following:
{code}
LOG.info("Using callQueue: {}, queueCapacity: {}, " +
" scheduler: {}, ipcBackoff: {}.", schedulerClass, backingClass,
maxQueueSize, schedulerClass, clientBackOffEnabled);
{code}
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613124#comment-16613124
]
Ryan Wu commented on HADOOP-15742:
--
This patch makes users know that they enabled this feature.
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612033#comment-16612033
]
Yiqun Lin commented on HADOOP-15742:
{quote}Is this going to flood the logs if @ info?.
{quote}
Hi [~ste...@apache.org], this won't flood the log, we just add ipc backoff info
in existing info. This only print once when construct the call queue manager
{noformat}
LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
maxQueueSize + " scheduler: " + schedulerClass);
{noformat}
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612008#comment-16612008
]
Steve Loughran commented on HADOOP-15742:
-
Is this going to flood the logs if @ info?. Is it important enough to merit a
mention ?
Otherwise
* log at debug
* use SLF4J string interpolation to build up the strings if logging at debug is
enabled
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
