[jira] [Commented] (HADOOP-16157) [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore
[ https://issues.apache.org/jira/browse/HADOOP-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788764#comment-16788764 ] Hudson commented on HADOOP-16157: - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16169 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16169/]) HADOOP-16157. [Clean-up] Remove NULL check before instanceof in (templedf: rev bb8ad096e785f7127a5c0de15167255d9b119578) * (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java > [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore > > > Key: HADOOP-16157 > URL: https://issues.apache.org/jira/browse/HADOOP-16157 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: Shweta >Assignee: Shweta >Priority: Minor > Fix For: 3.3.0 > > Attachments: HADOOP-16157.001.patch > > > Null check before instanceof is present on L:1765 and L:2641. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16157) [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore
[ https://issues.apache.org/jira/browse/HADOOP-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785149#comment-16785149 ] Shweta commented on HADOOP-16157: - Thank you for the review [~templedf]. There are a few checkstyle issues in this file, should I upload a patch to solve those along with the current Null instance check? > [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore > > > Key: HADOOP-16157 > URL: https://issues.apache.org/jira/browse/HADOOP-16157 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: Shweta >Assignee: Shweta >Priority: Minor > Attachments: HADOOP-16157.001.patch > > > Null check before instanceof is present on L:1765 and L:2641. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16157) [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore
[ https://issues.apache.org/jira/browse/HADOOP-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785117#comment-16785117 ] Daniel Templeton commented on HADOOP-16157: --- LGTM +1 I'll commit when I get a chance. > [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore > > > Key: HADOOP-16157 > URL: https://issues.apache.org/jira/browse/HADOOP-16157 > Project: Hadoop Common > Issue Type: Improvement > Components: tools >Reporter: Shweta >Assignee: Shweta >Priority: Minor > Attachments: HADOOP-16157.001.patch > > > Null check before instanceof is present on L:1765 and L:2641. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16157) [Clean-up] Remove NULL check before instanceof in AzureNativeFileSystemStore
[
https://issues.apache.org/jira/browse/HADOOP-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782053#comment-16782053
]
Hadoop QA commented on HADOOP-16157:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 18s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 40s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
20s{color} | {color:green} hadoop-azure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HADOOP-16157 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12960821/HADOOP-16157.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 0ac4cea54e3a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / cab8529 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16007/testReport/ |
| Max. process+thread count | 457 (vs. ulimit of 1) |
| modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16007/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> [Clean-up] Remove NULL check before instanceof in
