[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020763#comment-17020763 ] Hudson commented on HADOOP-16670: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17890 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17890/]) HADOOP-16670. Stripping Submarine code from Hadoop codebase. Contributed (weichiu: rev d40d7cc4f90ea0e9a298246813b2fa1fe18f6188) * (delete) hadoop-submarine/hadoop-submarine-core/src/site/markdown/Examples.md * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/tensorflow/command/TensorFlowLaunchCommand.java * (delete) hadoop-submarine/hadoop-submarine-core/src/test/resources/runjob-tensorflow-yaml/valid-config-with-overrides.yaml * (delete) hadoop-submarine/hadoop-submarine-core/src/main/docker/tensorflow/with-cifar10-models/ubuntu-16.04/cifar10_estimator_tf_1.13.1/cifar10_main.py * (delete) hadoop-submarine/hadoop-submarine-core/src/test/java/org/apache/hadoop/yarn/submarine/client/cli/YamlConfigTestUtils.java * (delete) hadoop-submarine/hadoop-submarine-core/src/main/docker/tensorflow/with-cifar10-models/ubuntu-16.04/Dockerfile.cpu.tf_1.13.1 * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/runjob/RoleParameters.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/test/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/tensorflow/command/TestTensorBoardLaunchCommand.java * (delete) hadoop-submarine/hadoop-submarine-core/src/test/resources/runjob-common-yaml/missing-configs.yaml * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/Command.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/pytorch/command/PyTorchWorkerLaunchCommand.java * (delete) hadoop-submarine/hadoop-submarine-core/src/test/java/org/apache/hadoop/yarn/submarine/client/cli/runjob/pytorch/TestRunJobCliParsingPyTorch.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/tensorflow/component/TensorFlowPsComponent.java * (delete) hadoop-submarine/hadoop-submarine-core/src/test/resources/runjob-tensorflow-yaml/valid-config.yaml * (delete) hadoop-submarine/hadoop-submarine-core/src/main/docker/tensorflow/zeppelin-notebook-example/shiro.ini * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/utils/EnvironmentUtilities.java * (delete) hadoop-submarine/hadoop-submarine-core/src/test/resources/runjob-tensorflow-yaml/security-principal-is-missing.yaml * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/tensorflow/command/TensorFlowWorkerLaunchCommand.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/test/java/org/apache/hadoop/yarn/submarine/utils/TestClassPathUtilities.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/AbstractComponent.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/command/PyTorchLaunchCommandFactory.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/test/resources/core-site.xml * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/param/yaml/PsRole.java * (delete) hadoop-submarine/hadoop-submarine-core/src/main/docker/tensorflow/zeppelin-notebook-example/zeppelin-site.xml * (delete) hadoop-submarine/hadoop-submarine-core/src/site/resources/css/site.css * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/common/api/Role.java * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/common/resource/UnitsConversionUtil.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceRuntimeFactory.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/tensorflow/command/package-info.java * (delete) hadoop-submarine/hadoop-submarine-yarnservice-runtime/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/AbstractServiceSpec.java * (delete) hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/common/JobMonitor.java * (delete)
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020054#comment-17020054 ] Zhankun Tang commented on HADOOP-16670: --- [~aajisaka], thanks a lot! [~weichiu], could you please help to review and merge it? > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Blocker > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch, HADOOP-16670-trunk.007.patch, > HADOOP-16670-trunk.008.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020049#comment-17020049 ] Akira Ajisaka commented on HADOOP-16670: +1, thanks [~tangzhankun]. > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Blocker > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch, HADOOP-16670-trunk.007.patch, > HADOOP-16670-trunk.008.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020045#comment-17020045 ] Zhankun Tang commented on HADOOP-16670: --- [~aajisaka], could you please help to review? Thanks! > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Blocker > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch, HADOOP-16670-trunk.007.patch, > HADOOP-16670-trunk.008.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17020032#comment-17020032
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 32m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 62 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 5s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-assemblies . hadoop-submarine
hadoop-submarine/hadoop-submarine-all hadoop-submarine/hadoop-submarine-dist
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
25s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
37s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
8s{color} | {color:green} The patch generated 0 new + 0 unchanged - 128 fixed =
0 total (was 128) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
14s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 55s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-assemblies . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}178m 17s{color}
| {color:red} root in the patch failed. {color} |
|
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019357#comment-17019357 ] Zhankun Tang commented on HADOOP-16670: --- [~aajisaka], sorry for the late reply. I updated the patch based on Wanqiang's comment. Not sure why the Jenkins result hasn't appeared. > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Blocker > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch, HADOOP-16670-trunk.007.patch, > HADOOP-16670-trunk.008.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009358#comment-17009358 ] Akira Ajisaka commented on HADOOP-16670: Hi [~tangzhankun], would you reflect Wanqiang's comment? I'm +1 if that is addressed. > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Blocker > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000649#comment-17000649 ] Wanqiang Ji commented on HADOOP-16670: -- +1 for 006 patch. Should we need to remove the ** [submarine-dev](mailto:submarine-...@hadoop.apache.org)* from the DownstreamDev.md(./hadoop-common-project/hadoop-common/src/site/markdown/DownstreamDev.md) file? > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Major > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1634#comment-1634 ] Zhankun Tang commented on HADOOP-16670: --- [~weichiu]. [~jiwq] , Thanks for the review. Fixed the remaining issue in the latest patch. I checked the findbug, unit test and ASF license failure. It seems unrelated. Could you please help to review it again? Thanks a lot! > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Major > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch, HADOOP-16670-trunk.005.patch, > HADOOP-16670-trunk.006.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999888#comment-16999888
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 62 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 49s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-assemblies . hadoop-submarine
hadoop-submarine/hadoop-submarine-all hadoop-submarine/hadoop-submarine-dist
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
23s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
21s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
39s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
7s{color} | {color:green} The patch generated 0 new + 0 unchanged - 128 fixed =
0 total (was 128) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
13s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 38s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-assemblies . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}161m 14s{color}
| {color:red} root in the patch failed. {color} |
|
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999048#comment-16999048
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 34m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 62 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 19m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 18m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 23s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-project hadoop-assemblies . hadoop-submarine
hadoop-submarine/hadoop-submarine-all hadoop-submarine/hadoop-submarine-dist
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
27s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
28s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
16s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
10s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
9s{color} | {color:red} hadoop-assemblies in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
10s{color} | {color:red} hadoop-project in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 8s{color} | {color:orange} The patch fails to run checkstyle in root
{color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
9s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
7s{color} | {color:green} The patch generated 0 new + 0 unchanged - 128 fixed =
0 total (was 128) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
12s{color} | {color:green} The patch generated 0 new + 104 unchanged - 132
fixed = 104 total (was 236) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} xml {color} | {color:red} 0m 4s{color} |
{color:red} The patch has 1 ill-formed XML file(s). {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 0m
12s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hadoop-assemblies hadoop-project {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998787#comment-16998787 ] Wanqiang Ji commented on HADOOP-16670: -- +1 Agreed with [~weichiu], I think it can be merged, some nits can be addressed in other jira. > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Major > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962342#comment-16962342 ] Wei-Chiu Chuang commented on HADOOP-16670: -- The patch is good to me. There are a few places where submarine is still mentioned, although they don't affect the compilation. ./hadoop-assemblies/src/main/resources/assemblies/hadoop-src.xml: hadoop-submarine/** ./hadoop-project/src/site/site.xml: ./hadoop-project/src/site/site.xml: ./hadoop-project/src/site/site.xml: > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Major > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962057#comment-16962057 ] Zhankun Tang commented on HADOOP-16670: --- [~weichiu], could you please help to review? The Jenkins result for hadoop without submarine doesn't make sense to me. > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Assignee: Zhankun Tang >Priority: Major > Attachments: HADOOP-16670-trunk.001.patch, > HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch, > HADOOP-16670-trunk.004.patch > > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961965#comment-16961965
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 62 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 14m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 1s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-assemblies . hadoop-submarine hadoop-submarine/hadoop-submarine-all
hadoop-submarine/hadoop-submarine-dist {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
27s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
30s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
38s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
7s{color} | {color:green} The patch generated 0 new + 0 unchanged - 128 fixed =
0 total (was 128) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
15s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 40s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-assemblies . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}156m 44s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961626#comment-16961626
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 12s{color}
| {color:red} HADOOP-16670 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-16670 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12984219/HADOOP-16670-trunk.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16614/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Stripping Submarine code from Hadoop codebase.
> --
>
> Key: HADOOP-16670
> URL: https://issues.apache.org/jira/browse/HADOOP-16670
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Zhankun Tang
>Priority: Major
> Attachments: HADOOP-16670-trunk.001.patch,
> HADOOP-16670-trunk.002.patch, HADOOP-16670-trunk.003.patch
>
>
> Now that Submarine is getting out of Hadoop and has its own repo, it's time
> to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[
https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960942#comment-16960942
]
Hadoop QA commented on HADOOP-16670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s{color}
| {color:red} HADOOP-16670 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-16670 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12984158/HADOOP-16670-trunk.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16613/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Stripping Submarine code from Hadoop codebase.
> --
>
> Key: HADOOP-16670
> URL: https://issues.apache.org/jira/browse/HADOOP-16670
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Wei-Chiu Chuang
>Assignee: Zhankun Tang
>Priority: Major
> Attachments: HADOOP-16670-trunk.001.patch
>
>
> Now that Submarine is getting out of Hadoop and has its own repo, it's time
> to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16670) Stripping Submarine code from Hadoop codebase.
[ https://issues.apache.org/jira/browse/HADOOP-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959310#comment-16959310 ] Wangda Tan commented on HADOOP-16670: - +1, > Stripping Submarine code from Hadoop codebase. > -- > > Key: HADOOP-16670 > URL: https://issues.apache.org/jira/browse/HADOOP-16670 > Project: Hadoop Common > Issue Type: Task >Reporter: Wei-Chiu Chuang >Priority: Major > > Now that Submarine is getting out of Hadoop and has its own repo, it's time > to stripe the Submarine code from Hadoop codebase in Hadoop 3.3.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
