[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396791#comment-17396791
]
Renukaprasad C commented on HADOOP-17542:
-
Thanks [~ste...@apache.org] [~weichiu] [~hemanthboyina] [~brahma] for the
review & feedback.
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Assignee: Renukaprasad C
>Priority: Minor
> Labels: ipv6, pull-request-available
> Fix For: HADOOP-17800
>
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396608#comment-17396608
]
Hemanth Boyina commented on HADOOP-17542:
-
thanks for the contribution [~prasad-acit], thanks for the review [~brahmareddy]
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Assignee: Renukaprasad C
>Priority: Minor
> Labels: ipv6, pull-request-available
> Fix For: HADOOP-17800
>
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391646#comment-17391646
]
Renukaprasad C commented on HADOOP-17542:
-
Thanks [~weichiu] [~hemanthboyina],
I have corrected the branch & pushed the changes to branch - HADOOP-17542. Can
you please help to review the changes? Thanks.
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Assignee: Renukaprasad C
>Priority: Minor
> Labels: ipv6, pull-request-available
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391399#comment-17391399
]
Hemanth Boyina commented on HADOOP-17542:
-
Yes [~weichiu], the PR has to be raised against HADOOP-17800 branch ,
[~prasad-acit] can you please do that
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Assignee: Renukaprasad C
>Priority: Minor
> Labels: ipv6, pull-request-available
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391267#comment-17391267
]
Wei-Chiu Chuang commented on HADOOP-17542:
--
I see that PR is being raised against trunk. Should this be done in a branch
instead? [~hemanthboyina]
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Assignee: Renukaprasad C
>Priority: Minor
> Labels: ipv6, pull-request-available
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383842#comment-17383842
]
Renukaprasad C commented on HADOOP-17542:
-
Thanks [~gb.ana...@gmail.com] for reporting issue and the patch.
[~ste...@apache.org] [~hemanthboyina] PR raised -
https://github.com/apache/hadoop/pull/3217. Can you plz take a look?
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Priority: Minor
> Labels: ipv6, pull-request-available
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17363447#comment-17363447
]
Hemanth Boyina commented on HADOOP-17542:
-
[~gb.ana...@gmail.com] can you please raise it as a github PR
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Priority: Minor
> Labels: ipv6
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17542) IPV6 support in Netutils#createSocketAddress
[
https://issues.apache.org/jira/browse/HADOOP-17542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290905#comment-17290905
]
ANANDA G B commented on HADOOP-17542:
-
[~hemanthboyina] Can you please review
> IPV6 support in Netutils#createSocketAddress
> -
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
>Affects Versions: 3.1.1
>Reporter: ANANDA G B
>Priority: Minor
> Labels: ipv6
> Attachments: HADOOP-17542-HADOOP-11890-001.patch
>
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
