[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[
https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758703#comment-17758703
]
ASF GitHub Bot commented on HADOOP-17799:
-
hadoop-yetus commented on PR #5986:
URL: https://github.com/apache/hadoop/pull/5986#issuecomment-1692245882
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 49m 8s | | trunk passed |
| +1 :green_heart: | shadedclient | 87m 0s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 15s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | shadedclient | 37m 10s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not
generate ASF License warnings. |
| | | 130m 29s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5986/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5986 |
| Optional Tests | dupname asflicense shadedclient codespell detsecrets
xmllint |
| uname | Linux ffe770af97e0 4.15.0-212-generic #223-Ubuntu SMP Tue May 23
13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / ab71664ca60e170e0384df8d67e65f8b37a7a976 |
| Max. process+thread count | 531 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-auth-examples U:
hadoop-common-project/hadoop-auth-examples |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5986/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Improve the GitHub pull request template
>
>
> Key: HADOOP-17799
> URL: https://issues.apache.org/jira/browse/HADOOP-17799
> Project: Hadoop Common
> Issue Type: Task
> Components: build, documentation
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The current Hadoop pull request template can be improved.
> - Require some information (e.g.
> https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE)
> - Checklists (e.g.
> https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md)
> - Move current notice to comment (i.e. surround with )
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[ https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758675#comment-17758675 ] ASF GitHub Bot commented on HADOOP-17799: - whoami-anoint closed pull request #5986: HADOOP-17799 URL: https://github.com/apache/hadoop/pull/5986 > Improve the GitHub pull request template > > > Key: HADOOP-17799 > URL: https://issues.apache.org/jira/browse/HADOOP-17799 > Project: Hadoop Common > Issue Type: Task > Components: build, documentation >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The current Hadoop pull request template can be improved. > - Require some information (e.g. > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) > - Checklists (e.g. > https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md) > - Move current notice to comment (i.e. surround with ) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[ https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758673#comment-17758673 ] ASF GitHub Bot commented on HADOOP-17799: - steveloughran commented on PR #5986: URL: https://github.com/apache/hadoop/pull/5986#issuecomment-1692152051 you are expected to create a new JIRA or link to an existing issue; this isn't. can we close this? you now know how to create Hadoop JIRAs. anything touching source code needs tests too, incidentally. > Improve the GitHub pull request template > > > Key: HADOOP-17799 > URL: https://issues.apache.org/jira/browse/HADOOP-17799 > Project: Hadoop Common > Issue Type: Task > Components: build, documentation >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The current Hadoop pull request template can be improved. > - Require some information (e.g. > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) > - Checklists (e.g. > https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md) > - Move current notice to comment (i.e. surround with ) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[ https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758660#comment-17758660 ] ASF GitHub Bot commented on HADOOP-17799: - whoami-anoint opened a new pull request, #5986: URL: https://github.com/apache/hadoop/pull/5986 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Improve the GitHub pull request template > > > Key: HADOOP-17799 > URL: https://issues.apache.org/jira/browse/HADOOP-17799 > Project: Hadoop Common > Issue Type: Task > Components: build, documentation >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The current Hadoop pull request template can be improved. > - Require some information (e.g. > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) > - Checklists (e.g. > https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md) > - Move current notice to comment (i.e. surround with ) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[ https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695515#comment-17695515 ] ASF GitHub Bot commented on HADOOP-17799: - trakos opened a new pull request, #5447: URL: https://github.com/apache/hadoop/pull/5447 ### Description of PR `WebHdfsFileSystem` didn't provide any support for HTTP BASIC authentication (username/password). This patch adds that feature. When specifying filesystem URI, the credentials part (`user:pass@`) is now parsed properly and used for `Authorization` header. Additionally, base path specified in filesystem URL used to be ignored. This patch adds configuration option `dfs.client.webhdfs.use-base-path` that, when enabled, indicates that this path should be used as API prefix. This allows specifying `/gateway/gatewayname` when using WebHdfs for Apache Knox. When base path contains `/webhdfs/v1`, it is ignored, since we always append that. Option `dfs.client.webhdfs.use-base-path` defaults to false because it could introduce a backward compatibility break. Some WebHdfs users could have typos or something random as path, and before this patch it would simply be ignored. By setting the default to false, we make sure that it won't break any existing setup. Note that issue HADOOP-17799 is also about Kerberos auth. This patch only addresses the base path and basic authentication portion, I didn't investigate the Kerberos auth since we don't use in our setup. ### How was this patch tested? I tested it with WebHdfs secured by Apache Knox with basic authorization, but without Kerberos. I had a test script that would perform a file upload. I set `dfs.client.webhdfs.use_basepath` to true, and used `swebhdfs://admin:admin-password@localhost:8443/gateway/docker/` as filesystem URI. Without my patch, both the `admin:admin-password` credentials and `/gateway/docker` API base path would be ignored. With it, file upload worked. ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Improve the GitHub pull request template > > > Key: HADOOP-17799 > URL: https://issues.apache.org/jira/browse/HADOOP-17799 > Project: Hadoop Common > Issue Type: Task > Components: build, documentation >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > The current Hadoop pull request template can be improved. > - Require some information (e.g. > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) > - Checklists (e.g. > https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md) > - Move current notice to comment (i.e. surround with ) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[ https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381065#comment-17381065 ] Akira Ajisaka commented on HADOOP-17799: Thank you [~ste...@apache.org] for your comment. Yes, click on the checklists in rendered markdown, and then they get changed. > Improve the GitHub pull request template > > > Key: HADOOP-17799 > URL: https://issues.apache.org/jira/browse/HADOOP-17799 > Project: Hadoop Common > Issue Type: Task > Components: build, documentation >Reporter: Akira Ajisaka >Priority: Major > > The current Hadoop pull request template can be improved. > - Require some information (e.g. > https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE) > - Checklists (e.g. > https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md) > - Move current notice to comment (i.e. surround with ) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17799) Improve the GitHub pull request template
[
https://issues.apache.org/jira/browse/HADOOP-17799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380610#comment-17380610
]
Steve Loughran commented on HADOOP-17799:
-
* checklists are cute. You noticed you can actually click on them in rendered
markdown and they get changed?
* be nice to add a line for object store
{code}
- [ ] object storage: have the integration tests been executed and the endpoint
declared according to the connector-specific documentation?
{code}
but: we'd want this to be auto-checked for non-object store patches, so I'm not
sure a checkbox suits here.
> Improve the GitHub pull request template
>
>
> Key: HADOOP-17799
> URL: https://issues.apache.org/jira/browse/HADOOP-17799
> Project: Hadoop Common
> Issue Type: Task
> Components: build, documentation
>Reporter: Akira Ajisaka
>Priority: Major
>
> The current Hadoop pull request template can be improved.
> - Require some information (e.g.
> https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE)
> - Checklists (e.g.
> https://github.com/apache/nifi/blob/main/.github/PULL_REQUEST_TEMPLATE.md)
> - Move current notice to comment (i.e. surround with )
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
