[jira] [Commented] (HADOOP-17991) Improve CustomTokenProviderAdapter to import VisibleForTesting
[ https://issues.apache.org/jira/browse/HADOOP-17991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440339#comment-17440339 ] Steve Loughran commented on HADOOP-17991: - im chasing up getting a new PR for HADOOP-17183 with the right import. > Improve CustomTokenProviderAdapter to import VisibleForTesting > -- > > Key: HADOOP-17991 > URL: https://issues.apache.org/jira/browse/HADOOP-17991 > Project: Hadoop Common > Issue Type: Bug >Reporter: JiangHua Zhu >Priority: Major > > Recently, some new features have been added to CustomTokenProviderAdapter, > which is of course very good. > Here is the introduction > of'org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting'. > When using Maven to compile the hadoop project, an error occurred as > expected. > E.g: > org.apache.maven.enforcer.rule.api.EnforcerRuleException: > Banned imports detected: > Reason: Use hadoop-annotation provided VisibleForTesting rather than the one > provided by Guava > in file: > org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java > > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting > (Line: 25, Matched by: > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting) > Analysis took 0 seconds > at de.skuzzle.enforcer.restrictimports.rule.RestrictImports.execute > (RestrictImports.java:70) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:202) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:210) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:282) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:225) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:406) > at org.codehaus.plexus.classworlds.launcher.Launcher.main > (Launcher.java:347) > In the end it was unsuccessful. > In addition, I want to explain that this happened in a Mac environment. > Obviously, we should > introduce'org.apache.hadoop.classification.VisibleForTesting'. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17991) Improve CustomTokenProviderAdapter to import VisibleForTesting
[ https://issues.apache.org/jira/browse/HADOOP-17991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439311#comment-17439311 ] JiangHua Zhu commented on HADOOP-17991: --- Thanks [~ste...@apache.org] for this work. If necessary, we can communicate. > Improve CustomTokenProviderAdapter to import VisibleForTesting > -- > > Key: HADOOP-17991 > URL: https://issues.apache.org/jira/browse/HADOOP-17991 > Project: Hadoop Common > Issue Type: Bug >Reporter: JiangHua Zhu >Priority: Major > > Recently, some new features have been added to CustomTokenProviderAdapter, > which is of course very good. > Here is the introduction > of'org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting'. > When using Maven to compile the hadoop project, an error occurred as > expected. > E.g: > org.apache.maven.enforcer.rule.api.EnforcerRuleException: > Banned imports detected: > Reason: Use hadoop-annotation provided VisibleForTesting rather than the one > provided by Guava > in file: > org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java > > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting > (Line: 25, Matched by: > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting) > Analysis took 0 seconds > at de.skuzzle.enforcer.restrictimports.rule.RestrictImports.execute > (RestrictImports.java:70) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:202) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:210) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:282) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:225) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:406) > at org.codehaus.plexus.classworlds.launcher.Launcher.main > (Launcher.java:347) > In the end it was unsuccessful. > In addition, I want to explain that this happened in a Mac environment. > Obviously, we should > introduce'org.apache.hadoop.classification.VisibleForTesting'. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17991) Improve CustomTokenProviderAdapter to import VisibleForTesting
[ https://issues.apache.org/jira/browse/HADOOP-17991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439300#comment-17439300 ] Steve Loughran commented on HADOOP-17991: - yeah, just noticed. sorry. rolled back > Improve CustomTokenProviderAdapter to import VisibleForTesting > -- > > Key: HADOOP-17991 > URL: https://issues.apache.org/jira/browse/HADOOP-17991 > Project: Hadoop Common > Issue Type: Bug >Reporter: JiangHua Zhu >Priority: Major > > Recently, some new features have been added to CustomTokenProviderAdapter, > which is of course very good. > Here is the introduction > of'org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting'. > When using Maven to compile the hadoop project, an error occurred as > expected. > E.g: > org.apache.maven.enforcer.rule.api.EnforcerRuleException: > Banned imports detected: > Reason: Use hadoop-annotation provided VisibleForTesting rather than the one > provided by Guava > in file: > org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java > > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting > (Line: 25, Matched by: > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting) > Analysis took 0 seconds > at de.skuzzle.enforcer.restrictimports.rule.RestrictImports.execute > (RestrictImports.java:70) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:202) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:210) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:282) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:225) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:406) > at org.codehaus.plexus.classworlds.launcher.Launcher.main > (Launcher.java:347) > In addition, I want to explain that this happened in a Mac environment. > Obviously, we should > introduce'org.apache.hadoop.classification.VisibleForTesting'. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17991) Improve CustomTokenProviderAdapter to import VisibleForTesting
[ https://issues.apache.org/jira/browse/HADOOP-17991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439290#comment-17439290 ] JiangHua Zhu commented on HADOOP-17991: --- I will submit a PR. > Improve CustomTokenProviderAdapter to import VisibleForTesting > -- > > Key: HADOOP-17991 > URL: https://issues.apache.org/jira/browse/HADOOP-17991 > Project: Hadoop Common > Issue Type: Bug >Reporter: JiangHua Zhu >Priority: Major > > Recently, some new features have been added to CustomTokenProviderAdapter, > which is of course very good. > Here is the introduction > of'org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting'. > When using Maven to compile the hadoop project, an error occurred as > expected. > E.g: > org.apache.maven.enforcer.rule.api.EnforcerRuleException: > Banned imports detected: > Reason: Use hadoop-annotation provided VisibleForTesting rather than the one > provided by Guava > in file: > org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java > > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting > (Line: 25, Matched by: > org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting) > Analysis took 0 seconds > at de.skuzzle.enforcer.restrictimports.rule.RestrictImports.execute > (RestrictImports.java:70) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:202) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:210) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:81) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > (SingleThreadedBuilder.java:56) > at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > (LifecycleStarter.java:128) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) > at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) > at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke > (NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke > (DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke (Method.java:498) > at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > (Launcher.java:282) > at org.codehaus.plexus.classworlds.launcher.Launcher.launch > (Launcher.java:225) > at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > (Launcher.java:406) > at org.codehaus.plexus.classworlds.launcher.Launcher.main > (Launcher.java:347) > In addition, I want to explain that this happened in a Mac environment. > Obviously, we should > introduce'org.apache.hadoop.classification.VisibleForTesting'. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
