[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762443#comment-13762443 ] Shinichi Yamashita commented on HADOOP-8704: I commented on a refinement of this implementation in HADOOP-9940. Please look about it. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760991#comment-13760991 ] Hudson commented on HADOOP-8704: SUCCESS: Integrated in Hadoop-Yarn-trunk #325 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/325/]) HADOOP-8704. add request logging to jetty/httpserver (jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520674) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761003#comment-13761003 ] Hudson commented on HADOOP-8704: FAILURE: Integrated in Hadoop-Hdfs-0.23-Build #723 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/723/]) HADOOP-8704. add request logging to jetty/httpserver (jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520682) * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLogAppender.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLogAppender.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761031#comment-13761031 ] Hudson commented on HADOOP-8704: SUCCESS: Integrated in Hadoop-Hdfs-trunk #1515 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1515/]) HADOOP-8704. add request logging to jetty/httpserver (jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520674) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761046#comment-13761046 ] Hudson commented on HADOOP-8704: FAILURE: Integrated in Hadoop-Mapreduce-trunk #1541 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1541/]) HADOOP-8704. add request logging to jetty/httpserver (jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520674) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760220#comment-13760220 ] Alejandro Abdelnur commented on HADOOP-8704: [~jeagles], I've scanned the patch the new approach LGTM. besides fixing the failing testcase, we should include in the log4j.properties (commented out) the configuration for the requestlog appender. This wil make things easier for anybody to enable it and use it. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760247#comment-13760247 ] Alejandro Abdelnur commented on HADOOP-8704: Glad to help. LGTM, +1 pending test-patch results. One last suggested naming change (leaving that to you). The patch is using log4j.logger.http.requests.hdfs/datanode/cluster/jobhistory/node. Instead, shouldn't we use the proper service name? namenode/datanode/resourcemanager/jobhistory/nodemanager/... ? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760271#comment-13760271 ] Jonathan Eagles commented on HADOOP-8704: - Sounds good. Patch forthcoming. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760251#comment-13760251 ] Jonathan Eagles commented on HADOOP-8704: - I also prefer the naming you suggest. Unfortunately, the HttpServers are constructed with other list of names. I thought about creating a lookup map inside the Request Logger. Perhaps it would be better just to name the HttpServers correctly. Of course, I don't know what that would break. :) add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760255#comment-13760255
]
Hadoop QA commented on HADOOP-8704:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601830/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3068//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3068//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760257#comment-13760257 ] Alejandro Abdelnur commented on HADOOP-8704: arghh, the name is used for the webapp path. not a good idea to change. the internal map would do, and future proofing it, if the map does not define a value, we use the given name. What do you think? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760323#comment-13760323 ] Jonathan Eagles commented on HADOOP-8704: - Added internal map and updated documentation to reflect changes. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760348#comment-13760348
]
Hadoop QA commented on HADOOP-8704:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601841/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3069//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3069//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760517#comment-13760517 ] Shinichi Yamashita commented on HADOOP-8704: I applied the latest patch and start Hadoop cluster. It is very good because I can confirm necessary information. And I think that it is necessary for the DateFormat in the log to be modifiable. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760547#comment-13760547 ] Jonathan Eagles commented on HADOOP-8704: - [~sinchii] HADOOP-9940 can be used to address your feature requests. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760524#comment-13760524 ] Jonathan Eagles commented on HADOOP-8704: - Thanks, [~sinchii] for you feedback. As this JIRA is being checked in currently, I will file another JIRA with these new feature requests you are stating. I will post the JIRA to this ticket and we can work together to get this feature in as soon as we can. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760571#comment-13760571 ] Jonathan Eagles commented on HADOOP-8704: - Thanks [~tucu00] and everyone who committed to this patch! add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Fix For: 3.0.0, 2.3.0, 0.23.10 Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760551#comment-13760551 ] Hudson commented on HADOOP-8704: SUCCESS: Integrated in Hadoop-trunk-Commit #4381 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4381/]) HADOOP-8704. add request logging to jetty/httpserver (jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1520674) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/log4j.properties * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/HttpServerFunctionalTest.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLog.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpRequestLogAppender.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759665#comment-13759665
]
Hadoop QA commented on HADOOP-8704:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601708/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.http.TestHttpRequestLog
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3066//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3066//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757601#comment-13757601 ] Alejandro Abdelnur commented on HADOOP-8704: Do we really need the RequestLogAppenderFactory class? Wouldn't be enough to have the NCSARequestLogAppender class, use it to define an appended in the log4j.properties config and make sure the right logger category uses it? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757922#comment-13757922 ] Jonathan Eagles commented on HADOOP-8704: - Good comment, Alejandro. Initially, I started with something similar to what you are talking about. See [https://issues.apache.org/jira/secure/attachment/12600275/HADOOP-8704.patch]. Once I began testing the components, i found it a little unwieldy since it tied the appender class to the runtime environment. Let me see what i would look like to embed that logic inside the NCSARequestLogAppender constructor and see if we can get the best of both worlds without the complexity of a factory class. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758319#comment-13758319 ] Jonathan Eagles commented on HADOOP-8704: - [~tucu00]. So here is what I found out when looking at whether or not the factory class can be eliminated easily. Firstly, there are 2 design approaches on the table I debated. 1) Define one appender in log4j.properties per http server or 2) define one appender shared for all http servers. I chose the latter since at runtime I can update the filename to include bind address and port for better use in one node environments (avoiding file naming conflicts among different http servers). In that design a helper is needed to construct the RequestLog since the filename isn't fully known without bind address and port. At first I included a static help function in NCSARequestLogAppender but then found that the helper function could be refactored out of the class. This leaves an appender class that is very simply to use and simple to test. So were you thinking it would be better with 1) one appender configuration per http server, using static filenames, removing the need for a helper construction or 2) consolidate the factory and the appender class so that the construction help was a static function within the appender class or 3) something else. Jon add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13758337#comment-13758337
]
Hadoop QA commented on HADOOP-8704:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601452/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3063//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3063//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch, HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757114#comment-13757114
]
Hadoop QA commented on HADOOP-8704:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601239/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.http.TestHttpServerLifecycle
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3055//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3055//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753276#comment-13753276
]
Hadoop QA commented on HADOOP-8704:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600533/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3032//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3032//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751795#comment-13751795 ] Jonathan Eagles commented on HADOOP-8704: - Addressed Alejandro's comments of configuring logger via log4j via a newly written appender. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751799#comment-13751799 ] Jonathan Eagles commented on HADOOP-8704: - Kept using the NCSARequestLog under the hood to keep web analyzer tools happy since NCSARequestLog format is the pseudo standard. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751808#comment-13751808 ] Jonathan Eagles commented on HADOOP-8704: - Kihwal, based on the code I see for handle in HandlerCollection, it seems like exceptions thrown from handlers are rethrown. I would guess that you would expect to log first withthe request handler and the use the context handler second to ensure that all requests are logged even in exceptional cases. http://grepcode.com/file/repo1.maven.org/maven2/org.mortbay.jetty/jetty/6.1.26/org/mortbay/jetty/handler/HandlerCollection.java#HandlerCollection add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch, HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13751812#comment-13751812
]
Hadoop QA commented on HADOOP-8704:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600275/HADOOP-8704.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3026//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch, HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749599#comment-13749599
]
Hadoop QA commented on HADOOP-8704:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599265/HADOOP-8704.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3015//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3015//console
This message is automatically generated.
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748726#comment-13748726
]
Kihwal Lee commented on HADOOP-8704:
{noformat} handlers.setHandlers(new Handler[] {contexts, requestLogHandler});
{noformat}
Does this mean failed requests won't get logged?
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.0.0-alpha
Reporter: Thomas Graves
Assignee: Jonathan Eagles
Attachments: HADOOP-8704.patch
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748740#comment-13748740 ] Kihwal Lee commented on HADOOP-8704: bq. Does this mean failed requests won't get logged? A better question will be: does any handler call setHandled(true) in any case before reaching the log handler? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747600#comment-13747600 ] Jonathan Eagles commented on HADOOP-8704: - If going with this approach, I would definitely add new Configuration parameters and update the documentation. [~tgraves] or [~tucu00] do you think comment whether this approach is a sufficient solution or a least acceptable until a full blown implementation can be put together either (either as part of a distant jetty 9 upgrade or separately) add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746814#comment-13746814 ] Jonathan Eagles commented on HADOOP-8704: - Posted a patch to get this conversation started again. Essentially used the builtin jetty logger NCSARequestLog that subclasses the appropriate RequestLogHandler. Added configuration that allows each http server to opt into and configure logger options. A separate jetty request log will be generated for each jetty port and bindaddress to alow for single node and multinode use cases. At first I thought about going down the approach of creating a special subclass for RequestLogHandler, but thought that might be overkill especially since an slf4j implementation is shipping with jetty 9. In this case I wonder if a small short term solution allows us to wait for a more elaborate solution down the line. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746816#comment-13746816 ] Jonathan Eagles commented on HADOOP-8704: - [~tucu00], do you think you could comment on the approach and the patch implementation for the short term describe above? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.0.0-alpha Reporter: Thomas Graves Assignee: Jonathan Eagles Attachments: HADOOP-8704.patch We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435453#comment-13435453 ] Alejandro Abdelnur commented on HADOOP-8704: A servlet-filter would cleanly do the trick. If this includes shuffle, in trunk/branch-2 you'll have to do it in netty. I assume you already thought of this, but there should be an ON/OFF switch in core-site.xml for this. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.1.0-alpha Reporter: Thomas Graves We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435455#comment-13435455 ] Thomas Graves commented on HADOOP-8704: --- Found this page about logging request: http://docs.codehaus.org/display/JETTY/Logging+Requests Perhaps there is an easier way without code changes - any Jetty experts out there? add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.1.0-alpha Reporter: Thomas Graves We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435487#comment-13435487
]
Alejandro Abdelnur commented on HADOOP-8704:
we configure jetty programmatically, I don't think the config file approach
will work, still we could leverage the
{{org.mortbay.jetty.handler.RequestLogHandler}} class
add request logging to jetty/httpserver
---
Key: HADOOP-8704
URL: https://issues.apache.org/jira/browse/HADOOP-8704
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 0.23.3, 2.1.0-alpha
Reporter: Thomas Graves
We have been requested to log all the requests coming into Jetty/HttpServer
for security and auditing purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435489#comment-13435489 ] Alejandro Abdelnur commented on HADOOP-8704: And we should make sure it the logging it is configured via the existing log4j.properties, most likely via a new appender. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.1.0-alpha Reporter: Thomas Graves We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
[ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435494#comment-13435494 ] Thomas Graves commented on HADOOP-8704: --- thanks Alejandro. Yeah I was hoping to do something simple with the log4j to configure as you mentioned in a generic way that others could re-use. If folks don't think its useful I can go the filter route. add request logging to jetty/httpserver --- Key: HADOOP-8704 URL: https://issues.apache.org/jira/browse/HADOOP-8704 Project: Hadoop Common Issue Type: Improvement Affects Versions: 0.23.3, 2.1.0-alpha Reporter: Thomas Graves We have been requested to log all the requests coming into Jetty/HttpServer for security and auditing purposes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
