[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491905#comment-13491905 ] Sanjay Radia commented on HADOOP-8957: -- * You have added viewFS#resolveFromFSState where you validate the path for mounts ** The mounted file systems will validate the path names anyway - so is this necessary? ** What about validating internal names (ie within the mounted) which your patch does not. *** Add a test for that. *** One could argue that the pathname validity check for internal names is needed *only* when the mount table is created, since illegal names will not match to any internal names within the mount table. This translates to whether one wants IllegalNameException or PathNotFoundException when the user does open(illegal:path). I think your patch returns PathNotFoundException for internal names that are illegal. ** You didn't use resolveFromFSState in ViewFileSystem? Shouldn't ViewFs and ViewFileSystem be consistent? ** Minor - a better name would have been validatePathAndResolve * AbstractFileSystem#isValidName - Being able to override isValidName makes sense but the default impl should not return true; instead the default impl should be the code needed by HDFS -- file systems that need a different impl can override this method. FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: 3.0.0, trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth Attachments: HADOOP-8957.patch, HADOOP-8957.patch This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491911#comment-13491911 ] Sanjay Radia commented on HADOOP-8957: -- The jira name should be AbstractFileSystem#IsValidName should be overridden for embedded file systems like ViewFs FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: 3.0.0, trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth Attachments: HADOOP-8957.patch, HADOOP-8957.patch This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489317#comment-13489317
]
Hadoop QA commented on HADOOP-8957:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12551829/HADOOP-8957.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1696//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1696//console
This message is automatically generated.
FileContext.getFileContext causes multiple test failures on Windows due to
InvocationTargetException
Key: HADOOP-8957
URL: https://issues.apache.org/jira/browse/HADOOP-8957
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HADOOP-8957.patch, HADOOP-8957.patch
This appears to be a problem with parsing a Windows-specific path, ultimately
throwing InvocationTargetException from AbstractFileSystem.newInstance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489257#comment-13489257 ] Suresh Srinivas commented on HADOOP-8957: - Chris, some minor comments: # Hdfs.java - no need for @see. @override takes care of ensuring that the javadoc points to the base class. This change is needed also for FilterFs.java, ChRootedFs, # Hdfs.java Instead of saying Check for ..., please be explicit in the comment that the patterns are prohibited. # ViewFileSystem.java - Can you describe why isValidName override and check is removed? Otherwise change looks good. FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: 3.0.0, trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth Attachments: HADOOP-8957.patch This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485914#comment-13485914
]
Hadoop QA commented on HADOOP-8957:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12551168/HADOOP-8957.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1681//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1681//console
This message is automatically generated.
FileContext.getFileContext causes multiple test failures on Windows due to
InvocationTargetException
Key: HADOOP-8957
URL: https://issues.apache.org/jira/browse/HADOOP-8957
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HADOOP-8957.patch
This appears to be a problem with parsing a Windows-specific path, ultimately
throwing InvocationTargetException from AbstractFileSystem.newInstance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483886#comment-13483886 ] Chris Nauroth commented on HADOOP-8957: --- Additional test suites failing because of this: org.apache.hadoop.fs.viewfs.TestChRootedFs FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482473#comment-13482473 ] Chris Nauroth commented on HADOOP-8957: --- Additional test suites failing because of this: org.apache.hadoop.fs.viewfs.TestViewFsLocalFs org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[ https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482701#comment-13482701 ] Chris Nauroth commented on HADOOP-8957: --- I am in progress on a fix. FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException Key: HADOOP-8957 URL: https://issues.apache.org/jira/browse/HADOOP-8957 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: trunk-win Reporter: Chris Nauroth Assignee: Chris Nauroth This appears to be a problem with parsing a Windows-specific path, ultimately throwing InvocationTargetException from AbstractFileSystem.newInstance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException
[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481678#comment-13481678
]
Chris Nauroth commented on HADOOP-8957:
---
The failing test suites are:
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
{code}
testMkdirNonRecursiveWithExistingDir(org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs)
Time elapsed: 125 sec ERROR!
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at
org.apache.hadoop.fs.AbstractFileSystem.newInstance(AbstractFileSystem.java:123)
at
org.apache.hadoop.fs.AbstractFileSystem.createFileSystem(AbstractFileSystem.java:149)
at
org.apache.hadoop.fs.AbstractFileSystem.get(AbstractFileSystem.java:234)
at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:324)
at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:321)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:396)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1378)
at
org.apache.hadoop.fs.FileContext.getAbstractFileSystem(FileContext.java:321)
at org.apache.hadoop.fs.FileContext.getFileContext(FileContext.java:435)
at
org.apache.hadoop.fs.viewfs.ViewFsTestSetup.setupForViewFsLocalFs(ViewFsTestSetup.java:73)
at
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs.setUp(TestFcCreateMkdirLocalFs.java:34)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at
org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
at
org.apache.hadoop.fs.AbstractFileSystem.newInstance(AbstractFileSystem.java:121)
... 41 more
Caused by: org.apache.hadoop.fs.InvalidPathException: Invalid path name Path
part /C:/hdc/hadoop-common-project/hadoop-common/target/test/data/test from URI
