[jira] [Commented] (HADOOP-9207) version info source checksum does not include all source files
[ https://issues.apache.org/jira/browse/HADOOP-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282201#comment-15282201 ] Allen Wittenauer commented on HADOOP-9207: -- Is this actually still valid? > version info source checksum does not include all source files > -- > > Key: HADOOP-9207 > URL: https://issues.apache.org/jira/browse/HADOOP-9207 > Project: Hadoop Common > Issue Type: Bug > Components: build >Affects Versions: 3.0.0-alpha1 >Reporter: Chris Nauroth > > The build process takes an MD5 checksum of the source files in Common and > YARN. The HDFS version info command prints the checksum from Common. The > YARN version info command prints the checksum from YARN. This is incomplete > in that the HDFS source code is never included in the checksum, and 2 > different YARN builds with the same YARN code but different Common code would > have the same checksum. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-9207) version info source checksum does not include all source files
[ https://issues.apache.org/jira/browse/HADOOP-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553298#comment-13553298 ] Alejandro Abdelnur commented on HADOOP-9207: A possible way (a bit peculiar) of doing this would be to have the version plugin defined only in hadoop-common and have as fileset something like: {code} ../../**/src/main/java/**/*.java ../../**/src/main/proto/**/*.proto {code} And we should get rid of the YarnVersionInfo.java class and use the VersionInfo.java instead. > version info source checksum does not include all source files > -- > > Key: HADOOP-9207 > URL: https://issues.apache.org/jira/browse/HADOOP-9207 > Project: Hadoop Common > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Chris Nauroth > > The build process takes an MD5 checksum of the source files in Common and > YARN. The HDFS version info command prints the checksum from Common. The > YARN version info command prints the checksum from YARN. This is incomplete > in that the HDFS source code is never included in the checksum, and 2 > different YARN builds with the same YARN code but different Common code would > have the same checksum. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9207) version info source checksum does not include all source files
[ https://issues.apache.org/jira/browse/HADOOP-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553161#comment-13553161 ] Chris Nauroth commented on HADOOP-9207: --- Quoting an earlier comment from HADOOP-8924: {quote} The most important use of the checksum is to enforce the constraint that all the servers talking to each other be running code compiled from the same source tree. {quote} Considering this, I think the best solution is to calculate a single global checksum for the whole project and use the same value across all modules. > version info source checksum does not include all source files > -- > > Key: HADOOP-9207 > URL: https://issues.apache.org/jira/browse/HADOOP-9207 > Project: Hadoop Common > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Chris Nauroth > > The build process takes an MD5 checksum of the source files in Common and > YARN. The HDFS version info command prints the checksum from Common. The > YARN version info command prints the checksum from YARN. This is incomplete > in that the HDFS source code is never included in the checksum, and 2 > different YARN builds with the same YARN code but different Common code would > have the same checksum. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9207) version info source checksum does not include all source files
[ https://issues.apache.org/jira/browse/HADOOP-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553154#comment-13553154 ] Chris Nauroth commented on HADOOP-9207: --- See HADOOP-8924 for some earlier discussion on this topic. We could either calculate a single MD5 checksum across the whole project and use it for both HDFS and YARN, or calculate separate checksums per module, but with inclusion of the Common code in each one. > version info source checksum does not include all source files > -- > > Key: HADOOP-9207 > URL: https://issues.apache.org/jira/browse/HADOOP-9207 > Project: Hadoop Common > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 >Reporter: Chris Nauroth > > The build process takes an MD5 checksum of the source files in Common and > YARN. The HDFS version info command prints the checksum from Common. The > YARN version info command prints the checksum from YARN. This is incomplete > in that the HDFS source code is never included in the checksum, and 2 > different YARN builds with the same YARN code but different Common code would > have the same checksum. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira