[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672311#comment-13672311 ] Luke Lu commented on HADOOP-9560: - Should've used memHeap.getMax() to be more concise and consistent with the rest of the code. metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.1.0-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.1.0-beta Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658232#comment-13658232 ] Hudson commented on HADOOP-9560: Integrated in Hadoop-Yarn-trunk #210 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/210/]) HADOOP-9560. metrics2#JvmMetrics should have max memory size of JVM. Contributed by Tsuyoshi Ozawa. (Revision 1482372) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482372 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.0.5-beta Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658341#comment-13658341 ] Hudson commented on HADOOP-9560: Integrated in Hadoop-Hdfs-trunk #1399 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1399/]) HADOOP-9560. metrics2#JvmMetrics should have max memory size of JVM. Contributed by Tsuyoshi Ozawa. (Revision 1482372) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482372 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.0.5-beta Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658377#comment-13658377 ] Hudson commented on HADOOP-9560: Integrated in Hadoop-Mapreduce-trunk #1426 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1426/]) HADOOP-9560. metrics2#JvmMetrics should have max memory size of JVM. Contributed by Tsuyoshi Ozawa. (Revision 1482372) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482372 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetricsInfo.java metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.0.5-beta Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657133#comment-13657133 ] Tsuyoshi OZAWA commented on HADOOP-9560: Thank you too, Suresh! metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Fix For: 2.0.5-beta Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[
https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655797#comment-13655797
]
Hadoop QA commented on HADOOP-9560:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582886/HADOOP-9560.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2536//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2536//console
This message is automatically generated.
metrics2#JvmMetrics should have max memory size of JVM
--
Key: HADOOP-9560
URL: https://issues.apache.org/jira/browse/HADOOP-9560
Project: Hadoop Common
Issue Type: Improvement
Components: metrics
Affects Versions: 3.0.0, 2.0.5-beta
Reporter: Tsuyoshi OZAWA
Assignee: Tsuyoshi OZAWA
Priority: Minor
Attachments: HADOOP-9560.1.patch
metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option.
metrics2#JvmMetrics doesn't have it but it should also have max memory size
of JVM, because it's useful for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655809#comment-13655809 ] Tsuyoshi OZAWA commented on HADOOP-9560: The current TestJvmMetrics is enough to test. metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9560) metrics2#JvmMetrics should have max memory size of JVM
[ https://issues.apache.org/jira/browse/HADOOP-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13656506#comment-13656506 ] Suresh Srinivas commented on HADOOP-9560: - +1 for the patch. I will commit it shortly. metrics2#JvmMetrics should have max memory size of JVM -- Key: HADOOP-9560 URL: https://issues.apache.org/jira/browse/HADOOP-9560 Project: Hadoop Common Issue Type: Improvement Components: metrics Affects Versions: 3.0.0, 2.0.5-beta Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: HADOOP-9560.1.patch metrics#JvmMetrics have the max memory size of JVM specified by -Xmx option. metrics2#JvmMetrics doesn't have it but it should also have max memory size of JVM, because it's useful for users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
