[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659264#comment-13659264 ] Tian Hong Wang commented on HADOOP-9563: Thanks Suresh for your suggestion. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658115#comment-13658115 ] Tian Hong Wang commented on HADOOP-9563: Add patch to support hbase startup script. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[
https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658130#comment-13658130
]
Hadoop QA commented on HADOOP-9563:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583287/HADOOP-9563.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2543//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2543//console
This message is automatically generated.
Fix incompatibility introduced by HADOOP-9523
-
Key: HADOOP-9563
URL: https://issues.apache.org/jira/browse/HADOOP-9563
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 3.0.0, 2.0.5-beta
Reporter: Kihwal Lee
Assignee: Tian Hong Wang
Attachments: HADOOP-9563.patch
HADOOP-9523 changed the output format of the platform name util, so hbase
won't start unless platform name is specifically set.
We could add a command line option to output in the new extended format and
keep the old format when no option is given.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658138#comment-13658138 ] Tian Hong Wang commented on HADOOP-9563: Suresh, can you include this patch? Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658146#comment-13658146 ] Suresh Srinivas commented on HADOOP-9563: - +1 for the patch. This essentially reverts the output of PlatformName main to what was prior to HADOOP-9523. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658151#comment-13658151 ] Tian Hong Wang commented on HADOOP-9563: Thanks Suresh for your comment. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658157#comment-13658157 ] Hudson commented on HADOOP-9563: Integrated in Hadoop-trunk-Commit #3755 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3755/]) HADOOP-9563. Fix incompatibility introduced by HADOOP-9523. Contributed by Tian Hong Wang. (Revision 1482709) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482709 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PlatformName.java Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658231#comment-13658231 ] Hudson commented on HADOOP-9563: Integrated in Hadoop-Yarn-trunk #210 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/210/]) HADOOP-9563. Fix incompatibility introduced by HADOOP-9523. Contributed by Tian Hong Wang. (Revision 1482709) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482709 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PlatformName.java Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658340#comment-13658340 ] Hudson commented on HADOOP-9563: Integrated in Hadoop-Hdfs-trunk #1399 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1399/]) HADOOP-9563. Fix incompatibility introduced by HADOOP-9523. Contributed by Tian Hong Wang. (Revision 1482709) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482709 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PlatformName.java Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658376#comment-13658376 ] Hudson commented on HADOOP-9563: Integrated in Hadoop-Mapreduce-trunk #1426 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1426/]) HADOOP-9563. Fix incompatibility introduced by HADOOP-9523. Contributed by Tian Hong Wang. (Revision 1482709) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1482709 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/PlatformName.java Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658391#comment-13658391 ] Tian Hong Wang commented on HADOOP-9563: Suresh, talked with IBM hadoop dev team internally, we will push the patchset later after internal testing with other hadoop components successfully at first. So could you please revert the patch of HADOOP-9523 HADOOP-9563? Thanks. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658405#comment-13658405 ] Suresh Srinivas commented on HADOOP-9563: - bq. Suresh, talked with IBM hadoop dev team internally, Both HADOOP-9523 and HADOOP-9563 look like reasonable changes to make. I am not sure I understand this and why the patch should be reverted in Apache? bq. we will push the patchset later after internal testing with other hadoop components successfully at first Please do create new jiras if you uncover more issues. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658418#comment-13658418 ] Tian Hong Wang commented on HADOOP-9563: Suresh, IBM internal team decide to have a whole testing of this patch. I am asked to undo this patch. So Suresh, please revert patch of HADOOP-9523 and HADOOP-9563 for me now. We will resubmit it later after whole testing. Thanks. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13658528#comment-13658528 ] Suresh Srinivas commented on HADOOP-9563: - This is a strange request. As I said earlier, these are trivial changes to add a constant to be reused. I do not understand how this could affect any testing. IBM internal team decide to have a whole testing of this patch. I am asked to undo this patch. is not a good enough reason for me to revert this patch. Please explain the technical reasons why this causes problems and hence should be reverted. bq. We will resubmit it later after whole testing. Please make updated patches available in a separate jira when your testing completes. Feel free to change the code introduced in these two jiras in the new jiras, if they are issues. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee Assignee: Tian Hong Wang Fix For: 2.0.5-beta Attachments: HADOOP-9563.patch HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9563) Fix incompatibility introduced by HADOOP-9523
[ https://issues.apache.org/jira/browse/HADOOP-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13657397#comment-13657397 ] Kihwal Lee commented on HADOOP-9563: I am not sure about the effectiveness of annotation since it was command line interface invoked from the start-up script. Fix incompatibility introduced by HADOOP-9523 - Key: HADOOP-9563 URL: https://issues.apache.org/jira/browse/HADOOP-9563 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 3.0.0, 2.0.5-beta Reporter: Kihwal Lee HADOOP-9523 changed the output format of the platform name util, so hbase won't start unless platform name is specifically set. We could add a command line option to output in the new extended format and keep the old format when no option is given. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
