[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735058#comment-13735058 ] Alejandro Abdelnur commented on HADOOP-9675: yep please, +1 releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697058#comment-13697058 ] Colin Patrick McCabe commented on HADOOP-9675: -- from the mailing list: While I agree that it would be nice to fix relnotes.py, it seems to me that setting svn:eol-style=native should fix the problem completely. Files with this attribute set are stored internally by subversion with all newlines as LF, and converted to CRLF as needed. After all, eol-style=native would not be very useful if it only applied on checkout. Windows users would be constantly checking in CRLF in that case. I'm not an svn expert, though, and I haven't tested the above. releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696220#comment-13696220 ] Luke Lu commented on HADOOP-9675: - The problem is due to relnotes.py generating the html containing _some_ CRLF (from JIRA) and the release manager is not using git-svn, which caused the html with mixed eols getting checked in. The problem will manifest with git users due to text=auto in .gitattributes (see HADOOP-8912) that auto converts CRLF to LF, hence the persistent modified status of the releasenotes.html. I'm not sure svn:eol-style=native will fix the problem as it's for checkout only. I think the right fix is fixing relnotes.py to normalize eols in JIRA field. releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696221#comment-13696221 ] Konstantin Boudnik commented on HADOOP-9675: I agree: fixing the generator is the way to go. CRLF in the html file is a symptom. releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[
https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696254#comment-13696254
]
Chris Nauroth commented on HADOOP-9675:
---
FWIW, git users generally can make this problem go away by running:
{code}
git rm -r --cached * git reset HEAD --hard
{code}
Just make sure you don't have any important code changes in progress before
running git rm. :-)
releasenotes.html always shows up as modified because of line endings issues
Key: HADOOP-9675
URL: https://issues.apache.org/jira/browse/HADOOP-9675
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Sandy Ryza
Assignee: Colin Patrick McCabe
Attachments: HADOOP-9675.001.patch
hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html
shows up as modified even though I haven't touched it, and I can't check it
out or reset to a previous version to make that go away. The only thing I
can do to neutralize it is to put it in a dummy commit, but I have to do this
every time I switch branches or rebase.
This appears to have began after the release notes commit
(8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings
change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696261#comment-13696261 ] Luke Lu commented on HADOOP-9675: - bq. git rm -r --cached * git reset HEAD --hard Have you tried this? It doesn't work :) releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[
https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696265#comment-13696265
]
Chris Nauroth commented on HADOOP-9675:
---
That's odd. It worked for me. Maybe it also requires this setting that I have
in my ~/.gitconfig?
{code}
[core]
autocrlf = false
{code}
releasenotes.html always shows up as modified because of line endings issues
Key: HADOOP-9675
URL: https://issues.apache.org/jira/browse/HADOOP-9675
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Sandy Ryza
Assignee: Colin Patrick McCabe
Attachments: HADOOP-9675.001.patch
hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html
shows up as modified even though I haven't touched it, and I can't check it
out or reset to a previous version to make that go away. The only thing I
can do to neutralize it is to put it in a dummy commit, but I have to do this
every time I switch branches or rebase.
This appears to have began after the release notes commit
(8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings
change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[
https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695875#comment-13695875
]
Hadoop QA commented on HADOOP-9675:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590076/HADOOP-9675.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-mapreduce-project/hadoop-mapreduce-examples
hadoop-tools/hadoop-streaming:
org.apache.hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2709//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2709//console
This message is automatically generated.
releasenotes.html always shows up as modified because of line endings issues
Key: HADOOP-9675
URL: https://issues.apache.org/jira/browse/HADOOP-9675
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Sandy Ryza
Assignee: Colin Patrick McCabe
Attachments: HADOOP-9675.001.patch
hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html
shows up as modified even though I haven't touched it, and I can't check it
out or reset to a previous version to make that go away. The only thing I
can do to neutralize it is to put it in a dummy commit, but I have to do this
every time I switch branches or rebase.
This appears to have began after the release notes commit
(8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings
change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695964#comment-13695964 ] Colin Patrick McCabe commented on HADOOP-9675: -- this is a doc change-- that's why there are no new tests. The TestHttpFSFWithWebhdfsFileSystem failure is not related. releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9675) releasenotes.html always shows up as modified because of line endings issues
[ https://issues.apache.org/jira/browse/HADOOP-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13696042#comment-13696042 ] Ravi Prakash commented on HADOOP-9675: -- Thanks a lot for fixing this! This is super annoying with git. Would it make sense to integrate this into test-patch.sh? Or is this something that changes when a committer inadvertently checks it in? releasenotes.html always shows up as modified because of line endings issues Key: HADOOP-9675 URL: https://issues.apache.org/jira/browse/HADOOP-9675 Project: Hadoop Common Issue Type: Improvement Affects Versions: 2.1.0-beta Reporter: Sandy Ryza Assignee: Colin Patrick McCabe Attachments: HADOOP-9675.001.patch hadoop-common-project/hadoop-common/src/main/docs/releasenotes.html shows up as modified even though I haven't touched it, and I can't check it out or reset to a previous version to make that go away. The only thing I can do to neutralize it is to put it in a dummy commit, but I have to do this every time I switch branches or rebase. This appears to have began after the release notes commit (8c5676830bb176157b2dc28c48cd3dd0a9712741), and must be due to a line endings change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
