[jira] [Updated] (HADOOP-10352) Recursive setfacl erroneously attempts to apply default ACL to files.
[ https://issues.apache.org/jira/browse/HADOOP-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-10352: -- Fix Version/s: (was: 3.0.0) 2.4.0 Recursive setfacl erroneously attempts to apply default ACL to files. - Key: HADOOP-10352 URL: https://issues.apache.org/jira/browse/HADOOP-10352 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: 3.0.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Fix For: 2.4.0 Attachments: HADOOP-10352.1.patch When calling setfacl -R with an ACL spec containing default ACL entries, the command can fail if there is a mix of directories and files underneath the specified path. It attempts to set the default ACL entries on the files, but only directories can have a default ACL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-10352) Recursive setfacl erroneously attempts to apply default ACL to files.
[
https://issues.apache.org/jira/browse/HADOOP-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-10352:
---
Attachment: HADOOP-10352.1.patch
The attached patch splits off a separate list of just the access ACL entries.
Then, as the command recurses through the tree, files get just the access ACL
entries and directories get the full list of access and default ACL entries.
This matches the behavior of Linux setfacl.
I also added tests covering each of the 3 APIs in {{TestAclCLI}}.
Recursive setfacl erroneously attempts to apply default ACL to files.
-
Key: HADOOP-10352
URL: https://issues.apache.org/jira/browse/HADOOP-10352
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HADOOP-10352.1.patch
When calling setfacl -R with an ACL spec containing default ACL entries, the
command can fail if there is a mix of directories and files underneath the
specified path. It attempts to set the default ACL entries on the files, but
only directories can have a default ACL.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (HADOOP-10352) Recursive setfacl erroneously attempts to apply default ACL to files.
[ https://issues.apache.org/jira/browse/HADOOP-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-10352: --- Status: Patch Available (was: Open) Recursive setfacl erroneously attempts to apply default ACL to files. - Key: HADOOP-10352 URL: https://issues.apache.org/jira/browse/HADOOP-10352 Project: Hadoop Common Issue Type: Bug Components: fs Affects Versions: 3.0.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Attachments: HADOOP-10352.1.patch When calling setfacl -R with an ACL spec containing default ACL entries, the command can fail if there is a mix of directories and files underneath the specified path. It attempts to set the default ACL entries on the files, but only directories can have a default ACL. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (HADOOP-10352) Recursive setfacl erroneously attempts to apply default ACL to files.
[
https://issues.apache.org/jira/browse/HADOOP-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-10352:
---
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed this to trunk. Thank you for the code review, Arpit.
The failure in {{TestHASafeMode}} was unrelated. I couldn't reproduce it
locally.
Recursive setfacl erroneously attempts to apply default ACL to files.
-
Key: HADOOP-10352
URL: https://issues.apache.org/jira/browse/HADOOP-10352
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 3.0.0
Attachments: HADOOP-10352.1.patch
When calling setfacl -R with an ACL spec containing default ACL entries, the
command can fail if there is a mix of directories and files underneath the
specified path. It attempts to set the default ACL entries on the files, but
only directories can have a default ACL.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
