[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Attachment: hadoop-13398-notes.pdf Notes attached. > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch, > HADOOP-13398-HADOOP-13070.02.patch, HADOOP-13398-HADOOP-13070.03.patch, > HADOOP-13398-HADOOP-13070.04.patch, hadoop-13398-notes.pdf > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (including > {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Attachment: HADOOP-13398-HADOOP-13070.04.patch v.4 patch posted. This implements the support for ClassLoader.getResources() per proposal mentioned above and on HADOOP-13070. This is now a pretty much ready patch. The only thing I haven't done is to merge the new unit test into {{TestApplicationClassLoader}} and reconcile them. Again, your reviews and feedback would be greatly appreciated. Thanks! > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch, > HADOOP-13398-HADOOP-13070.02.patch, HADOOP-13398-HADOOP-13070.03.patch, > HADOOP-13398-HADOOP-13070.04.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (including > {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Attachment: HADOOP-13398-HADOOP-13070.03.patch v.3 patch posted. Addressed checkstyle issues. > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch, > HADOOP-13398-HADOOP-13070.02.patch, HADOOP-13398-HADOOP-13070.03.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (including > {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Attachment: HADOOP-13398-HADOOP-13070.02.patch v.2 patch posted. I have completed a set of unit tests that actually tests user classes and parent classes loading various classes and resources. This is still work in progress. Still to be done: - address {{ClassLoader.getResources()}} per [comment|https://issues.apache.org/jira/browse/HADOOP-13070?focusedCommentId=15742855&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15742855] in HADOOP-13070 - combining and reconciling this new unit test with the existing ones Your reviews are greatly appreciated. I'd like to get feedback on the unit tests too. Thanks! > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch, > HADOOP-13398-HADOOP-13070.02.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (including > {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Description: Today, a user class is able to trigger loading a class from Hadoop's dependencies, with or without the use of {{ApplicationClassLoader}}, and it creates an implicit dependence from users' code on Hadoop's dependencies, and as a result dependency conflicts. We should modify {{ApplicationClassLoader}} to prevent a user class from loading a class from the parent classpath. This should also cover resource loading (including {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). was: Today, a user class is able to trigger loading a class from Hadoop's dependencies, with or without the use of {{ApplicationClassLoader}}, and it creates an implicit dependence from users' code on Hadoop's dependencies, and as a result dependency conflicts. We should modify {{ApplicationClassLoader}} to prevent a user class from loading a class from the parent classpath. This should also cover resource loading (and as a corollary {{ServiceLoader}}). > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (including > {{ClassLoader.getResources()}} and as a corollary {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Attachment: HADOOP-13398-HADOOP-13070.01.patch v.1 patch posted for review. This is still a POC quality. It handles classloading and resource loading. But unit tests are not written yet. I also didn't test {{ServiceLoader}}. > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (and as a corollary > {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Status: Patch Available (was: In Progress) > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > Attachments: HADOOP-13398-HADOOP-13070.01.patch > > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (and as a corollary > {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13398) prevent user classes from loading classes in the parent classpath with ApplicationClassLoader
[ https://issues.apache.org/jira/browse/HADOOP-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sangjin Lee updated HADOOP-13398: - Description: Today, a user class is able to trigger loading a class from Hadoop's dependencies, with or without the use of {{ApplicationClassLoader}}, and it creates an implicit dependence from users' code on Hadoop's dependencies, and as a result dependency conflicts. We should modify {{ApplicationClassLoader}} to prevent a user class from loading a class from the parent classpath. This should also cover resource loading (and as a corollary {{ServiceLoader}}). was: Today, a user class is able to trigger loading a class from Hadoop's dependencies, with or without the use of {{ApplicationClassLoader}}, and it creates an implicit dependence from users' code on Hadoop's dependencies, and as a result dependency conflicts. We should modify {{ApplicationClassLoader}} to prevent a user class from loading a class from the parent classpath. > prevent user classes from loading classes in the parent classpath with > ApplicationClassLoader > - > > Key: HADOOP-13398 > URL: https://issues.apache.org/jira/browse/HADOOP-13398 > Project: Hadoop Common > Issue Type: Sub-task > Components: util >Reporter: Sangjin Lee >Assignee: Sangjin Lee >Priority: Critical > > Today, a user class is able to trigger loading a class from Hadoop's > dependencies, with or without the use of {{ApplicationClassLoader}}, and it > creates an implicit dependence from users' code on Hadoop's dependencies, and > as a result dependency conflicts. > We should modify {{ApplicationClassLoader}} to prevent a user class from > loading a class from the parent classpath. > This should also cover resource loading (and as a corollary > {{ServiceLoader}}). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org