[jira] [Updated] (HADOOP-13559) Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes
[
https://issues.apache.org/jira/browse/HADOOP-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HADOOP-13559:
---
Resolution: Fixed
Fix Version/s: 2.8.0
Status: Resolved (was: Patch Available)
Committed to {{trunk}}, {{branch-2}} and {{branch-2.8}}. Thanks for the patch,
[~fabbri].
> Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs
> classes
> -
>
> Key: HADOOP-13559
> URL: https://issues.apache.org/jira/browse/HADOOP-13559
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Affects Versions: 2.8.0, 2.9.0
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-13559-001.patch
>
>
> My colleague noticed that HADOOP-12994 introduced to places where close() was
> still called manually within a try-with-resources block.
> I'll attach a patch to remove the manual close() calls.
> These extra calls to close() are probably safe, as InputStream is a Closable,
> not AutoClosable (the later does not specify close() as idempotent).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13559) Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes
[ https://issues.apache.org/jira/browse/HADOOP-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HADOOP-13559: --- Summary: Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs classes (was: Remove close() within try-with-resources) > Remove close() within try-with-resources in ChecksumFileSystem/ChecksumFs > classes > - > > Key: HADOOP-13559 > URL: https://issues.apache.org/jira/browse/HADOOP-13559 > Project: Hadoop Common > Issue Type: Bug > Components: fs >Affects Versions: 2.8.0, 2.9.0 >Reporter: Aaron Fabbri >Assignee: Aaron Fabbri >Priority: Minor > Attachments: HADOOP-13559-001.patch > > > My colleague noticed that HADOOP-12994 introduced to places where close() was > still called manually within a try-with-resources block. > I'll attach a patch to remove the manual close() calls. > These extra calls to close() are probably safe, as InputStream is a Closable, > not AutoClosable (the later does not specify close() as idempotent). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
