[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-14114: --- Fix Version/s: 2.9.0 > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug > Components: fs/s3 >Affects Versions: 2.8.0 >Reporter: Sean Mackrory >Assignee: Sean Mackrory >Priority: Minor > Fix For: 2.9.0, 2.8.1, 3.0.0-alpha4 > > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HADOOP-14114: - Fix Version/s: 3.0.0-alpha3 > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug > Components: fs/s3 >Affects Versions: 2.8.0 >Reporter: Sean Mackrory >Assignee: Sean Mackrory >Priority: Minor > Fix For: 2.8.1, 3.0.0-alpha3 > > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-14114: Resolution: Fixed Status: Resolved (was: Patch Available) > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug > Components: fs/s3 >Affects Versions: 2.8.0 >Reporter: Sean Mackrory >Assignee: Sean Mackrory >Priority: Minor > Fix For: 2.8.1 > > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[
https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-14114:
Priority: Minor (was: Major)
Fix Version/s: 2.8.1
Component/s: fs/s3
+1, committed to 2.8.1+. For the curious, I've signed that commit; a {{git log
--show-signature ff87ca84418a710c6}} will show whether or not you trust me
> S3A can no longer handle unencoded + in URIs
> -
>
> Key: HADOOP-14114
> URL: https://issues.apache.org/jira/browse/HADOOP-14114
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
>Affects Versions: 2.8.0
>Reporter: Sean Mackrory
>Assignee: Sean Mackrory
>Priority: Minor
> Fix For: 2.8.1
>
> Attachments: HADOOP-14114.001.patch
>
>
> Amazon secret access keys can include alphanumeric characters, but also / and
> + (I wish there was an official source that was really specific on what they
> can contain, but I'll have to rely on a few blog posts and my own experience).
> Keys containing slashes used to be impossible to embed in the URL (e.g.
> s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL
> encoding. Pluses used to work, but that is now *only* possible via URL
> encoding.
> In the case of pluses, they don't appear to cause any other problems for
> parsing. So IMO the best all-around solution here is for people to URL-encode
> these keys always, but so that keys that used to work just fine can continue
> to work fine, all we need to do is detect that, log a warning, and we can
> re-encode it for the user.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-14114: Affects Version/s: 2.8.0 > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.8.0 >Reporter: Sean Mackrory >Assignee: Sean Mackrory > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Mackrory updated HADOOP-14114: --- Attachment: HADOOP-14114.001.patch Attaching a patch that does what I describe, and adds a test to check that + (both encoded and unencoded) is parsed okay in access keys. Have tested against us-west-1, eu-central-1. > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug >Reporter: Sean Mackrory >Assignee: Sean Mackrory > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14114) S3A can no longer handle unencoded + in URIs
[ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Mackrory updated HADOOP-14114: --- Status: Patch Available (was: Open) > S3A can no longer handle unencoded + in URIs > - > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug >Reporter: Sean Mackrory >Assignee: Sean Mackrory > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and > + (I wish there was an official source that was really specific on what they > can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. > s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL > encoding. Pluses used to work, but that is now *only* possible via URL > encoding. > In the case of pluses, they don't appear to cause any other problems for > parsing. So IMO the best all-around solution here is for people to URL-encode > these keys always, but so that keys that used to work just fine can continue > to work fine, all we need to do is detect that, log a warning, and we can > re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
