[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated HADOOP-14527:
---
Attachment: HADOOP-14527-HADOOP-13345.005.patch
Pushed. I took the liberty of addressing the new checkstyle issue by removing
the line that imported stopwatch. Reran tests.
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch,
> HADOOP-14527-HADOOP-13345.002.patch, HADOOP-14527-HADOOP-13345.003.patch,
> HADOOP-14527-HADOOP-13345.004.patch, HADOOP-14527-HADOOP-13345.005.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated HADOOP-14527:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch,
> HADOOP-14527-HADOOP-13345.002.patch, HADOOP-14527-HADOOP-13345.003.patch,
> HADOOP-14527-HADOOP-13345.004.patch, HADOOP-14527-HADOOP-13345.005.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Attachment: HADOOP-14527-HADOOP-13345.004.patch
Thanks for the review [~mackrorysd]. Attaching v4 patch that removes stopwatch
timing of test cases.
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch,
> HADOOP-14527-HADOOP-13345.002.patch, HADOOP-14527-HADOOP-13345.003.patch,
> HADOOP-14527-HADOOP-13345.004.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Attachment: HADOOP-14527-HADOOP-13345.003.patch
v3 patch fixes (existing) checkstyle issue. Findbugs warning is existing
(HADOOP-14499).
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch,
> HADOOP-14527-HADOOP-13345.002.patch, HADOOP-14527-HADOOP-13345.003.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Attachment: HADOOP-14527-HADOOP-13345.002.patch
v2 patch, rebased on latest branch.
Execution time is back up to about 3 minutes with the new test cases that were
added but still major improvement.
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch,
> HADOOP-14527-HADOOP-13345.002.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Status: Patch Available (was: Open)
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Description:
I'm really glad to see folks adopting the inconsistency injection stuff and
adding test cases to ITestS3GuardListConsistency. That test class has become
very slow, however, due to {{Thread.sleep()}} calls that wait for the
inconsistency injection timers to expire, and nested loops that run numerous
permutations of the test cases.
I will take a stab at speeding up this test class. As is it takes about 8
minutes to run.
was:
I'm really glad to see folks adopting the inconsistency injection stuff and
adding test cases to ITestS3GuardListConsistency. That test class has become
very slow, however, mostly due to {{Thread.sleep()}} calls that wait for the
inconsistency injection timers to expire.
I will take a stab at speeding up this test class. As is it takes about 8
minutes to run.
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire, and nested loops that run numerous
> permutations of the test cases.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14527) ITestS3GuardListConsistency is too slow
[
https://issues.apache.org/jira/browse/HADOOP-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aaron Fabbri updated HADOOP-14527:
--
Attachment: HADOOP-14527-HADOOP-13345.001.patch
v1 patch.. Includes stopwatch instrumentation around test cases, which I'm
happy to remove if people want.
> ITestS3GuardListConsistency is too slow
> ---
>
> Key: HADOOP-14527
> URL: https://issues.apache.org/jira/browse/HADOOP-14527
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: HADOOP-13345
>Reporter: Aaron Fabbri
>Assignee: Aaron Fabbri
>Priority: Minor
> Attachments: HADOOP-14527-HADOOP-13345.001.patch
>
>
> I'm really glad to see folks adopting the inconsistency injection stuff and
> adding test cases to ITestS3GuardListConsistency. That test class has become
> very slow, however, mostly due to {{Thread.sleep()}} calls that wait for the
> inconsistency injection timers to expire.
> I will take a stab at speeding up this test class. As is it takes about 8
> minutes to run.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
