[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HADOOP-14568: - Fix Version/s: 3.0.0-alpha4 > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Fix For: 2.9.0, 3.0.0-alpha4 > > Attachments: HADOOP-14568.001.patch, HADOOP-14568.002.patch, > HADOOP-14568.003.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-14568: Resolution: Fixed Fix Version/s: 2.9.0 Status: Resolved (was: Patch Available) +1 committed to branch-2 I don't really think this is worth backporting to 2.8, but if you do think so, re-open this JIRA and attach at as a patch with the right naming scheme > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Fix For: 2.9.0 > > Attachments: HADOOP-14568.001.patch, HADOOP-14568.002.patch, > HADOOP-14568.003.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HADOOP-14568: --- Attachment: HADOOP-14568.003.patch Thanks [~shahrs87] for the review. Will back-port this to 2.8 after patch is confirmed and getting binding +1 from others. Attach the updated patch to fix checkstyle warning. > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Attachments: HADOOP-14568.001.patch, HADOOP-14568.002.patch, > HADOOP-14568.003.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HADOOP-14568: --- Attachment: HADOOP-14568.002.patch Thanks [~ste...@apache.org] for the review. Attach the updated patch to address your comment. > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Attachments: HADOOP-14568.001.patch, HADOOP-14568.002.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[
https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HADOOP-14568:
---
Attachment: HADOOP-14568.001.patch
Reupload patch to use {{Preconditions#checkArgument}} to check parameters.
> GenericTestUtils#waitFor missing parameter verification
> ---
>
> Key: HADOOP-14568
> URL: https://issues.apache.org/jira/browse/HADOOP-14568
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0-alpha3
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
> Attachments: HADOOP-14568.001.patch
>
>
> GenericTestUtils#waitFor missed the parameters verification. This will lead
> the method ran error or meanless. This point was suggested from this
> [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HADOOP-14568: --- Attachment: (was: HADOOP-14568.001.patch) > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HADOOP-14568: --- Status: Patch Available (was: Open) > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Attachments: HADOOP-14568.001.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14568) GenericTestUtils#waitFor missing parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiqun Lin updated HADOOP-14568: --- Attachment: HADOOP-14568.001.patch Attach the initial patch. Adding the null checking and time validation checking. > GenericTestUtils#waitFor missing parameter verification > --- > > Key: HADOOP-14568 > URL: https://issues.apache.org/jira/browse/HADOOP-14568 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha3 >Reporter: Yiqun Lin >Assignee: Yiqun Lin > Attachments: HADOOP-14568.001.patch > > > GenericTestUtils#waitFor missed the parameters verification. This will lead > the method ran error or meanless. This point was suggested from this > [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292]. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
