[jira] [Updated] (HADOOP-15067) GC time percentage reported in JvmMetrics should be a gauge, not counter
[
https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiao Chen updated HADOOP-15067:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.10.0
3.0.0
Status: Resolved (was: Patch Available)
Committed to trunk, branch-3.0, branch-3.0.0 and branch-2.
Thanks all!
> GC time percentage reported in JvmMetrics should be a gauge, not counter
>
>
> Key: HADOOP-15067
> URL: https://issues.apache.org/jira/browse/HADOOP-15067
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Misha Dmitriev
>Assignee: Misha Dmitriev
> Fix For: 3.0.0, 2.10.0
>
> Attachments: HADOOP-15067.01.patch
>
>
> A new GcTimeMonitor class has been recently added, and the corresponding
> metrics added in JvmMetrics.java, line 190:
> {code}
> if (gcTimeMonitor != null) {
> rb.addCounter(GcTimePercentage,
> gcTimeMonitor.getLatestGcData().getGcTimePercentage());
> }
> {code}
> Since GC time percentage can go up and down, a gauge rather than counter
> should be used to report it. That is, {{addCounter}} should be replaced with
> {{addGauge}} above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15067) GC time percentage reported in JvmMetrics should be a gauge, not counter
[
https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misha Dmitriev updated HADOOP-15067:
Status: Patch Available (was: In Progress)
> GC time percentage reported in JvmMetrics should be a gauge, not counter
>
>
> Key: HADOOP-15067
> URL: https://issues.apache.org/jira/browse/HADOOP-15067
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Misha Dmitriev
>Assignee: Misha Dmitriev
> Attachments: HADOOP-15067.01.patch
>
>
> A new GcTimeMonitor class has been recently added, and the corresponding
> metrics added in JvmMetrics.java, line 190:
> {code}
> if (gcTimeMonitor != null) {
> rb.addCounter(GcTimePercentage,
> gcTimeMonitor.getLatestGcData().getGcTimePercentage());
> }
> {code}
> Since GC time percentage can go up and down, a gauge rather than counter
> should be used to report it. That is, {{addCounter}} should be replaced with
> {{addGauge}} above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15067) GC time percentage reported in JvmMetrics should be a gauge, not counter
[
https://issues.apache.org/jira/browse/HADOOP-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misha Dmitriev updated HADOOP-15067:
Attachment: HADOOP-15067.01.patch
> GC time percentage reported in JvmMetrics should be a gauge, not counter
>
>
> Key: HADOOP-15067
> URL: https://issues.apache.org/jira/browse/HADOOP-15067
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Misha Dmitriev
>Assignee: Misha Dmitriev
> Attachments: HADOOP-15067.01.patch
>
>
> A new GcTimeMonitor class has been recently added, and the corresponding
> metrics added in JvmMetrics.java, line 190:
> {code}
> if (gcTimeMonitor != null) {
> rb.addCounter(GcTimePercentage,
> gcTimeMonitor.getLatestGcData().getGcTimePercentage());
> }
> {code}
> Since GC time percentage can go up and down, a gauge rather than counter
> should be used to report it. That is, {{addCounter}} should be replaced with
> {{addGauge}} above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
