[jira] [Updated] (HADOOP-15768) Do not use Time#now to calculate the rpc process time duration

2024-01-04 Thread Shilun Fan (Jira) 


 [ 
https://issues.apache.org/jira/browse/HADOOP-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shilun Fan updated HADOOP-15768:

Target Version/s: 3.5.0  (was: 3.4.0)

> Do not use Time#now to calculate the rpc process time duration
> --
>
> Key: HADOOP-15768
> URL: https://issues.apache.org/jira/browse/HADOOP-15768
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
>
> For the rpc process time calculation, we are using a not-recommended way: 
> Using {{Time#now}} to calculate for this.
> {code}
> // Invoke the protocol method
> long startTime = Time.now();
> int qTime = (int) (startTime-receivedTime);
> 
>   int processingTime = (int) (Time.now() - startTime);
> ...
> server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
> {code} 
> Actually  we should use {{Time#monotonicNow()}} instead. This JIRA will fix 
> these across RpcEngine impl classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-15768) Do not use Time#now to calculate the rpc process time duration

2018-09-18 Thread Yiqun Lin (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HADOOP-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HADOOP-15768:
---
Description: 
For the rpc process time calculation, we are using a not-recommended way: Using 
{{Time#now}} to calculate for this.
{code}
// Invoke the protocol method
long startTime = Time.now();
int qTime = (int) (startTime-receivedTime);

  int processingTime = (int) (Time.now() - startTime);
...
server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
{code} 

Actually  we should use {{Time#monotonicNow()}} instead. This JIRA will fix 
these across RpcEngine impl classes.

  was:
For the rpc queue time calculation, we are using a not-recommended way: Using 
{{Time#now}} to calculate for this.
{code}
// Invoke the protocol method
long startTime = Time.now();
int qTime = (int) (startTime-receivedTime);

server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
{code} 

Actually  we should use {{Time#monotonicNow()}} instead. This JIRA will fix 
these across RpcEngine impl classes.


> Do not use Time#now to calculate the rpc process time duration
> --
>
> Key: HADOOP-15768
> URL: https://issues.apache.org/jira/browse/HADOOP-15768
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
>
> For the rpc process time calculation, we are using a not-recommended way: 
> Using {{Time#now}} to calculate for this.
> {code}
> // Invoke the protocol method
> long startTime = Time.now();
> int qTime = (int) (startTime-receivedTime);
> 
>   int processingTime = (int) (Time.now() - startTime);
> ...
> server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
> {code} 
> Actually  we should use {{Time#monotonicNow()}} instead. This JIRA will fix 
> these across RpcEngine impl classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Updated] (HADOOP-15768) Do not use Time#now to calculate the rpc process time duration

2018-09-18 Thread Yiqun Lin (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HADOOP-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yiqun Lin updated HADOOP-15768:
---
Summary: Do not use Time#now to calculate the rpc process time duration  
(was: Do not use Time#now to calculate the rpc queue time duration)

> Do not use Time#now to calculate the rpc process time duration
> --
>
> Key: HADOOP-15768
> URL: https://issues.apache.org/jira/browse/HADOOP-15768
> Project: Hadoop Common
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
>
> For the rpc queue time calculation, we are using a not-recommended way: Using 
> {{Time#now}} to calculate for this.
> {code}
> // Invoke the protocol method
> long startTime = Time.now();
> int qTime = (int) (startTime-receivedTime);
> 
> server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
> {code} 
> Actually  we should use {{Time#monotonicNow()}} instead. This JIRA will fix 
> these across RpcEngine impl classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org