[jira] [Updated] (HADOOP-8894) GenericTestUtils.waitFor should dump thread stacks on timeout

2012-10-08 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-8894:


Attachment: hadoop-8894.txt

Oops, good catch. Fixed patch.

 GenericTestUtils.waitFor should dump thread stacks on timeout
 -

 Key: HADOOP-8894
 URL: https://issues.apache.org/jira/browse/HADOOP-8894
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Attachments: hadoop-8894.txt, hadoop-8894.txt


 Many tests use this utility to wait for a condition to become true. In the 
 event that it times out, we should dump all the thread stack traces, in case 
 the timeout was due to a deadlock. This should make it easier to debug 
 scenarios like HDFS-4001.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-8894) GenericTestUtils.waitFor should dump thread stacks on timeout

2012-10-08 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-8894:


   Resolution: Fixed
Fix Version/s: 2.0.3-alpha
   3.0.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2, thanks for the review.

 GenericTestUtils.waitFor should dump thread stacks on timeout
 -

 Key: HADOOP-8894
 URL: https://issues.apache.org/jira/browse/HADOOP-8894
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 3.0.0, 2.0.3-alpha

 Attachments: hadoop-8894.txt, hadoop-8894.txt


 Many tests use this utility to wait for a condition to become true. In the 
 event that it times out, we should dump all the thread stack traces, in case 
 the timeout was due to a deadlock. This should make it easier to debug 
 scenarios like HDFS-4001.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-8894) GenericTestUtils.waitFor should dump thread stacks on timeout

2012-10-05 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-8894:


Attachment: hadoop-8894.txt

Attached patch borrows the code from TimedOutTestListener so that the timeout 
exception contains all the thread stacks as well as potential deadlock info.

No new tests included because this is itself test code.

 GenericTestUtils.waitFor should dump thread stacks on timeout
 -

 Key: HADOOP-8894
 URL: https://issues.apache.org/jira/browse/HADOOP-8894
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Attachments: hadoop-8894.txt


 Many tests use this utility to wait for a condition to become true. In the 
 event that it times out, we should dump all the thread stack traces, in case 
 the timeout was due to a deadlock. This should make it easier to debug 
 scenarios like HDFS-4001.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-8894) GenericTestUtils.waitFor should dump thread stacks on timeout

2012-10-05 Thread Todd Lipcon (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-8894:


Status: Patch Available  (was: Open)

submitting patch to Jenkins. I did a manual test by changing a waitFor() call 
to only wait 1ms, and verified that the exception had the expected info.

 GenericTestUtils.waitFor should dump thread stacks on timeout
 -

 Key: HADOOP-8894
 URL: https://issues.apache.org/jira/browse/HADOOP-8894
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Attachments: hadoop-8894.txt


 Many tests use this utility to wait for a condition to become true. In the 
 event that it times out, we should dump all the thread stack traces, in case 
 the timeout was due to a deadlock. This should make it easier to debug 
 scenarios like HDFS-4001.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira