[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.

2012-11-21 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated HADOOP-9049:
--

   Resolution: Fixed
Fix Version/s: 2.0.3-alpha
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

I just committed this. Thanks for the patch, Karthik, and for the review, Daryn.

 DelegationTokenRenewer needs to be Singleton and FileSystems should 
 register/deregister to/from.
 

 Key: HADOOP-9049
 URL: https://issues.apache.org/jira/browse/HADOOP-9049
 Project: Hadoop Common
  Issue Type: Bug
  Components: security
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
 Fix For: 2.0.3-alpha

 Attachments: hadoop-9049.patch, hadoop-9049.patch


 Currently, DelegationTokenRenewer is not singleton.
 Each filesystem using it spawns its own DelegationTokenRenewer. Also, they 
 don't stop the Renewer leading to other problems.
 A single DelegationTokenRenewer should be sufficient for all FileSystems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.

2012-11-15 Thread Karthik Kambatla (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated HADOOP-9049:
-

Attachment: hadoop-9049.patch

Attaching the latest patch from HDFS-4009.patch

 DelegationTokenRenewer needs to be Singleton and FileSystems should 
 register/deregister to/from.
 

 Key: HADOOP-9049
 URL: https://issues.apache.org/jira/browse/HADOOP-9049
 Project: Hadoop Common
  Issue Type: Bug
  Components: security
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
 Attachments: hadoop-9049.patch


 Currently, DelegationTokenRenewer is not singleton.
 Each filesystem using it spawns its own DelegationTokenRenewer. Also, they 
 don't stop the Renewer leading to other problems.
 A single DelegationTokenRenewer should be sufficient for all FileSystems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.

2012-11-15 Thread Karthik Kambatla (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated HADOOP-9049:
-

Status: Patch Available  (was: Open)

 DelegationTokenRenewer needs to be Singleton and FileSystems should 
 register/deregister to/from.
 

 Key: HADOOP-9049
 URL: https://issues.apache.org/jira/browse/HADOOP-9049
 Project: Hadoop Common
  Issue Type: Bug
  Components: security
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
 Attachments: hadoop-9049.patch


 Currently, DelegationTokenRenewer is not singleton.
 Each filesystem using it spawns its own DelegationTokenRenewer. Also, they 
 don't stop the Renewer leading to other problems.
 A single DelegationTokenRenewer should be sufficient for all FileSystems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HADOOP-9049) DelegationTokenRenewer needs to be Singleton and FileSystems should register/deregister to/from.

2012-11-15 Thread Karthik Kambatla (JIRA)

 [ 
https://issues.apache.org/jira/browse/HADOOP-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated HADOOP-9049:
-

Attachment: hadoop-9049.patch

Thanks Daryn. Definitely looking forward for your full review.

Meanwhile, I am uploading a new patch to address Daryn's comments:
# make getInstance() synchronized and make INSTANCE non-volatile
# call super.close() in close() of WebHdfs and Hftp FS


 DelegationTokenRenewer needs to be Singleton and FileSystems should 
 register/deregister to/from.
 

 Key: HADOOP-9049
 URL: https://issues.apache.org/jira/browse/HADOOP-9049
 Project: Hadoop Common
  Issue Type: Bug
  Components: security
Affects Versions: 2.0.2-alpha
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
 Attachments: hadoop-9049.patch, hadoop-9049.patch


 Currently, DelegationTokenRenewer is not singleton.
 Each filesystem using it spawns its own DelegationTokenRenewer. Also, they 
 don't stop the Renewer leading to other problems.
 A single DelegationTokenRenewer should be sufficient for all FileSystems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira