[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634932=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634932 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 06/Aug/21 02:47 Start Date: 06/Aug/21 02:47 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893961654 Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634932) Time Spent: 5h 20m (was: 5h 10m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634930=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634930 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 06/Aug/21 02:45 Start Date: 06/Aug/21 02:45 Worklog Time Spent: 10m Work Description: ferhui commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893961313 @virajjasani Yes, have pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634930) Time Spent: 5h 10m (was: 5h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634929 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 06/Aug/21 02:44 Start Date: 06/Aug/21 02:44 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893961046 Thanks everyone for your reviews. @ferhui Could you please also help backport this to branch-3.2 as the previous patch is already present there? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634929) Time Spent: 5h (was: 4h 50m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 5h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634910=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634910 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 06/Aug/21 01:27 Start Date: 06/Aug/21 01:27 Worklog Time Spent: 10m Work Description: ferhui commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893935057 Thanks you all for report and review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634910) Time Spent: 4h 50m (was: 4h 40m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634909=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634909 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 06/Aug/21 01:27 Start Date: 06/Aug/21 01:27 Worklog Time Spent: 10m Work Description: ferhui merged pull request #3267: URL: https://github.com/apache/hadoop/pull/3267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634909) Time Spent: 4h 40m (was: 4.5h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634502=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634502 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 12:00 Start Date: 05/Aug/21 12:00 Worklog Time Spent: 10m Work Description: ferhui edited a comment on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893382985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634502) Time Spent: 4.5h (was: 4h 20m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 4.5h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634499=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634499 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 11:59 Start Date: 05/Aug/21 11:59 Worklog Time Spent: 10m Work Description: ferhui commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893382985 #3219 Add logs for two places, should we change them both trace? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634499) Time Spent: 4h 20m (was: 4h 10m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634452 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 11:52 Start Date: 05/Aug/21 11:52 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892746748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634452) Time Spent: 4h 10m (was: 4h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634349
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 05/Aug/21 11:41
Start Date: 05/Aug/21 11:41
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682803662
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Yeah that sounds good, but if we have debug enabled, we will happen to
encounter same case as mentioned on #3219.
Maybe let's do one thing, we can keep debug log but remove logging Exception
stacktrace. Thought?
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Yeah that sounds good, but if we have debug enabled, we will happen to
encounter same case as mentioned on #3219.
Maybe let's do one thing, we can keep debug log but remove logging Exception
stacktrace (`LOG.debug("Interrupted while waiting to retrieve RPC
response.")`). Thought?
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Done. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 634349)
Time Spent: 3h 50m (was: 3h 40m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634388
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 05/Aug/21 11:45
Start Date: 05/Aug/21 11:45
Worklog Time Spent: 10m
Work Description: sodonnel commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682869307
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
That could work, or may even set it to trace level logging. If this code
path is expected to happen often then perhaps we only need it logged at trace.
I am fine with either trace or debug plus removing the stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 634388)
Time Spent: 4h (was: 3h 50m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634264
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 05/Aug/21 11:32
Start Date: 05/Aug/21 11:32
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682731912
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Can change to debug, rather than removing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 634264)
Time Spent: 3h 40m (was: 3.5h)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634149 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 11:18 Start Date: 05/Aug/21 11:18 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-892886845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634149) Time Spent: 3h 20m (was: 3h 10m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634183 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 11:22 Start Date: 05/Aug/21 11:22 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-892754843 FYI @sodonnel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634183) Time Spent: 3.5h (was: 3h 20m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=634144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634144 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 05/Aug/21 11:18 Start Date: 05/Aug/21 11:18 Worklog Time Spent: 10m Work Description: sodonnel commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892726068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 634144) Time Spent: 3h 10m (was: 3h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633864=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633864
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 22:20
Start Date: 04/Aug/21 22:20
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#issuecomment-893012913
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 5s | | trunk passed |
| +1 :green_heart: | compile | 23m 0s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 19m 17s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 0s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 33s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 0s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 23s | | trunk passed |
| +1 :green_heart: | shadedclient | 18m 10s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 57s | | the patch passed |
| +1 :green_heart: | compile | 21m 53s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 21m 53s | | the patch passed |
| +1 :green_heart: | compile | 19m 12s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 19m 12s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 59s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 59s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 34s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 33s | | the patch passed |
| +1 :green_heart: | shadedclient | 18m 25s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 16m 55s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 47s | | The patch does not
generate ASF License warnings. |
| | | 189m 35s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3267 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 662ebf5ea307 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18
19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / a6461a430048708b6fa832c70485dca2b9677b40 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/2/testReport/ |
| Max. process+thread count | 2546 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/2/console |
|
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633765=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633765
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 19:09
Start Date: 04/Aug/21 19:09
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682886397
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Done. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 633765)
Time Spent: 2h 50m (was: 2h 40m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633749=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633749
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 18:43
Start Date: 04/Aug/21 18:43
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#issuecomment-892886845
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 27s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 35m 55s | | trunk passed |
| +1 :green_heart: | compile | 24m 26s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 20m 9s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 32s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 2s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 33s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 28s | | trunk passed |
| +1 :green_heart: | shadedclient | 18m 22s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 56s | | the patch passed |
| +1 :green_heart: | compile | 21m 59s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 21m 59s | | the patch passed |
| +1 :green_heart: | compile | 19m 26s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 19m 26s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 58s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 59s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 30s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 31s | | the patch passed |
| +1 :green_heart: | shadedclient | 18m 25s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 16m 53s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 193m 41s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3267 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ab71e5b09786 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18
19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f6197bbf848e0174b4a1b2ec90a7fb220710382a |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/1/testReport/ |
| Max. process+thread count | 1238 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3267/1/console |
|
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633748=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633748
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 18:42
Start Date: 04/Aug/21 18:42
Worklog Time Spent: 10m
Work Description: sodonnel commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682869307
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
That could work, or may even set it to trace level logging. If this code
path is expected to happen often then perhaps we only need it logged at trace.
I am fine with either trace or debug plus removing the stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 633748)
Time Spent: 2.5h (was: 2h 20m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633701=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633701
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 17:09
Start Date: 04/Aug/21 17:09
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682803662
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Yeah that sounds good, but if we have debug enabled, we will happen to
encounter same case as mentioned on #3219.
Maybe let's do one thing, we can keep debug log but remove logging Exception
stacktrace (`LOG.debug("Interrupted while waiting to retrieve RPC
response.")`). Thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 633701)
Time Spent: 2h 20m (was: 2h 10m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633698=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633698
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 17:07
Start Date: 04/Aug/21 17:07
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682803662
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Yeah that sounds good, but if we have debug enabled, we will happen to
encounter same case as mentioned on #3219.
Maybe let's do one thing, we can keep debug log but remove logging Exception
stacktrace. Thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 633698)
Time Spent: 2h 10m (was: 2h)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633658=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633658
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 04/Aug/21 15:36
Start Date: 04/Aug/21 15:36
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3267:
URL: https://github.com/apache/hadoop/pull/3267#discussion_r682731912
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
##
@@ -1052,7 +1052,6 @@ private synchronized boolean waitForWork() {
try {
wait(timeout);
} catch (InterruptedException e) {
-LOG.info("Interrupted while waiting to retrieve RPC response.", e);
Review comment:
Can change to debug, rather than removing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 633658)
Time Spent: 2h (was: 1h 50m)
> ipc.Client not setting interrupt flag after catching InterruptedException
> -
>
> Key: HADOOP-17808
> URL: https://issues.apache.org/jira/browse/HADOOP-17808
> Project: Hadoop Common
> Issue Type: Task
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.2.3, 3.3.2
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> ipc.Client is swallowing InterruptedException at a couple of places:
> # While waiting on all connections to be closed
> # While waiting to retrieve some RPC response
> We should at least set the interrupt signal and also log the
> InterruptedException caught.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633652=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633652 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 04/Aug/21 15:28 Start Date: 04/Aug/21 15:28 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3267: URL: https://github.com/apache/hadoop/pull/3267#issuecomment-892754843 FYI @sodonnel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 633652) Time Spent: 1h 50m (was: 1h 40m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633647 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 04/Aug/21 15:22 Start Date: 04/Aug/21 15:22 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892749746 Sure thing, let me create an addendum PR right away. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 633647) Time Spent: 1h 40m (was: 1.5h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633646 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 04/Aug/21 15:21 Start Date: 04/Aug/21 15:21 Worklog Time Spent: 10m Work Description: sodonnel commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892748783 Thanks for the explanation. I guess removing the log message is probably the correct thing to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 633646) Time Spent: 1.5h (was: 1h 20m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 1.5h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633643 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 04/Aug/21 15:18 Start Date: 04/Aug/21 15:18 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892746748 Thanks for reporting this @sodonnel. I believe the change of setting interrupt flag whenever Client receives InterruptedException should be done (we are doing it at all other places in ipc.Client) but perhaps logging at INFO level is too much because interruption is expected to happen while awaiting RPC response. Let me create an addendum to remove logging from the cached Exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 633643) Time Spent: 1h 20m (was: 1h 10m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=633615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633615 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 04/Aug/21 14:53 Start Date: 04/Aug/21 14:53 Worklog Time Spent: 10m Work Description: sodonnel commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-892726068 I just compiled trunk and formatted a namenode locally. Now anytime I run a client command I am getting this output: ``` $ hadoop fs -ls /test 2021-08-04 15:51:28,532 INFO ipc.Client: Interrupted while waiting to retrieve RPC response. java.lang.InterruptedException at java.lang.Object.wait(Native Method) at org.apache.hadoop.ipc.Client$Connection.waitForWork(Client.java:1053) at org.apache.hadoop.ipc.Client$Connection.run(Client.java:1100) ``` Which points to this change, as it is catching, logging and re-throwing the exception. I am not sure yet if I am doing something wrong, but it feels like this change is not doing the correct thing. Is this expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 633615) Time Spent: 1h 10m (was: 1h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0, 3.2.3, 3.3.2 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=626997=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626997 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 23/Jul/21 04:39 Start Date: 23/Jul/21 04:39 Worklog Time Spent: 10m Work Description: ferhui merged pull request #3219: URL: https://github.com/apache/hadoop/pull/3219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626997) Time Spent: 1h (was: 50m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=626996=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626996 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 23/Jul/21 04:39 Start Date: 23/Jul/21 04:39 Worklog Time Spent: 10m Work Description: ferhui commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-885394050 @virajjasani Thanks for contribution, @jojochuang Thanks for review! Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626996) Time Spent: 50m (was: 40m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=626994=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626994 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 23/Jul/21 04:31 Start Date: 23/Jul/21 04:31 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-885392192 Thanks for the review @jojochuang. Could you please help merge this change? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 626994) Time Spent: 40m (was: 0.5h) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=625725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625725 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 20/Jul/21 18:26 Start Date: 20/Jul/21 18:26 Worklog Time Spent: 10m Work Description: virajjasani commented on pull request #3219: URL: https://github.com/apache/hadoop/pull/3219#issuecomment-883603585 @jojochuang @aajisaka Could you please take a look? Found this as part of a test in TestRPC, thought it's worth fixing. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 625725) Time Spent: 0.5h (was: 20m) > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[
https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=625638=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625638
]
ASF GitHub Bot logged work on HADOOP-17808:
---
Author: ASF GitHub Bot
Created on: 20/Jul/21 15:04
Start Date: 20/Jul/21 15:04
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3219:
URL: https://github.com/apache/hadoop/pull/3219#issuecomment-883466801
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 43s | | trunk passed |
| +1 :green_heart: | compile | 21m 12s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 18m 24s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 10s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 41s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 25s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 37s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 55s | | the patch passed |
| +1 :green_heart: | compile | 20m 26s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 20m 26s | | the patch passed |
| +1 :green_heart: | compile | 18m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 18m 28s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 9s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 34s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 42s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 33s | | the patch passed |
| +1 :green_heart: | shadedclient | 15m 40s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 4s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not
generate ASF License warnings. |
| | | 176m 41s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3219/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3219 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 69781cbc9b9b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 1cd3ad1fcc626adf064d6cd35fe979827c15bced |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3219/1/testReport/ |
| Max. process+thread count | 1328 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3219/1/console |
|
[jira] [Work logged] (HADOOP-17808) ipc.Client not setting interrupt flag after catching InterruptedException
[ https://issues.apache.org/jira/browse/HADOOP-17808?focusedWorklogId=625570=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625570 ] ASF GitHub Bot logged work on HADOOP-17808: --- Author: ASF GitHub Bot Created on: 20/Jul/21 12:28 Start Date: 20/Jul/21 12:28 Worklog Time Spent: 10m Work Description: virajjasani opened a new pull request #3219: URL: https://github.com/apache/hadoop/pull/3219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 625570) Remaining Estimate: 0h Time Spent: 10m > ipc.Client not setting interrupt flag after catching InterruptedException > - > > Key: HADOOP-17808 > URL: https://issues.apache.org/jira/browse/HADOOP-17808 > Project: Hadoop Common > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > ipc.Client is swallowing InterruptedException at a couple of places: > # While waiting on all connections to be closed > # While waiting to retrieve some RPC response > We should at least set the interrupt signal and also log the > InterruptedException caught. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
