cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections CollectionUtils.java
scolebourne2003/09/07 01:45:16
Modified:collections/src/java/org/apache/commons/collections
CollectionUtils.java
Log:
Javadoc improvements
bug 22964, from Janek Bogucki
Revision ChangesPath
1.37 +7 -8
jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java
Index: CollectionUtils.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -r1.36 -r1.37
--- CollectionUtils.java 5 Sep 2003 02:16:33 - 1.36
+++ CollectionUtils.java 7 Sep 2003 08:45:16 - 1.37
@@ -87,9 +87,10 @@
* @author Paul Jack
* @author Stephen Colebourne
* @author Steve Downey
- * @author a href=[EMAIL PROTECTED]Herve Quiroz/a
+ * @author Herve Quiroz
* @author Peter KoBek
* @author Matthew Hawthorne
+ * @author Janek Bogucki
*/
public class CollectionUtils {
@@ -502,8 +503,6 @@
* @param inputCollection the collection to get the input from, may be null
* @param predicate the predicate to use, may be null
* @param outputCollection the collection to output into, may not be null
- * @return the outputCollection with the the elements matching the predicate
added
- * @throws NullPointerException if the input collection is null
*/
public static void select(Collection inputCollection, Predicate predicate,
Collection outputCollection) {
if (inputCollection != null predicate != null) {
@@ -520,7 +519,7 @@
* Selects all elements from inputCollection which don't match the given
predicate
* into an output collection.
* p
- * A codenull/code predicate matches no elements.
+ * If the input predicate is codenull/code, the result is an empty list.
*
* @param inputCollection the collection to get the input from, may not be null
* @param predicate the predicate to use, may be null
@@ -536,12 +535,12 @@
/**
* Selects all elements from inputCollection which don't match the given
predicate
* and adds them to outputCollection.
+ * p
+ * If the input predicate is codenull/code, no elements are added to
codeoutputCollection/code.
*
* @param inputCollection the collection to get the input from, may be null
* @param predicate the predicate to use, may be null
* @param outputCollection the collection to output into, may not be null
- * @return the outputCollection with the the elements bnot/b matching the
predicate added
- * @throws NullPointerException if the input collection is null
*/
public static void selectRejected(Collection inputCollection, Predicate
predicate, Collection outputCollection) {
if (inputCollection != null predicate != null) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22964] - [collections][PATCH] JavaDoc simplification for CollectionUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22964. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22964 [collections][PATCH] JavaDoc simplification for CollectionUtils [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 08:48 --- Patch applied, thanks - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections BoundedCollection.java UnboundedFifoBuffer.java BoundedFifoBuffer.java
scolebourne2003/09/07 01:48:46
Modified:collections/src/java/org/apache/commons/collections
BoundedCollection.java UnboundedFifoBuffer.java
BoundedFifoBuffer.java
Log:
Javadoc improvements
bug 22962, from Janek Bogucki
Revision ChangesPath
1.4 +3 -3
jakarta-commons/collections/src/java/org/apache/commons/collections/BoundedCollection.java
Index: BoundedCollection.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/BoundedCollection.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- BoundedCollection.java31 Aug 2003 17:26:44 - 1.3
+++ BoundedCollection.java7 Sep 2003 08:48:46 - 1.4
@@ -69,7 +69,7 @@
* @since Commons Collections 3.0
* @version $Revision$ $Date$
*
- * @author a href=[EMAIL PROTECTED]Herve Quiroz/a
+ * @author Herve Quiroz
* @author Stephen Colebourne
*/
public interface BoundedCollection extends Collection {
1.8 +4 -4
jakarta-commons/collections/src/java/org/apache/commons/collections/UnboundedFifoBuffer.java
Index: UnboundedFifoBuffer.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/UnboundedFifoBuffer.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- UnboundedFifoBuffer.java 31 Aug 2003 17:26:44 - 1.7
+++ UnboundedFifoBuffer.java 7 Sep 2003 08:48:46 - 1.8
@@ -86,8 +86,8 @@
* @version $Revision$ $Date$
*
* @author Avalon
- * @author a href=[EMAIL PROTECTED]Federico Barbieri/a
- * @author a href=[EMAIL PROTECTED]Berin Loritsch/a
+ * @author Federico Barbieri
+ * @author Berin Loritsch
* @author Paul Jack
* @author Stephen Colebourne
*/
1.10 +4 -4
jakarta-commons/collections/src/java/org/apache/commons/collections/BoundedFifoBuffer.java
Index: BoundedFifoBuffer.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/BoundedFifoBuffer.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- BoundedFifoBuffer.java31 Aug 2003 17:26:44 - 1.9
+++ BoundedFifoBuffer.java7 Sep 2003 08:48:46 - 1.10
@@ -87,10 +87,10 @@
* @version $Revision$ $Date$
*
* @author Avalon
- * @author a href=mailto:[EMAIL PROTECTED]Berin Loritsch/a
+ * @author Berin Loritsch
* @author Paul Jack
* @author Stephen Colebourne
- * @author a href=[EMAIL PROTECTED]Herve Quiroz/a
+ * @author Herve Quiroz
*/
public class BoundedFifoBuffer extends AbstractCollection implements Buffer,
BoundedCollection {
private final Object[] m_elements;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [collections] CollectionUtils.getCardinalityMap JavaDoc
Your logic makes sense to me ;-)
Stephen
- Original Message -
From: Janek Bogucki [EMAIL PROTECTED]
To: Jakarta Commons Developers List [EMAIL PROTECTED]
Sent: Sunday, September 07, 2003 2:35 AM
Subject: [collections] CollectionUtils.getCardinalityMap JavaDoc
In CollectionUtils.getCardinalityMap the documentation notes the meaning
of an entry that maps to null but I don't see how any such entry can exist
in the returned map as all the keys in the map come from the collection
parameter and will map to =1. Have I missed something?
From CollectionUtils v 1.36
/**
* Returns a [EMAIL PROTECTED] Map} mapping each unique element in
* the given [EMAIL PROTECTED] Collection} to an [EMAIL PROTECTED] Integer}
* representing the number of occurences of that element
* in the [EMAIL PROTECTED] Collection}.
* An entry that maps to ttnull/tt indicates that the
* element does not appear in the given [EMAIL PROTECTED] Collection}.
*/
public static Map getCardinalityMap(final Collection col) {
HashMap count = new HashMap();
Iterator it = col.iterator();
while(it.hasNext()) {
Object obj = it.next();
Integer c = (Integer)(count.get(obj));
if(null == c) {
count.put(obj,new Integer(1));
} else {
count.put(obj,new Integer(c.intValue() + 1));
}
}
return count;
}
-Janek
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections/observed ObservedTestHelper.java
scolebourne2003/09/07 03:33:33
Modified:collections/src/java/org/apache/commons/collections/observed
ObservedCollection.java ModificationEvent.java
ModificationHandler.java ObservedList.java
collections/src/java/org/apache/commons/collections/observed/standard
StandardPostModificationEvent.java
StandardModificationHandler.java
StandardPreModificationEvent.java
StandardModificationEvent.java
collections/src/test/org/apache/commons/collections/observed
ObservedTestHelper.java
Log:
Make the base collection available to listeners
Revision ChangesPath
1.4 +3 -3
jakarta-commons/collections/src/java/org/apache/commons/collections/observed/ObservedCollection.java
Index: ObservedCollection.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/observed/ObservedCollection.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ObservedCollection.java 7 Sep 2003 00:51:31 - 1.3
+++ ObservedCollection.java 7 Sep 2003 10:33:32 - 1.4
@@ -193,7 +193,7 @@
final Object listener) {
super(coll);
this.handler = createHandler(coll, listener);
-this.handler.init(this);
+this.handler.init(this, coll);
}
/**
1.2 +29 -13
jakarta-commons/collections/src/java/org/apache/commons/collections/observed/ModificationEvent.java
Index: ModificationEvent.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/observed/ModificationEvent.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ModificationEvent.java3 Sep 2003 23:54:26 - 1.1
+++ ModificationEvent.java7 Sep 2003 10:33:32 - 1.2
@@ -73,7 +73,7 @@
public class ModificationEvent extends EventObject {
/** The source collection */
-protected final Collection collection;
+protected final ObservedCollection collection;
/** The handler */
protected final ModificationHandler handler;
/** The event code */
@@ -84,17 +84,17 @@
/**
* Constructor.
*
- * @param collection the event source
+ * @param obsCollection the event source
* @param handler the handler
* @param type the event type
*/
public ModificationEvent(
-final Collection collection,
+final ObservedCollection obsCollection,
final ModificationHandler handler,
final int type) {
-super(collection);
-this.collection = collection;
+super(obsCollection);
+this.collection = obsCollection;
this.handler = handler;
this.type = type;
}
@@ -104,16 +104,32 @@
/**
* Gets the collection the event is reporting on.
* p
- * This method returns the codeObservedCollection/code instance.
- * If this collection is wrapped, by a synchronized wrapper for example,
- * changing this collection will bypass the wrapper. For the synchronized
- * example, this will be OK so long as the event is processed in the same
- * thread and program stack as the modification was made in.
+ * Using this collection will bypass any decorators that have been added
+ * to the codeObservedCollection/code. For example, if a synchronized
+ * decorator was added it will not be called by changes to this collection.
+ * p
+ * For the synchronization case, you are normally OK however. If you
+ * process the event in the same thread as the original change then your
+ * code will be protected by the original synchronized decorator and this
+ * collection may be used freely.
*
* @return the collection
*/
-public Collection getSourceCollection() {
+public ObservedCollection getObservedCollection() {
return collection;
+}
+
+/**
+ * Gets the base collection underlying the observed collection.
+ * p
+ * Using this collection will bypass the event sending mechanism.
+ * It will also bypass any other decorators, such as synchronization.
+ * Use with care.
+ *
+ * @return the collection
+ */
+public Collection getBaseCollection() {
+return handler.getBaseCollection();
}
/**
1.4 +67 -22
jakarta-commons/collections/src/java/org/apache/commons/collections/observed/ModificationHandler.java
Index: ModificationHandler.java
cvs commit: jakarta-commons/docs/releases index.html mirror.html prepare.html release.html
rdonkin 2003/09/07 05:55:43 Modified:docs beanutils.html charter.html collections.html commons.html components.html contributors.html dbcp.html digester.html directory.html discovery.html el.html index.html jexl.html lang.html license.html logging.html modeler.html patches.html pool.html releases.html sandbox.html versioning.html volunteering.html docs/releases index.html mirror.html prepare.html release.html Log: Updated release document to ensure that signatures are armoured and given useful link to signing key page (thanks Noel!). Also picked up some other changes to the nav bar. Revision ChangesPath 1.87 +0 -6 jakarta-commons/docs/beanutils.html Index: beanutils.html === RCS file: /home/cvs/jakarta-commons/docs/beanutils.html,v retrieving revision 1.86 retrieving revision 1.87 diff -u -r1.86 -r1.87 --- beanutils.html5 Sep 2003 00:25:28 - 1.86 +++ beanutils.html7 Sep 2003 12:55:42 - 1.87 @@ -42,12 +42,6 @@ !-- LEFT SIDE NAVIGATION -- td width=20% valign=top nowrap=true -!-- Added for ApacheCon US 2003 -- - -div - a href=http://www.apachecon.com;img src=http://jakarta.apache.org/images/logos/ac2003-M.gif; border=0/img/a -/div - pstrongAbout Us/strong/p ul lia href=http://jakarta.apache.org/commons/index.html;Home/a 1.83 +0 -6 jakarta-commons/docs/charter.html Index: charter.html === RCS file: /home/cvs/jakarta-commons/docs/charter.html,v retrieving revision 1.82 retrieving revision 1.83 diff -u -r1.82 -r1.83 --- charter.html 5 Sep 2003 00:25:28 - 1.82 +++ charter.html 7 Sep 2003 12:55:42 - 1.83 @@ -42,12 +42,6 @@ !-- LEFT SIDE NAVIGATION -- td width=20% valign=top nowrap=true -!-- Added for ApacheCon US 2003 -- - -div - a href=http://www.apachecon.com;img src=http://jakarta.apache.org/images/logos/ac2003-M.gif; border=0/img/a -/div - pstrongAbout Us/strong/p ul lia href=http://jakarta.apache.org/commons/index.html;Home/a 1.73 +0 -6 jakarta-commons/docs/collections.html Index: collections.html === RCS file: /home/cvs/jakarta-commons/docs/collections.html,v retrieving revision 1.72 retrieving revision 1.73 diff -u -r1.72 -r1.73 --- collections.html 5 Sep 2003 00:25:28 - 1.72 +++ collections.html 7 Sep 2003 12:55:42 - 1.73 @@ -42,12 +42,6 @@ !-- LEFT SIDE NAVIGATION -- td width=20% valign=top nowrap=true -!-- Added for ApacheCon US 2003 -- - -div - a href=http://www.apachecon.com;img src=http://jakarta.apache.org/images/logos/ac2003-M.gif; border=0/img/a -/div - pstrongAbout Us/strong/p ul lia href=http://jakarta.apache.org/commons/index.html;Home/a 1.87 +0 -6 jakarta-commons/docs/commons.html Index: commons.html === RCS file: /home/cvs/jakarta-commons/docs/commons.html,v retrieving revision 1.86 retrieving revision 1.87 diff -u -r1.86 -r1.87 --- commons.html 5 Sep 2003 00:25:28 - 1.86 +++ commons.html 7 Sep 2003 12:55:42 - 1.87 @@ -42,12 +42,6 @@ !-- LEFT SIDE NAVIGATION -- td width=20% valign=top nowrap=true -!-- Added for ApacheCon US 2003 -- - -div - a href=http://www.apachecon.com;img src=http://jakarta.apache.org/images/logos/ac2003-M.gif; border=0/img/a -/div - pstrongAbout Us/strong/p ul lia href=http://jakarta.apache.org/commons/index.html;Home/a 1.121 +0 -6 jakarta-commons/docs/components.html Index: components.html === RCS file: /home/cvs/jakarta-commons/docs/components.html,v retrieving revision 1.120 retrieving revision 1.121 diff -u -r1.120 -r1.121 --- components.html 5 Sep 2003 00:25:28 - 1.120 +++ components.html 7 Sep 2003 12:55:42 - 1.121 @@ -42,12 +42,6 @@ !-- LEFT SIDE NAVIGATION -- td width=20% valign=top nowrap=true
DO NOT REPLY [Bug 22908] - [lang] [PATCH] fixes 75 typos
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22908. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22908 [lang] [PATCH] fixes 75 typos [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 14:36 --- Patch applied, thanks - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2003/09/07]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 599|Opn|Enh|2001-02-13|Add ability to set parameter with CallParam that i| | 3893|Opn|Enh|2001-10-01|Multiple element body parts problem | | 6508|Ass|Enh|2002-02-17|HttpClient now supports proxyHost and proxyPort - | | 6826|Ass|Enh|2002-03-04|Need to have xml files validated against DTDs as p| | 6829|Ass|Enh|2002-03-04|Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|DTD and DOM Validators| | 7135|Opn|Enh|2002-03-14|Misleading error message when beaninfo class confl| | 7226|Opn|Enh|2002-03-19|Nested Bean Collection| | 7367|New|Nor|2002-03-22|[unspecified] ServiceManager not actually serializ| | 7465|New|Nor|2002-03-25|Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| | 8140|Ver|Nor|2002-04-16|Incorrect credentials loop infinitely | |10319|New|Enh|2002-06-28|Instantiate property if null in form bean | |10543|Ass|Enh|2002-07-08|generate ant task automatically from CLI | |10790|New|Enh|2002-07-15|Non-standards configuration and tracking | |10792|New|Enh|2002-07-15|Plug-in authentication modules| |10793|New|Enh|2002-07-15|User definable default headers support| |10794|New|Enh|2002-07-15|User interaction for authentication | |10810|New|Enh|2002-07-15|Response handlers | |10813|New|Enh|2002-07-15|RFC 2965 Support (Port sensitive cookies) | |10815|New|Enh|2002-07-15|Instrumentation for Timings | |10818|Opn|Enh|2002-07-15|Add method enter() and exit() methods to public Lo| |10930|New|Enh|2002-07-18|J2EE FORM authentication (also affects pluggable a| |10957|New|Nor|2002-07-18|Change Header/HeaderElement to handle a list as th| |12807|New|Nor|2002-09-19|[PATCH] x 2 Update build.xml to use commons-loggin| |12858|Ass|Nor|2002-09-20|Style variation in CVS $Header$ tag in embedded LI| |12997|Opn|Nor|2002-09-25|Call the method as soon as the last parameter is e| |13031|New|Enh|2002-09-26|Use regular expression (regex) pattern matching fo| |13370|New|Nor|2002-10-07|[sql] DDL for INTEGER data type incorrect | |13381|New|Enh|2002-10-07|[sql] commons-sql database.xml - OJB repository.x| |13390|New|Nor|2002-10-07|ResponseHeaderHandler and ResponseHeaderValidator | |13426|New|Enh|2002-10-08|[PATCH] xml-reference.xml responseHeader addition | |13743|Opn|Enh|2002-10-17|Need getPropertyType(Class theClass, String propNa| |14036|New|Enh|2002-10-29|MultipartPostMethod does not check for error messa| |14262|Opn|Maj|2002-11-05|SAXBeanWriter produces invalid XML| |14394|Ver|Nor|2002-11-08|Excessive exceptions log under security manager | |14409|New|Nor|2002-11-09|Add support for stuff like [target [target2 [targe| |14667|Ver|Maj|2002-11-19|PropertyUtils.copyProperties does not copy to Dyna| |15046|Opn|Nor|2002-12-04|MissingArgumentException: no argument for option| |15082|Ass|Enh|2002-12-04|[lang] elapsed time formatting utility method | |15297|New|Enh|2002-12-12|[HttpClient] Authenticator() - ability to perform | |15435|New|Enh|2002-12-17|New Preferences Architecture | |15451|Opn|Enh|2002-12-17|Multiple mapped properties not possible / Direct m| |15519|Ver|Maj|2002-12-19|PropertyUtils.getPropertyType() for java.util.Coll| |15534|New|Nor|2002-12-19|Inadequate HTTP proxy server support in HttpClient| |15744|New|Nor|2002-12-31|[unspecified] Scaffold ResultSet used after statem| |15895|Unc|Nor|2003-01-08|In BeanMap all properties are writable (some with | |16038|Opn|Enh|2003-01-13|[beanutils] LocaleBeanUtils.copyProperties() does | |16124|New|Nor|2003-01-15|isHttp11 should have HttpClient scope | |16132|New|Maj|2003-01-15|[Jelly] core:file convert html to lt;htmlgt; | |16394|New|Enh|2003-01-24|Enhance the IndexedListProperty to handle nested l|
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/decorators PredicatedMap.java PredicatedSortedMap.java TransformedSortedMap.java UnmodifiableBoundedCollection.java
psteitz 2003/09/07 08:09:34 Modified:collections/src/java/org/apache/commons/collections CollectionUtils.java collections/src/java/org/apache/commons/collections/decorators PredicatedMap.java PredicatedSortedMap.java TransformedSortedMap.java UnmodifiableBoundedCollection.java Log: Reverted to [collections] javadoc style Revision ChangesPath 1.38 +3 -3 jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java Index: CollectionUtils.java === RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/CollectionUtils.java,v retrieving revision 1.37 retrieving revision 1.38 diff -u -r1.37 -r1.38 --- CollectionUtils.java 7 Sep 2003 08:45:16 - 1.37 +++ CollectionUtils.java 7 Sep 2003 15:09:34 - 1.38 @@ -289,7 +289,7 @@ *licodea.size()/code and codeb.size()/code represent the *total cardinality of ia/i and ib/i, resp. /li *licodea.size() Integer.MAXVALUE/code/li - * /ul/p + * /ul * * @see #isSubCollection * @see Collection#containsAll 1.6 +4 -4 jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/PredicatedMap.java Index: PredicatedMap.java === RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/PredicatedMap.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- PredicatedMap.java5 Sep 2003 03:35:07 - 1.5 +++ PredicatedMap.java7 Sep 2003 15:09:34 - 1.6 @@ -69,7 +69,7 @@ * to validate that additions match a specified predicate. * p * If an object cannot be added to the map, an IllegalArgumentException - * is thrown./p + * is thrown. * * @since Commons Collections 3.0 * @version $Revision$ $Date$ @@ -88,7 +88,7 @@ * Factory method to create a predicated (validating) map. * p * If there are any elements already in the list being decorated, they - * are validated./p + * are validated. * * @param map the map to decorate, must not be null * @param keyPredicate the predicate to validate the keys, null means no check 1.5 +4 -4 jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/PredicatedSortedMap.java Index: PredicatedSortedMap.java === RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/PredicatedSortedMap.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- PredicatedSortedMap.java 5 Sep 2003 03:35:07 - 1.4 +++ PredicatedSortedMap.java 7 Sep 2003 15:09:34 - 1.5 @@ -67,7 +67,7 @@ * to validate that additions match a specified predicate. * p * If an object cannot be added to the map, an IllegalArgumentException - * is thrown./p + * is thrown. * * @since Commons Collections 3.0 * @version $Revision$ $Date$ @@ -81,7 +81,7 @@ * Factory method to create a predicated (validating) sorted map. * p * If there are any elements already in the list being decorated, they - * are validated./p + * are validated. * * @param map the map to decorate, must not be null * @param keyPredicate the predicate to validate the keys, null means no check 1.4 +3 -3 jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/TransformedSortedMap.java Index: TransformedSortedMap.java === RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/TransformedSortedMap.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- TransformedSortedMap.java 5 Sep 2003 03:35:07 - 1.3 +++ TransformedSortedMap.java 7 Sep 2003 15:09:34 - 1.4 @@ -82,7 +82,7 @@ * Factory method to create a transforming sorted map. * p * If there are any elements already in the map being decorated, they - * are NOT transformed./p + * are NOT transformed. * * @param map the map to decorate, must not be null * @param keyTransformer the predicate to validate the keys, null means no transformation 1.4 +3 -3 jakarta-commons/collections/src/java/org/apache/commons/collections/decorators/UnmodifiableBoundedCollection.java Index:
cvs commit: jakarta-commons/collections/src/test/org/apache/commons/collections TestAllPackages.java
scolebourne2003/09/07 09:49:41 Modified:collections/src/test/org/apache/commons/collections TestAllPackages.java Log: Add observed package tests Revision ChangesPath 1.3 +3 -2 jakarta-commons/collections/src/test/org/apache/commons/collections/TestAllPackages.java Index: TestAllPackages.java === RCS file: /home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestAllPackages.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- TestAllPackages.java 31 Aug 2003 17:28:43 - 1.2 +++ TestAllPackages.java 7 Sep 2003 16:49:41 - 1.3 @@ -79,6 +79,7 @@ suite.addTest(org.apache.commons.collections.comparators.TestAll.suite()); suite.addTest(org.apache.commons.collections.decorators.TestAll.suite()); suite.addTest(org.apache.commons.collections.iterators.TestAll.suite()); +suite.addTest(org.apache.commons.collections.observed.TestAll.suite()); suite.addTest(org.apache.commons.collections.primitives.TestAll.suite()); return suite; } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/observed ObservedBuffer.java ModificationEventType.java ModificationHandler.java
scolebourne2003/09/07 09:50:59
Modified:collections/src/test/org/apache/commons/collections/observed
TestAll.java ObservedTestHelper.java
collections/src/java/org/apache/commons/collections/observed
ModificationEventType.java ModificationHandler.java
Added: collections/src/test/org/apache/commons/collections/observed
TestObservedBuffer.java
collections/src/java/org/apache/commons/collections/observed
ObservedBuffer.java
Log:
Add ObservedBuffer
Revision ChangesPath
1.2 +3 -2
jakarta-commons/collections/src/test/org/apache/commons/collections/observed/TestAll.java
Index: TestAll.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/observed/TestAll.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TestAll.java 3 Sep 2003 23:54:25 - 1.1
+++ TestAll.java 7 Sep 2003 16:50:59 - 1.2
@@ -84,6 +84,7 @@
TestSuite suite = new TestSuite();
suite.addTest(TestObservedBag.suite());
+suite.addTest(TestObservedBuffer.suite());
suite.addTest(TestObservedCollection.suite());
suite.addTest(TestObservedList.suite());
suite.addTest(TestObservedSet.suite());
1.6 +56 -2
jakarta-commons/collections/src/test/org/apache/commons/collections/observed/ObservedTestHelper.java
Index: ObservedTestHelper.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/observed/ObservedTestHelper.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ObservedTestHelper.java 7 Sep 2003 10:33:33 - 1.5
+++ ObservedTestHelper.java 7 Sep 2003 16:50:59 - 1.6
@@ -190,6 +190,15 @@
doTestRemoveNCopies(factory);
}
+public static void bulkTestObservedBuffer(ObservedFactory factory) {
+Assert.assertTrue(factory.createObservedCollection() instanceof
ObservedBuffer);
+Assert.assertTrue(factory.createObservedCollection(LISTENER) instanceof
ObservedBuffer);
+Assert.assertTrue(factory.createObservedCollection(new
StandardModificationHandler()) instanceof ObservedBuffer);
+
+bulkTestObservedCollection(factory);
+doTestRemoveNext(factory);
+}
+
//---
public static void doTestFactoryPlain(ObservedFactory factory) {
ObservedCollection coll = factory.createObservedCollection();
@@ -847,6 +856,51 @@
Assert.assertEquals(13, LISTENER.postEvent.getPreSize());
Assert.assertEquals(10, LISTENER.postEvent.getPostSize());
Assert.assertEquals(-3, LISTENER.postEvent.getSizeChange());
+Assert.assertEquals(true, LISTENER.postEvent.isSizeChanged());
+
+Assert.assertEquals(false, LISTENER.postEvent.isRange());
+Assert.assertEquals(-1, LISTENER.postEvent.getRangeOffset());
+Assert.assertEquals(null, LISTENER.postEvent.getRange());
+Assert.assertEquals(false, LISTENER.postEvent.isTypeAdd());
+Assert.assertEquals(true, LISTENER.postEvent.isTypeReduce());
+Assert.assertEquals(false, LISTENER.postEvent.isTypeChange());
+Assert.assertEquals(false, LISTENER.postEvent.isTypeBulk());
+}
+
+//---
+public static void doTestRemoveNext(ObservedFactory factory) {
+ObservedBuffer coll = (ObservedBuffer)
factory.createObservedCollection(LISTENER);
+
+coll.add(SIX);
+coll.add(SEVEN);
+LISTENER.preEvent = null;
+LISTENER.postEvent = null;
+Assert.assertEquals(2, coll.size());
+coll.remove();
+Assert.assertEquals(1, coll.size());
+// pre
+Assert.assertSame(coll, LISTENER.preEvent.getObservedCollection());
+Assert.assertSame(coll.getHandler(), LISTENER.preEvent.getHandler());
+Assert.assertEquals(ModificationEventType.REMOVE_NEXT,
LISTENER.preEvent.getType());
+Assert.assertEquals(-1, LISTENER.preEvent.getChangeIndex());
+Assert.assertSame(null, LISTENER.preEvent.getChangeObject());
+Assert.assertEquals(0, LISTENER.preEvent.getChangeCollection().size());
+Assert.assertEquals(1, LISTENER.preEvent.getChangeRepeat());
+Assert.assertSame(null, LISTENER.preEvent.getPrevious());
+Assert.assertEquals(2, LISTENER.preEvent.getPreSize());
+// post
+Assert.assertSame(coll,
Re: [collections] Email addresses in Source code or Maven project xml
I agree, +1 to emails in project.xml and -1 to emails in code. Mainly due to spam considerations, I think it's a better idea to keep the emails in one place, in case we need to obfuscate them (person AT apache DOT org), or something like that. On Sat, 2003-09-06 at 18:00, Stephen Colebourne wrote: At present [collections] has a mixture of email addresses. Some people have their email address by the code in the java file, some don't. I recently extracted all email addresses and names to the maven project xml file, applying a minimum anti spam tactic. But what should we do in general? And how much does this matter? Email addresses in project.xml - Yes/No? I prefer yes. Email addresses in code - Keep/Remove? I prefer remove. Opinions? Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22972] New: - [collections] [PATCH] MapUtils JavaDoc fixes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22972. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22972 [collections] [PATCH] MapUtils JavaDoc fixes Summary: [collections] [PATCH] MapUtils JavaDoc fixes Product: Commons Version: Nightly Builds Platform: Other OS/Version: Other Status: NEW Severity: Minor Priority: Other Component: Collections AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The attached patch modifies some documentation tags and fixes the code example for MapUtils.lazySortedMap. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22972] - [collections] [PATCH] MapUtils JavaDoc fixes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22972. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22972 [collections] [PATCH] MapUtils JavaDoc fixes --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 21:37 --- Created an attachment (id=8094) JavaDoc fixes for MapUtils v 1.32 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22973] New: - [collections] [PATCH] patch to reduce object creation in CollectionUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22973.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22973
[collections] [PATCH] patch to reduce object creation in CollectionUtils
Summary: [collections] [PATCH] patch to reduce object creation in
CollectionUtils
Product: Commons
Version: Nightly Builds
Platform: Other
OS/Version: Other
Status: NEW
Severity: Minor
Priority: Other
Component: Collections
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The attached patch reduces the number of Integer objects created when invoking
CollectionUtils.getCardinalityMap(final Collection col). The number of Integers
created is reduced by the count of unique objects within col.
The patch does not change the basic algorithm so the simplicity of the method is
not lost.
The change was profiled with the class below. These are the absolute times for
JDK 1.3.1_04 and 1.4.1_03
1.4 1.3
pre: 168267 153849
post: 164473 150866
and normalised to the pre version for each JDK
1.4 1.3
pre: 1.001.00
post: 0.980.98
so there was only a minor speed difference however the reduction in the number
of created objects has a memory use advantage. It was surprising to see that JDK
1.4.1 was slower than 1.3.1, in this limited test. The binaries were compiled
with JDK 1.4.1.
This is the test class:
import org.apache.commons.collections.CollectionUtils ;
import java.util.*;
public class CollectionUtilsTest {
Set a ;
Set b ;
Set c ;
Collection cols [] ;
long startMillis ;
void init () {
a = new HashSet () ;
for ( int i = 1 ; i = 1 ; i++ ) {
a.add ( new Integer ( i ) ) ;
}
b = new HashSet () ;
for ( int i = 5001 ; i = 15000 ; i++ ) {
b.add ( new Integer ( i ) ) ;
}
c = new HashSet () ;
for ( int i = 1001 ; i = 2 ; i++ ) {
c.add ( new Integer ( i ) ) ;
}
cols = new Collection [] { a, b, c } ;
startMillis = System.currentTimeMillis () ;
}
void run () {
for ( int i = 0 ; i 3 ; i++ ) {
for ( int j = 0 ; j 3 ; j++ ) {
CollectionUtils.union ( cols [ i ], cols [ j ] ) ;
CollectionUtils.intersection ( cols [ i ], cols [ j ] ) ;
CollectionUtils.disjunction ( cols [ i ], cols [ j ] ) ;
CollectionUtils.subtract ( cols [ i ], cols [ j ] ) ;
}
}
}
void report () {
System.out.println ( Elapsed millis: + ( System.currentTimeMillis () -
startMillis ) ) ;
}
public static void main ( String [] arg ) {
CollectionUtilsTest t = new CollectionUtilsTest () ;
t.init () ;
t.run () ;
t.report () ;
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22973] - [collections] [PATCH] patch to reduce object creation in CollectionUtils
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22973. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22973 [collections] [PATCH] patch to reduce object creation in CollectionUtils --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 22:30 --- Created an attachment (id=8095) This patch reduces the number of objects created in getCardinalityMap - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug in CLI
Hi, Err, there is a bug in commons-cli, the OptionBuilder implicitely initializes argNames with null, so the first option created, if it takes arguments, will have them with no names, hence not listed by the HelpFormatter. The patch follows (if at all needed ;-): diff -c -r1.15 OptionBuilder.java *** cli/src/java/org/apache/commons/cli/OptionBuilder.java 9 Dec 2002 23:47:24 - 1.15 --- cli/src/java/org/apache/commons/cli/OptionBuilder.java 7 Sep 2003 22:21:15 - *** *** 79,85 private static String description; /** argument name */ ! private static String argName; /** is required? */ private static boolean required; --- 79,85 private static String description; /** argument name */ ! private static String argName = arg; /** is required? */ private static boolean required; Great stuff, BTW. Being able to write a complete CLI parser in 10 lines, plus the free help print, gotta love that. Cheers, Matthieu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/list - New directory
scolebourne2003/09/07 16:52:04 jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/list - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/listiterator - New directory
scolebourne2003/09/07 16:52:04 jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/listiterator - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/list PrimitiveList.java IntList.java
scolebourne2003/09/07 16:52:10 Modified:primitives/src/java/org/apache/commons/primitive/collection IntCollection.java primitives/src/java/org/apache/commons/primitive/iterator IntIterator.java PrimitiveIterator.java Added: primitives/src/java/org/apache/commons/primitive/listiterator IntListIterator.java PrimitiveListIterator.java primitives/src/java/org/apache/commons/primitive/list PrimitiveList.java IntList.java Log: Add more detail to proposed interfaces Revision ChangesPath 1.2 +35 -3 jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/collection/IntCollection.java Index: IntCollection.java === RCS file: /home/cvs/jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/collection/IntCollection.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- IntCollection.java1 Sep 2003 23:56:05 - 1.1 +++ IntCollection.java7 Sep 2003 23:52:10 - 1.2 @@ -89,6 +89,14 @@ boolean containsValue(int value); /** + * Checks if the collection contains all of the primitive values (optional operation). + * + * @param values the values to search for + * @return codetrue/code if all the values are found + */ +boolean containsAllValues(int[] values); + +/** * Gets the elements of this collection as an array. * * @return a new array containing a copy of the elements of this collection @@ -105,7 +113,7 @@ * @param array the array to add the elements to * @param insertionIndex the position in the array to add the elements to * @return the array with the inserted collection - * @throws IndexOutOfBoundsException is the index is invalid + * @throws IndexOutOfBoundsException if the index is invalid */ int[] toValueArray(int[] array, int insertionIndex); @@ -133,9 +141,33 @@ * * @param value the value to remove * @return codetrue/code if this collection was modified by this method call - * @throws IllegalArgumentException if value is rejected by this collection * @throws UnsupportedOperationException if not supported by this collection */ boolean removeValue(int value); + +/** + * Adds an array of primitive values to this list (optional operation). + * p + * This method is optional, throwing an UnsupportedOperationException if the + * collection cannot be added to. + * + * @param values the values to add to this collection + * @return codetrue/code if this list was modified by this method call + * @throws IllegalArgumentException if value is rejected by this collection + * @throws UnsupportedOperationException if not supported by this collection + */ +boolean addAllValues(int[] values); + +/** + * Removes each of an array of primitive values from this list (optional operation). + * p + * This method is optional, throwing an UnsupportedOperationException if the + * collection cannot be added to. + * + * @param values the values to remove from this collection + * @return codetrue/code if this list was modified by this method call + * @throws UnsupportedOperationException if not supported by this collection + */ +boolean removeAllValues(int[] values); } 1.2 +2 -2 jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/iterator/IntIterator.java Index: IntIterator.java === RCS file: /home/cvs/jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/iterator/IntIterator.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- IntIterator.java 1 Sep 2003 23:56:06 - 1.1 +++ IntIterator.java 7 Sep 2003 23:52:10 - 1.2 @@ -70,6 +70,6 @@ * @return the next available value * @throws NoSuchElementException if there are no more values available */ -int next(); +int nextValue(); } 1.2 +4 -25 jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/iterator/PrimitiveIterator.java Index: PrimitiveIterator.java === RCS file: /home/cvs/jakarta-commons-sandbox/primitives/src/java/org/apache/commons/primitive/iterator/PrimitiveIterator.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- PrimitiveIterator.java1 Sep 2003 23:56:06 - 1.1 +++ PrimitiveIterator.java7 Sep
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HttpConnection.java
mbecke 2003/09/07 17:33:31
Modified:httpclient/src/java/org/apache/commons/httpclient Tag:
HTTPCLIENT_2_0_BRANCH HttpConnection.java
Log:
Switched the order in which socket streams are closed.
PR: 22941
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
No revision
No revision
1.67.2.3 +12 -12
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java
Index: HttpConnection.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java,v
retrieving revision 1.67.2.2
retrieving revision 1.67.2.3
diff -u -r1.67.2.2 -r1.67.2.3
--- HttpConnection.java 31 Jul 2003 17:59:17 - 1.67.2.2
+++ HttpConnection.java 8 Sep 2003 00:33:31 - 1.67.2.3
@@ -1133,24 +1133,24 @@
// no longer care about previous responses...
lastResponseInputStream = null;
-if (null != inputStream) {
-InputStream temp = inputStream;
-inputStream = null;
+if (null != outputStream) {
+OutputStream temp = outputStream;
+outputStream = null;
try {
temp.close();
} catch (Exception ex) {
-LOG.debug(Exception caught when closing input, ex);
+LOG.debug(Exception caught when closing output, ex);
// ignored
}
}
-if (null != outputStream) {
-OutputStream temp = outputStream;
-outputStream = null;
+if (null != inputStream) {
+InputStream temp = inputStream;
+inputStream = null;
try {
temp.close();
} catch (Exception ex) {
-LOG.debug(Exception caught when closing output, ex);
+LOG.debug(Exception caught when closing input, ex);
// ignored
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient HttpConnection.java
mbecke 2003/09/07 17:37:29
Modified:httpclient/src/java/org/apache/commons/httpclient
HttpConnection.java
Log:
Switched the order in which socket streams are closed.
PR: 22941
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
1.74 +12 -12
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java
Index: HttpConnection.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -r1.73 -r1.74
--- HttpConnection.java 12 Aug 2003 02:35:17 - 1.73
+++ HttpConnection.java 8 Sep 2003 00:37:29 - 1.74
@@ -1053,24 +1053,24 @@
// no longer care about previous responses...
lastResponseInputStream = null;
-if (null != inputStream) {
-InputStream temp = inputStream;
-inputStream = null;
+if (null != outputStream) {
+OutputStream temp = outputStream;
+outputStream = null;
try {
temp.close();
} catch (Exception ex) {
-LOG.debug(Exception caught when closing input, ex);
+LOG.debug(Exception caught when closing output, ex);
// ignored
}
}
-if (null != outputStream) {
-OutputStream temp = outputStream;
-outputStream = null;
+if (null != inputStream) {
+InputStream temp = inputStream;
+inputStream = null;
try {
temp.close();
} catch (Exception ex) {
-LOG.debug(Exception caught when closing output, ex);
+LOG.debug(Exception caught when closing input, ex);
// ignored
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/examples MultipartFileUploadApp.java
sullis 2003/09/07 18:15:11
Modified:httpclient/src/examples MultipartFileUploadApp.java
Log:
added a JCheckBox to the GUI. The checkbox allows the user
to control whether the Expect header is used.
CVS: --
CVS: PR:
CVS: If this change addresses a PR in the problem report tracking
CVS: database, then enter the PR number(s) here.
CVS: Obtained from:
CVS: If this change has been taken from another system, such as NCSA,
CVS: then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS: If this code has been contributed to Apache by someone else; i.e.,
CVS: they sent us a patch or a new module, then include their name/email
CVS: address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS: If we are doing pre-commit code reviews and someone else has
CVS: reviewed your changes, include their name(s) here.
CVS: If you have not had it reviewed then delete this line.
Revision ChangesPath
1.6 +24 -2
jakarta-commons/httpclient/src/examples/MultipartFileUploadApp.java
Index: MultipartFileUploadApp.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/examples/MultipartFileUploadApp.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- MultipartFileUploadApp.java 20 Feb 2003 09:23:29 - 1.5
+++ MultipartFileUploadApp.java 8 Sep 2003 01:15:11 - 1.6
@@ -72,6 +72,7 @@
import javax.swing.DefaultComboBoxModel;
import javax.swing.JButton;
import javax.swing.JComboBox;
+import javax.swing.JCheckBox;
import javax.swing.JFileChooser;
import javax.swing.JFrame;
import javax.swing.JLabel;
@@ -96,6 +97,7 @@
public class MultipartFileUploadApp {
public static void main(String[] args) {
+
MultipartFileUploadFrame f = new MultipartFileUploadFrame();
f.setTitle(HTTP multipart file upload application);
f.pack();
@@ -130,6 +132,10 @@
final JTextField tfdTargetFile = new JTextField(30);
tfdTargetFile.setEditable(false);
+
+ final JCheckBox cbxExpectHeader = new JCheckBox(Use Expect
header);
+ cbxExpectHeader.setSelected(false);
+
final JButton btnDoUpload = new JButton(Upload);
btnDoUpload.setEnabled(false);
@@ -175,6 +181,13 @@
MultipartPostMethod filePost =
new MultipartPostMethod(targetURL);
+ if (cbxExpectHeader.isSelected()) {
+ filePost.setUseExpectHeader(true);
+ }
+ else {
+ filePost.setUseExpectHeader(false);
+ }
+
try {
appendMessage(Uploading + targetFile.getName() + to
+ targetURL);
filePost.addParameter(targetFile.getName(), targetFile);
@@ -243,12 +256,21 @@
c.gridx = 2;
getContentPane().add(btnSelectFile, c);
+ c.anchor = GridBagConstraints.CENTER;
+ c.fill = GridBagConstraints.NONE;
+ c.insets = new Insets(10, 10, 10, 10);
+ c.gridwidth = 3;
+ c.gridx = 0;
+ c.gridy = 2;
+ getContentPane().add(cbxExpectHeader, c);
+
+
c.anchor = GridBagConstraints.CENTER;
c.fill = GridBagConstraints.NONE;
c.insets = new Insets(10, 10, 10, 10);
c.gridwidth = 3;
c.gridx = 0;
-c.gridy = 2;
+c.gridy = 3;
getContentPane().add(btnDoUpload, c);
c.anchor = GridBagConstraints.CENTER;
@@ -258,7 +280,7 @@
c.gridheight = 3;
c.weighty = 3;
c.gridx = 0;
-c.gridy = 3;
+c.gridy = 4;
getContentPane().add(new JScrollPane(taTextResponse), c);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient TestAuthenticator.java
mbecke 2003/09/07 18:49:15
Modified:httpclient/src/java/org/apache/commons/httpclient/auth Tag:
HTTPCLIENT_2_0_BRANCH DigestScheme.java
httpclient/src/test/org/apache/commons/httpclient Tag:
HTTPCLIENT_2_0_BRANCH TestAuthenticator.java
Log:
Adds support for stale digest nonce values.
PR: 22655
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
No revision
No revision
1.4.2.2 +19 -3
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/auth/DigestScheme.java
Index: DigestScheme.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/auth/DigestScheme.java,v
retrieving revision 1.4.2.1
retrieving revision 1.4.2.2
diff -u -r1.4.2.1 -r1.4.2.2
--- DigestScheme.java 13 Aug 2003 19:58:14 - 1.4.2.1
+++ DigestScheme.java 8 Sep 2003 01:49:15 - 1.4.2.2
@@ -104,6 +104,22 @@
};
/**
+ * Gets an ID based upon the realm and the nonce value. This ensures that
requests
+ * to the same realm with different nonce values will succeed. This
differentiation
+ * allows servers to request re-authentication using a fresh nonce value.
+ */
+public String getID() {
+
+String id = getRealm();
+String nonce = getParameter(nonce);
+if (nonce != null) {
+id += - + nonce;
+}
+
+return id;
+}
+
+/**
* Constructor for the digest authentication scheme.
*
* @param challenge The authentication challenge
No revision
No revision
1.25.2.2 +37 -4
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestAuthenticator.java
Index: TestAuthenticator.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestAuthenticator.java,v
retrieving revision 1.25.2.1
retrieving revision 1.25.2.2
diff -u -r1.25.2.1 -r1.25.2.2
--- TestAuthenticator.java8 Aug 2003 06:38:06 - 1.25.2.1
+++ TestAuthenticator.java8 Sep 2003 01:49:15 - 1.25.2.2
@@ -355,6 +355,39 @@
checkAuthorization(cred, method.getName(),
method.getRequestHeader(Authorization).getValue());
}
+public void testDigestAuthenticationWithStaleNonce() throws Exception {
+
+String headers =
+HTTP/1.1 401 OK\r\n +
+Connection: close\r\n +
+Content-Length: 0\r\n +
+WWW-Authenticate: Digest realm=\realm1\, nonce=\ABC123\\r\n;
+String headers2 =
+HTTP/1.1 401 OK\r\n +
+Connection: close\r\n +
+Content-Length: 0\r\n +
+WWW-Authenticate: Digest realm=\realm1\, nonce=\321CBA\,
stale=\true\\r\n;
+String headers3 =
+HTTP/1.1 200 OK\r\n +
+Connection: close\r\n +
+Server: HttpClient Test/2.0\r\n\r\n +
+stuff\r\n;
+
+SimpleHttpConnection conn = new SimpleHttpConnection();
+
+conn.addResponse(headers);
+conn.addResponse(headers2);
+conn.addResponse(headers3);
+HttpState state = new HttpState();
+UsernamePasswordCredentials cred = new
UsernamePasswordCredentials(username,password);
+state.setCredentials(null, null, cred);
+
+SimpleHttpMethod method = new SimpleHttpMethod();
+method.setDoAuthentication(true);
+assertEquals(Authentication failed, 200, method.execute(state, conn));
+checkAuthorization(cred, method.getName(),
method.getRequestHeader(Authorization).getValue());
+}
+
public void testDigestAuthenticationWithMultipleRealms() throws Exception {
String challenge1 = Digest realm=\realm1\;
String challenge2 = Digest realm=\realm2\;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient project.xml
sullis 2003/09/07 18:54:46 Modified:httpclient project.xml Log: updated email address for Sean Sullivan CVS: -- CVS: PR: CVS: If this change addresses a PR in the problem report tracking CVS: database, then enter the PR number(s) here. CVS: Obtained from: CVS: If this change has been taken from another system, such as NCSA, CVS: then name the system in this line, otherwise delete it. CVS: Submitted by: CVS: If this code has been contributed to Apache by someone else; i.e., CVS: they sent us a patch or a new module, then include their name/email CVS: address here. If this is your work then delete this line. CVS: Reviewed by: CVS: If we are doing pre-commit code reviews and someone else has CVS: reviewed your changes, include their name(s) here. CVS: If you have not had it reviewed then delete this line. Revision ChangesPath 1.40 +1 -1 jakarta-commons/httpclient/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/httpclient/project.xml,v retrieving revision 1.39 retrieving revision 1.40 diff -u -r1.39 -r1.40 --- project.xml 22 Aug 2003 04:04:37 - 1.39 +++ project.xml 8 Sep 2003 01:54:46 - 1.40 @@ -145,7 +145,7 @@ developer nameSean C. Sullivan/name idsullis/id - email[EMAIL PROTECTED]/email + emailsullis -at- apache/email organizationIndependent consultant/organization roles roleJava Developer/role - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient TestAuthenticator.java
mbecke 2003/09/07 19:00:03
Modified:httpclient/src/java/org/apache/commons/httpclient/auth
DigestScheme.java
httpclient/src/test/org/apache/commons/httpclient
TestAuthenticator.java
Log:
Adds support for stale digest nonce values.
PR: 22655
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
1.7 +19 -3
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/auth/DigestScheme.java
Index: DigestScheme.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/auth/DigestScheme.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- DigestScheme.java 13 Aug 2003 19:57:10 - 1.6
+++ DigestScheme.java 8 Sep 2003 02:00:03 - 1.7
@@ -104,6 +104,22 @@
};
/**
+ * Gets an ID based upon the realm and the nonce value. This ensures that
requests
+ * to the same realm with different nonce values will succeed. This
differentiation
+ * allows servers to request re-authentication using a fresh nonce value.
+ */
+public String getID() {
+
+String id = getRealm();
+String nonce = getParameter(nonce);
+if (nonce != null) {
+id += - + nonce;
+}
+
+return id;
+}
+
+/**
* Constructor for the digest authentication scheme.
*
* @param challenge The authentication challenge
1.29 +38 -4
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestAuthenticator.java
Index: TestAuthenticator.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestAuthenticator.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- TestAuthenticator.java12 Aug 2003 02:35:17 - 1.28
+++ TestAuthenticator.java8 Sep 2003 02:00:03 - 1.29
@@ -355,6 +355,40 @@
checkAuthorization(cred, method.getName(),
method.getRequestHeader(Authorization).getValue());
}
+public void testDigestAuthenticationWithStaleNonce() throws Exception {
+
+String headers =
+HTTP/1.1 401 OK\r\n +
+Connection: close\r\n +
+Content-Length: 0\r\n +
+WWW-Authenticate: Digest realm=\realm1\, nonce=\ABC123\\r\n;
+String headers2 =
+HTTP/1.1 401 OK\r\n +
+Connection: close\r\n +
+Content-Length: 0\r\n +
+WWW-Authenticate: Digest realm=\realm1\, nonce=\321CBA\,
stale=\true\\r\n;
+String headers3 =
+HTTP/1.1 200 OK\r\n +
+Connection: close\r\n +
+Server: HttpClient Test/2.0\r\n\r\n +
+stuff\r\n;
+
+SimpleHttpConnection conn = new SimpleHttpConnection();
+
+conn.addResponse(headers);
+conn.addResponse(headers2);
+conn.addResponse(headers3);
+UsernamePasswordCredentials cred = new
UsernamePasswordCredentials(username,password);
+client.getState().setCredentials(null, null, cred);
+
+connectionManager.setConnection(conn);
+
+SimpleHttpMethod method = new SimpleHttpMethod();
+method.setDoAuthentication(true);
+assertEquals(Authentication failed, 200, client.executeMethod(method));
+checkAuthorization(cred, method.getName(),
method.getRequestHeader(Authorization).getValue());
+}
+
public void testDigestAuthenticationWithMultipleRealms() throws Exception {
String challenge1 = Digest realm=\realm1\;
String challenge2 = Digest realm=\realm2\;
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/mapper/xdocs todo.xml navigation.xml index.xml
dgraham 2003/09/07 21:37:27 Added: mapper project.xml mapper/xdocs todo.xml navigation.xml index.xml Log: Added Maven build files to generate website. Revision ChangesPath 1.1 jakarta-commons-sandbox/mapper/project.xml Index: project.xml === ?xml version=1.0? project pomVersion3/pomVersion nameCommons Mapper/name idcommons-mapper/id currentVersion0.6-dev/currentVersion organization nameApache Software Foundation/name urlhttp://jakarta.apache.org//url /organization inceptionYear2003/inceptionYear packageorg.apache.commons.mapper/package shortDescriptionCommons Mapper/shortDescription !-- Gump integration -- gumpRepositoryIdjakarta/gumpRepositoryId description Mapper is a thin abstraction layer around a project's chosen data mapping technology. /description urlhttp://jakarta.apache.org/commons/sandbox/mapper//url issueTrackingUrlhttp://issues.apache.org/bugzilla//issueTrackingUrl siteAddressjakarta.apache.org/siteAddress siteDirectory/www/jakarta.apache.org/commons/sandbox/mapper//siteDirectory distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons-sandbox/mapper//distributionDirectory repository connection scm:cvs:pserver:[EMAIL PROTECTED]:/home/cvspublic:jakarta-commons-sandbox/mapper /connection url http://cvs.apache.org/viewcvs.cgi/jakarta-commons-sandbox/mapper/ /url /repository mailingLists mailingList nameCommons User List/name subscribe [EMAIL PROTECTED] /subscribe unsubscribe [EMAIL PROTECTED] /unsubscribe archive http://www.mail-archive.com/[EMAIL PROTECTED]/ /archive /mailingList mailingList nameCommons Developer List/name subscribe [EMAIL PROTECTED] /subscribe unsubscribe [EMAIL PROTECTED] /unsubscribe archive http://www.mail-archive.com/[EMAIL PROTECTED]/ /archive /mailingList /mailingLists developers developer nameDavid Graham/name iddgraham/id email[EMAIL PROTECTED]/email organization/organization /developer /developers dependencies !-- for testing -- dependency idjunit/id version3.8.1/version /dependency /dependencies build nagEmailAddress[EMAIL PROTECTED]/nagEmailAddress sourceDirectorysrc/share/sourceDirectory unitTestSourceDirectorysrc/test/unitTestSourceDirectory !-- Unit test cases -- unitTest includes include**/*Test.java/include /includes /unitTest !-- Resources that are packaged up inside the JAR file -- resources includes include**/*.properties/include /includes /resources !-- Integration unit test cases -- integrationUnitTest/ jars /jars /build /project 1.1 jakarta-commons-sandbox/mapper/xdocs/todo.xml Index: todo.xml === ?xml version=1.0? document properties titleTODO/title author email=[EMAIL PROTECTED]David Graham/author /properties body section name=TODO p The following is a list of items that need to be completed in Mapper. Contributions are welcome!. /p table border=1 tr thAction Item/th thVolunteer/th /tr tr td strongDocumentation/strong - Provide more examples and a basic User's Guide information in a codepackage.html/code file. /td td align=center/td /tr /table /section /body /document 1.1 jakarta-commons-sandbox/mapper/xdocs/navigation.xml Index: navigation.xml === ?xml version=1.0 encoding=ISO-8859-1? project name=Mapper titleMapper/title organizationLogo href=/images/jakarta-logo-blue.gifJakarta/organizationLogo body menu name=Mapper item name=Overviewhref=/index.html/ item name=To Do List href=/todo.html/ /menu /body /project 1.1 jakarta-commons-sandbox/mapper/xdocs/index.xml Index: index.xml === ?xml version=1.0? document properties titleMapper: Data Mapping Abstraction Component/title author email=[EMAIL PROTECTED]David Graham/author /properties body section name=Mapper: Data Mapping
cvs commit: jakarta-commons-sandbox/mapper/xdocs - New directory
dgraham 2003/09/07 21:37:18 jakarta-commons-sandbox/mapper/xdocs - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22941] - Socket streams are closed in the incorrect order.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941 Socket streams are closed in the incorrect order. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22941] - Socket streams are closed in the incorrect order.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941 Socket streams are closed in the incorrect order. [EMAIL PROTECTED] changed: What|Removed |Added CC||commons-httpclient- ||[EMAIL PROTECTED] Status|NEW |ASSIGNED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22968] New: - HttpConnection.isResponseAvailable() calls setSoTimeout() but does not catch IOException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22968. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22968 HttpConnection.isResponseAvailable() calls setSoTimeout() but does not catch IOException Summary: HttpConnection.isResponseAvailable() calls setSoTimeout() but does not catch IOException Product: Commons Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: HttpClient AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] HttpConnection.isResponseAvailable() can throw an IOException when setting the soTimeout but should probably just return false in this case. http://marc.theaimsgroup.com/?t=10626848512r=1w=2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22969] New: - return value of PostMethod#removeParameter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969 return value of PostMethod#removeParameter Summary: return value of PostMethod#removeParameter Product: Commons Version: 2.0 Final Platform: PC OS/Version: Windows XP Status: NEW Severity: Normal Priority: Other Component: HttpClient AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] HttpClient2.0-rc1 About public boolean removeParameter(String paramName) throws IllegalArgumentException method. - PostMethod method = new PostMethod(uri); method.addParameter(name, Matsui Hideki); boolean b; b = method.removeParameter(name); // returns true. b = method.removeParameter(); // returns true. why??? --- sorry for my poor english. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22628] - RFE: Implement HTTP 1.1 Pipelining
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22628. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22628 RFE: Implement HTTP 1.1 Pipelining [EMAIL PROTECTED] changed: What|Removed |Added Priority|Other |Low Target Milestone|--- |3.0 Final Version|3.0 Final |2.0 Beta 2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22941] - Socket streams are closed in the incorrect order.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22941 Socket streams are closed in the incorrect order. [EMAIL PROTECTED] changed: What|Removed |Added Target Milestone|--- |2.0 Final Version|unspecified |2.0 Beta 1 --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 18:10 --- Looks fine to me. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22969] - return value of PostMethod#removeParameter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969 return value of PostMethod#removeParameter [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Priority|Other |Low Target Milestone|--- |2.0 Final --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 18:44 --- Hirai, This is clearly a bug. Thanks for tracking it down. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22969] - return value of PostMethod#removeParameter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22969 return value of PostMethod#removeParameter --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 18:46 --- Created an attachment (id=8089) Patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22926] - [patch] Support for digest auth MD5-sess
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22926 [patch] Support for digest auth MD5-sess --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 18:56 --- I believe the patch is good to be committed. The question remains, though, if the patch should be applied to HEAD only or to 2.0 branch and HEAD. Opinions? Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22970] - PostMethod#setParameter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22970. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22970 PostMethod#setParameter --- Additional Comments From [EMAIL PROTECTED] 2003-09-07 19:13 --- Created an attachment (id=8090) Patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22655] - Authentication does not respond to stale nonce
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22655. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22655 Authentication does not respond to stale nonce [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-09-08 02:03 --- Patch applied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 22940] - gzip content-encoding support
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22940. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22940 gzip content-encoding support --- Additional Comments From [EMAIL PROTECTED] 2003-09-08 02:11 --- Oleg, I agree. HttpClient should only handle transfer encodings. Content encodings are the business of the user. Mike - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
