DO NOT REPLY [Bug 36237] New: - [jci] FileResourceStore does not store class files correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36237. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36237 Summary: [jci] FileResourceStore does not store class files correctly Product: Commons Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Sandbox AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] The FileResourceStore stores class files in BASE_DIR/my.package.MyClass while the rest of the Java world would expect it in BASE_DIR/my/package/MyClass.class. To communicate with the rest of the Java world - in my case with XSP inside Cocoon - it would be necessary to change the FileResourceStore accordingly. When writing this I wonder what happens with non-to-be-compiled-resources. Their name will be also converted to class file names, and - as long as the rest of the Java world is not involved - they can be stored and read again - even if their name will be garbled. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36237] - [jci] FileResourceStore does not store class files correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36237. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36237 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 09:32 --- Created an attachment (id=16088) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16088action=view) Patch to FileResourceStore. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233300 - /jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java
Author: tcurdt
Date: Thu Aug 18 01:31:18 2005
New Revision: 233300
URL: http://svn.apache.org/viewcvs?rev=233300view=rev
Log:
proper dir structure (thanks to Joerg)
Modified:
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java
Modified:
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java?rev=233300r1=233299r2=233300view=diff
==
---
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/stores/FileResourceStore.java
Thu Aug 18 01:31:18 2005
@@ -32,14 +32,14 @@
public final class FileResourceStore implements ResourceStore {
private final File root;
-
+
public FileResourceStore(final File pFile) {
root = pFile;
}
public byte[] read( final String resourceName ) {
InputStream is = null;
try {
-is = new FileInputStream(new File(root, resourceName));
+is = new FileInputStream(getFile(resourceName));
final byte[] data = IOUtils.toByteArray(is);
return data;
} catch (FileNotFoundException e) {
@@ -52,14 +52,20 @@
}
}
}
-
+
return null;
}
-
public void write( final String resourceName, final byte[] clazzData ) {
OutputStream os = null;
try {
-os = new FileOutputStream(new File(root, resourceName));
+final File file = getFile(resourceName);
+final File parent = file.getParentFile();
+if (!parent.exists()) {
+if (!parent.mkdirs()) {
+throw new IOException(could not create + parent);
+}
+}
+os = new FileOutputStream(file);
os.write(clazzData);
} catch (FileNotFoundException e) {
} catch (IOException e) {
@@ -71,10 +77,15 @@
}
}
}
-}
+}
+
+public void remove( final String pResourceName ) {
+getFile(pResourceName).delete();
+}
-public void remove( final String resourceName ) {
-final File file = new File(root, resourceName);
-file.delete();
+private File getFile(final String pResourceName) {
+final String fileName = pResourceName.replace('.', File.separatorChar)
+ .class;
+return new File(root, fileName);
}
+
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36237] - [jci] FileResourceStore does not store class files correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36237. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36237 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 10:34 --- you are right this should be changed and the + .class should go away. basically it should be moved up the call chain. this can be done proberly when the matching support (see TODO) is being tackled -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36237] - [jci] FileResourceStore does not store class files correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36237. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36237 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 11:26 --- And you already have fixed the issue I came across when changing my output dir to another dir than the input dir: The files were no longer stored due to missing parent dirs. ;-) Thanks -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 25 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-18082005.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 53 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-18082005 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-18082005.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-18082005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-18082005.jar - [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.digester.Digester peek [junit] WARNING: Empty stack (returning null) [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.digester.Digester peek [junit] WARNING: Empty stack (returning null) [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] - --- [junit] Testcase: testCapitalizeNameMapper took 0.53 sec [junit] Testcase: testDecapitalizeNameMapper took 0.046 sec [junit] Testcase: testDefaultElementMapper took 0.028 sec [junit] Testcase: testHyphenatedNameMapper took 0.032 sec
[EMAIL PROTECTED]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-betwixt has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 25 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-betwixt : Commons Betwixt Package Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-betwixt-18082005.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html Work Name: build_jakarta-commons_commons-betwixt (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 53 secs Command Line: java -Djava.awt.headless=true -Dant.build.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-18082005 -Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-18082005.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-18082005.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api-18082005.jar - [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.digester.Digester peek [junit] WARNING: Empty stack (returning null) [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.digester.Digester peek [junit] WARNING: Empty stack (returning null) [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] Aug 18, 2005 3:17:41 AM org.apache.commons.betwixt.expression.Context popOptions [junit] INFO: Cannot pop options off empty stack [junit] - --- [junit] Testcase: testCapitalizeNameMapper took 0.53 sec [junit] Testcase: testDecapitalizeNameMapper took 0.046 sec [junit] Testcase: testDefaultElementMapper took 0.028 sec [junit] Testcase: testHyphenatedNameMapper took 0.032 sec
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 12:29 --- The problem is an incorrect IClassLoader hierarchie. In the sample mentioned (Arrays.fill(char[], char)) I get two different instances of IClass for char[] - this is why Janino finds no match. Patch will follow soon. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 12:48 --- Created an attachment (id=16089) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16089action=view) Patch to JaninoJavaCompiler. At the moment all dependencies to be loaded when compiling go to the this.loader. This is why everything works except other to-be-compiled classes. With changing new UnitCompiler(unit, loader) to new UnitCompiler(unit, this) it is exactly the other way around: every class will be first looked up at the internal IClassLoader of the JaninoJavaCompiler. This works as long as class names indeed start with java. or similar as these calls are delegated to the this.loader. But for an char[] or probably other similar things this does not work. You get two different IClass instances and the match in the UnitCompiler fails when searching for matching methods. With the correct IClassLoader hierarchie the delegation for the Java core stuff is not done by hand, but the parent IClassLoader is asked in every case - and returns the correct IClass for char[]. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 13:14 --- I've applied the patch locally but the testcase fails with a NPE -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36230.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36230
--- Additional Comments From [EMAIL PROTECTED] 2005-08-18 13:35 ---
Yes, I can reproduce it with the JCI testcases too. I remember having this NPE
in a former version, but probably only with the JCI testcases. The latest code I
only tested with my own testcases, which are not committable yet.
The reason is:
String fileNameForClass = className.replace('.',
File.separatorChar) + .java;
-if (!resourceReader.isAvailable(fileNameForClass)) {
-return loader.loadIClass(type);
-}
For which cases does the resource reader return false?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 13:43 --- Hmm, I compared the different flows for delegating to parent IClassLoader and delegating by hand to this.loader. From what I see a simple null check for resourceReader.getContent(fileNameForClass) might be sufficient. If it is null the return type of findIClass(String) should be null too, shouldn't it? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 13:48 --- For me this null check and returning null fixes JaninoJavaCompilerTestCase. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 13:52 --- sounds ok to me -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36243] New: - TarInputStream returns negative value for read() [PATCH]
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36243.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36243
Summary: TarInputStream returns negative value for read() [PATCH]
Product: Commons
Version: 1.0 Alpha
Platform: All
OS/Version: All
Status: NEW
Severity: major
Priority: P2
Component: Sandbox
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
TarInputStream.read() does not convert the byte it has read to a positive number
after casting it to an integer. This causes downstream processes to fail to
recognise the value properly.
Index: org/apache/commons/compress/tar/TarInputStream.java
===
--- org/apache/commons/compress/tar/TarInputStream.java (revision 231420)
+++ org/apache/commons/compress/tar/TarInputStream.java (working copy)
@@ -306,7 +306,7 @@
}
else
{
-return (int)m_oneBuf[ 0 ];
+return (int)m_oneBuf[ 0 ] 0xFF;
}
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36243] - [compress] TarInputStream returns negative value for read() [PATCH]
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36243. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36243 [EMAIL PROTECTED] changed: What|Removed |Added Summary|TarInputStream returns |[compress] TarInputStream |negative value for read() |returns negative value for |[PATCH] |read() [PATCH] --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 15:23 --- When will this fail? Do you have such a tar-file. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36249] New: - MVSFTPEntryParser setRawListing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36249.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36249
Summary: MVSFTPEntryParser setRawListing
Product: Commons
Version: 1.4 Final
Platform: PC
OS/Version: Windows 2000
Status: NEW
Severity: normal
Priority: P1
Component: Net
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
The MVSFTPEntryParser is not setting the raw listing in the FTPFile that it
creates. The toString on FTPFile returns this value which causes a NPE when
trying to list files via ant.
Also it is creating an FTPFile for the header (Volume Unit...) that it
receives from the host. This also causes a problem with the list function in ant
because it receives 2 entries when requesting a listing for 1 file. Ant
(probably wrongfully) is just taking the first entry in the array that it
receives back so you never get your file names.
The following code is how I got it to work...
private static final String HEADER = Volume UnitReferred Ext Used Recfm
Lrecl BlkSz Dsorg Dsname;
...
public FTPFile parseFTPEntry(String entry)
{
FTPFile f = null;
if (matches(entry) !entry.trim().equals(HEADER))
{
f = new FTPFile();
String dataSetName = group(2);
f.setType(FTPFile.FILE_TYPE);
f.setName(dataSetName);
f.setRawListing(entry);
return (f);
}
return null;
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233331 - in /jakarta/commons/sandbox/jci/trunk: TODO project.properties project.xml src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java xdocs/index.xml
Author: tcurdt
Date: Thu Aug 18 09:00:30 2005
New Revision: 21
URL: http://svn.apache.org/viewcvs?rev=21view=rev
Log:
updated the list of supported compilers,
turned of breaking the build on failed tests (groovy compiler error/warning
test are still failing),
updated the todo,
fixed the janno compiler as reported by joerk,
added joerk as contributer :)
Modified:
jakarta/commons/sandbox/jci/trunk/TODO
jakarta/commons/sandbox/jci/trunk/project.properties
jakarta/commons/sandbox/jci/trunk/project.xml
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java
jakarta/commons/sandbox/jci/trunk/xdocs/index.xml
Modified: jakarta/commons/sandbox/jci/trunk/TODO
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/TODO?rev=21r1=20r2=21view=diff
==
--- jakarta/commons/sandbox/jci/trunk/TODO (original)
+++ jakarta/commons/sandbox/jci/trunk/TODO Thu Aug 18 09:00:30 2005
@@ -1,11 +1,9 @@
o integrate just4log into the build system
o compiler factory
o compiler implementations
- o groovy
o embedded java compiler
o javac
o jikes
o transformation pipelines (more than just one transformation)
o make suffixes matching (*.java, *.class) configurable
o documentation
-o turn the CompilationProblem into an interface
Modified: jakarta/commons/sandbox/jci/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/project.properties?rev=21r1=20r2=21view=diff
==
--- jakarta/commons/sandbox/jci/trunk/project.properties (original)
+++ jakarta/commons/sandbox/jci/trunk/project.properties Thu Aug 18 09:00:30
2005
@@ -1,4 +1,3 @@
-
# uncomment the next line to work in offline mode (no jar download no
linkcheck)
#maven.mode.online =
@@ -16,6 +15,7 @@
#org.apache.commons.logging.Log = org.apache.commons.logging.impl.SimpleLog
#maven.checkstyle.properties = checkstyle.xml
+maven.test.failure.ignore = true
maven.javadoc.author = false
maven.javadoc.links = http://java.sun.com/products/jdk/1.4/docs/api
@@ -32,8 +32,7 @@
#
# M A V E N J A R O V E R R I D E
#
-maven.jar.override = on
-
+#maven.jar.override = on
#maven.jar.jdtcore = ${basedir}/lib/jdtcore-3.1.0.jar
#maven.jar.bcel = ${basedir}/lib/jakarta-bcel-20040329.jar
Modified: jakarta/commons/sandbox/jci/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/project.xml?rev=21r1=20r2=21view=diff
==
--- jakarta/commons/sandbox/jci/trunk/project.xml (original)
+++ jakarta/commons/sandbox/jci/trunk/project.xml Thu Aug 18 09:00:30 2005
@@ -61,15 +61,20 @@
idtcurdt/id
emailtcurdt at apache.org/email
/developer
- /developers
-
- developers
developer
nameDon Brown/name
idmrdon/id
emailmrdon at apache.org/email
/developer
/developers
+
+ contributers
+contributer
+ nameJoerk Heinicke/name
+ idjheinicke/id
+ emailjoerg.heinicke at gmx.de/email
+/contributer
+ /contributers
dependencies
Modified:
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java?rev=21r1=20r2=21view=diff
==
---
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java
Thu Aug 18 09:00:30 2005
@@ -47,62 +47,52 @@
private final static Log log = LogFactory.getLog(JaninoJavaCompiler.class);
-private class CompilingIClassLoader extends IClassLoader {
+private static class CompilingIClassLoader extends IClassLoader {
-private ResourceReader resourceReader;
-private CompilationProblemHandler problemHandler;
-private Map classes,types;
-private ClassLoaderIClassLoader loader;
+private final Map types = new HashMap();
+private final ResourceReader resourceReader;
+private final CompilationProblemHandler problemHandler;
+private final Map classes;
private CompilingIClassLoader(ResourceReader resourceReader,
CompilationProblemHandler problemHandler, Map classes) {
-super(null);
+super(new ClassLoaderIClassLoader());
this.resourceReader = resourceReader;
DO NOT REPLY [Bug 36230] - [jci] Bug in JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36230 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 18:00 --- please verify -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36255] New: - [jci] Project dependencies fixed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36255. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36255 Summary: [jci] Project dependencies fixed Product: Commons Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Sandbox AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Now I'm a Maven user too ;-) For correctly setting up my MAVEN_REPO as in .classpath two dependencies were missing: commons-logging-api-1.0.4 + junit-3.8.1. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36255] - [jci] Project dependencies fixed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36255. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36255 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 20:38 --- Created an attachment (id=16098) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16098action=view) Patch to project.xml. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] New: - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 Summary: [jci] clean ups and enhancements to JaninoJavaCompiler Product: Commons Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: enhancement Priority: P2 Component: Sandbox AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] 1. Using CharArrayReader instead of ByteArrayInputStream: This avoids conversion of chars to bytes and back (Janino uses a Reader to read from the stream). 2. Providing an implementation of Janino's ErrorHandler and WarningHandler: Allows to get information than just CompileExceptions. 3. Iterating over the map's entry set instead of its key set: This avoids a lookup using get(key). 4. Common formatting at least for this file: parameters prefixed with 'p', references to instance variable prefixed with 'this'. Is there a style guide for this project? This patch mixes 4 issues, but each of it has only minor effects, that it is manageable I think: 1. -2 +2 lines 2. +3 lines inside, + implementation of CompilationProblemHandlerAdapter at the end 3. -4 +3 lines 4. the rest -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:04 --- Created an attachment (id=16099) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16099action=view) Patch to JaninoJavaCompiler. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[SCXML][ALL][BUILD][SITE] Publishing Commons (Sandbox) SCXML
Martin (or anyone else who can help get a new sandbox component going) - The initial scxml code is in sandbox [1], I'm now eager to get the nightlies cranking and the scxml site deployed. I need help with: Repository: * I wanted to update the trunks-sandbox externals [2] Sandbox nightlies: * Do the nightlies run ant or maven, or is that a per component preference? * Which box are they running on i.e. what do I need to do to get them going for scxml? Site: * AFAICS, buildall.sh seems a better bet than me doing a maven site:sshdeploy. Who runs that and how often? * Should I submit patch(es) to commons-build/menus once scxml is published; via bugzilla? If I've missed a bunch of documentation, please send a pointer ;-) -Rahul [1] SCXML code, direct, more sets of eyes the better [ http://svn.apache.org/repos/asf/jakarta/commons/sandbox/scxml/ ] [2] Earlier email on a related note [ http://marc.theaimsgroup.com/?l=jakarta-commons-devm=112430820307347w=2 ] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #16099|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:13 --- Created an attachment (id=16100) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16100action=view) Patch to JaninoJavaCompiler. Un-final-izing the exceptions happened by accident. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36259] New: - [jci] compiler always logs to console
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36259. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36259 Summary: [jci] compiler always logs to console Product: Commons Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Sandbox AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] The CompilingListener passes always an instance of the ConsoleCompilationProblem to the compiler - having 500 warning on the webapp's console is somewhat disturbing ;-) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36259] - [jci] compiler always logs to console
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36259. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36259 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:26 --- Created an attachment (id=16101) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16101action=view) Patch to CompilingClassLoader and its CompilingListener instance -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36255] - [jci] Project dependencies fixed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36255. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36255 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233365 - in /jakarta/commons/sandbox/jci/trunk: TODO project.xml src/java/org/apache/commons/jci/CompilingClassLoader.java src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompi
Author: tcurdt
Date: Thu Aug 18 12:41:18 2005
New Revision: 233365
URL: http://svn.apache.org/viewcvs?rev=233365view=rev
Log:
fixed the deps,
CCL cleanups,
updated the TODO
again thanks to Joerk
Modified:
jakarta/commons/sandbox/jci/trunk/TODO
jakarta/commons/sandbox/jci/trunk/project.xml
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/CompilingClassLoader.java
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/compilers/janino/JaninoJavaCompiler.java
Modified: jakarta/commons/sandbox/jci/trunk/TODO
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/TODO?rev=233365r1=233364r2=233365view=diff
==
--- jakarta/commons/sandbox/jci/trunk/TODO (original)
+++ jakarta/commons/sandbox/jci/trunk/TODO Thu Aug 18 12:41:18 2005
@@ -6,4 +6,5 @@
o jikes
o transformation pipelines (more than just one transformation)
o make suffixes matching (*.java, *.class) configurable
+o turn the JavaCompilerFactory into an interface and maybe provide a simple
default impl
o documentation
Modified: jakarta/commons/sandbox/jci/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/project.xml?rev=233365r1=233364r2=233365view=diff
==
--- jakarta/commons/sandbox/jci/trunk/project.xml (original)
+++ jakarta/commons/sandbox/jci/trunk/project.xml Thu Aug 18 12:41:18 2005
@@ -104,6 +104,12 @@
/dependency
dependency
+ groupIdcommons-logging/groupId
+ artifactIdcommons-logging-api/artifactId
+ version1.0.4/version
+/dependency
+
+dependency
groupIdcommons-collections/groupId
artifactIdcommons-collections/artifactId
version3.1/version
@@ -160,6 +166,12 @@
groupIdantlr/groupId
artifactIdantlr/artifactId
version2.7.5/version
+/dependency
+
+dependency
+ groupIdjunit/groupId
+ artifactIdjunit/artifactId
+ version3.8.1/version
/dependency
/dependencies
Modified:
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/CompilingClassLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/CompilingClassLoader.java?rev=233365r1=233364r2=233365view=diff
==
---
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/CompilingClassLoader.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/src/java/org/apache/commons/jci/CompilingClassLoader.java
Thu Aug 18 12:41:18 2005
@@ -20,23 +20,21 @@
import org.apache.commons.jci.compilers.eclipse.EclipseJavaCompiler;
import org.apache.commons.jci.listeners.CompilingListener;
import org.apache.commons.jci.monitor.FilesystemAlterationMonitor;
+import org.apache.commons.jci.problems.CompilationProblemHandler;
import org.apache.commons.jci.problems.ConsoleCompilationProblemHandler;
import org.apache.commons.jci.stores.MemoryResourceStore;
import org.apache.commons.jci.stores.TransactionalResourceStore;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
/**
* @author tcurdt
*
*/
public class CompilingClassLoader extends ReloadingClassLoader {
-
-private final static Log log =
LogFactory.getLog(CompilingClassLoader.class);
-
+
private final TransactionalResourceStore transactionalStore;
-private final JavaCompiler compiler;
-
+private final JavaCompiler compiler;
+private final CompilationProblemHandler problemHandler;
+
public CompilingClassLoader(final ClassLoader pParent, final File
pRepository) {
this(pParent, pRepository, new TransactionalResourceStore(
new MemoryResourceStore()) {
@@ -47,32 +45,34 @@
}
);
}
-
+
public CompilingClassLoader(final ClassLoader pParent, final File
pRepository, final TransactionalResourceStore pStore) {
-this(pParent, pRepository, pStore, new EclipseJavaCompiler());
+this(pParent, pRepository, pStore, new EclipseJavaCompiler(), new
ConsoleCompilationProblemHandler());
}
-
-public CompilingClassLoader(final ClassLoader pParent, final File
pRepository, final TransactionalResourceStore pStore, final JavaCompiler
pCompiler) {
-super(pParent, pRepository, pStore);
+public CompilingClassLoader(final ClassLoader pParent, final File
pRepository,
+final TransactionalResourceStore pStore, final JavaCompiler
pCompiler,
+final CompilationProblemHandler pProblemHandler) {
+super(pParent, pRepository, pStore);
transactionalStore = pStore;
-compiler = pCompiler;
+compiler = pCompiler;
+problemHandler = pProblemHandler;
}
public void start() {
-fam = new
DO NOT REPLY [Bug 36255] - [jci] Project dependencies fixed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36255. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36255 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36259] - [jci] compiler always logs to console
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36259. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36259 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:43 --- applied. thanks -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36259] - [jci] compiler always logs to console
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36259. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36259 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 21:43 --- applied. thanks -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36261] New: - [jci] no class could be loaded after a compilation error occured
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36261. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36261 Summary: [jci] no class could be loaded after a compilation error occured Product: Commons Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: major Priority: P2 Component: Sandbox AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] If a compilation error occured it is not possible to get classes again. Always CNFE is thrown though the compilation error itself has been fixes. The reason is simple: the store is empty. It gets emptied by the CompilingListener if the CompilationProblemHandler.getErrorCount() is 0. And the errorCount field gets not reset in the CompilationProblemHandlers. I made a little refactoring to the CompilationProblemHandler stuff: 1. The interface has just the handle(CompilationProblem) method, the counting is removed. 2. There is an implementation called CompilationProblemCounter for counting the errors and warnings. The counting is removed from existing CompilationProblemHandler implementations of course (SoC ;-) ). 3. Though it would be possible to change the JavaCompiler interface to accept more than one CompilationProblemHandler I decided to do it the implementation way for the moment: DelegatingCompilationProblemHandler. It is instantiated with a Collection of CompilationProblemHandlers. In case of CompilingListener it is an instance of CompilationProblemCounter and the passed CompilationProblemHandler. Though this solution allows the same flexibility like the mentioned change to JavaCompiler it might end in a hierarchy of DelegatingCompilationProblemHandlers. OTOH it simplifies the usage of the JavaCompiler by avoiding the instantiation of a Collection for even passing just one CompilationProblemHandler to the compiler instance. 4. LogCompilationProblemHandler renamed to CompilationProblemLogger (it also had a little cp bug in it, see the call to LogFactory). 5. ConsoleCompilationProblemHandler renamed to CompilationProblemConsolePrinter. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36261. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36261 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 22:32 --- Created an attachment (id=16106) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16106action=view) Patch to CompilationProblemHandler stuff. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36255] - [jci] Project dependencies fixed
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36255. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36255 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36257] - [jci] clean ups and enhancements to JaninoJavaCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36257. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36257 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36259] - [jci] compiler always logs to console
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36259. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36259 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36261. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36261 --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 22:47 --- The tests do not compile at the moment, but patch will follow. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jxpath][patch] JXPathException cause
Hi All,
Simple patch to JXPathException - guarantees better stacktraces under jdk 1.4,
reduces developer's headaches (what is this InvocationTargetException???), does
not harm anyone else.
Please apply,
Thanks,
Vadim
Index: src/java/org/apache/commons/jxpath/JXPathException.java
===
--- src/java/org/apache/commons/jxpath/JXPathException.java (revision
233370)
+++ src/java/org/apache/commons/jxpath/JXPathException.java (working copy)
@@ -116,4 +116,14 @@
public Throwable getException() {
return exception;
}
+
+/**
+ * Return the actual exception (if any) that caused this exception to
+ * be raised.
+ *
+ * @return The encapsulated exception, or null if there is none.
+ */
+public Throwable getCause() {
+return exception;
+}
}
\ No newline at end of file
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36261. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36261 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2005-08-18 22:54 --- wait a sec ...let's discuss that on the list first. while I agree that it makes sense to remove the counting from the problem handler interface I am not too sure I like the other changes too much. We could also make use of a factory pattern here. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Bug 36261] - [jci] no class could be loaded after a compilation error occured
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261 wait a sec ...let's discuss that on the list first. while I agree that it makes sense to remove the counting from the problem handler interface I am not too sure I like the other changes too much. We could also make use of a factory pattern here. And instead of a CPHandler instance you pass a CPHandlerFactory? Sounds good. Joerg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36266] New: - [math][patch] Update ComplexUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36266.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=36266
Summary: [math][patch] Update ComplexUtils.java
Product: Commons
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P1
Component: Math
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]
Index: ComplexUtils.java
===
--- ComplexUtils.java (revision 233396)
+++ ComplexUtils.java (working copy)
@@ -216,7 +216,10 @@
double a = z.getReal();
double b = z.getImaginary();
-
+if (a == 0.0 b == 0.0) {
+return new Complex(0.0, 0.0);
+}
+
double t = Math.sqrt((Math.abs(a) + z.abs()) / 2.0);
if (a = 0.0) {
return new Complex(t, b / (2.0 * t));
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36266] - [math][patch] Update ComplexUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36266. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36266 --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 01:30 --- add zero checks to sqrt() -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36266] - [math][patch] Update ComplexUtils.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36266. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36266 --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 01:30 --- Created an attachment (id=16107) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16107action=view) ComplexUtils.java -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [validator] Towards a release
If I remember right, 1.2 (HEAD) includes form inheritance which wasn't widely tested. Niall might remember more details. I think releasing 1.2.0 from HEAD would be fine so we don't have to go through the error prone process of maintaining two branches. Thanks for picking up the Validator torch! David --- Don Brown [EMAIL PROTECTED] wrote: I'd like to get a release of commons-validator out the door, as Struts 1.3 would like to use some of its new bug fixes and features. I'm pretty new to validator, so I'm not familar with its history. Any reason we haven't released 1.2? In the past when I fixed bugs, folks backported them to the 1.1.x branch; why not just roll 1.2 or at least roll it in addition to a bug fix release for 1.1.x? There are a couple more validator open bugs that I can sew up, if I saw a release as a near-term possibility. LMK, thanks, Don Get Firefox! http://www.mozilla.org/firefox/ Start your day with Yahoo! - make it your home page http://www.yahoo.com/r/hs - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36233] - [math][patch] Solver Source Files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36233 --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 04:37 --- Add MullerSolver.java Add MullerSolverTest.java -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36233] - [math][patch] Solver Source Files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36233 --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 04:38 --- Created an attachment (id=16108) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16108action=view) MullerSolver.java -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36233] - [math][patch] Solver Source Files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36233 --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 04:43 --- Created an attachment (id=16109) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16109action=view) MullerSolverTest.java -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233412 - in /jakarta/commons/proper/math/branches/MATH_1_1: src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java xdocs/changes.xml
Author: brentworden
Date: Thu Aug 18 20:14:16 2005
New Revision: 233412
URL: http://svn.apache.org/viewcvs?rev=233412view=rev
Log:
PR 36215: Added upper tail cumulative probability method to
HypergeometricDistributionImpl. Note, this new method was not added to the
HypergeometricDistribution interface to avoid binary incompatiblities with
older versions.
Modified:
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java
jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml
Modified:
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java?rev=233412r1=233411r2=233412view=diff
==
---
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java
(original)
+++
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/distribution/HypergeometricDistributionImpl.java
Thu Aug 18 20:14:16 2005
@@ -18,7 +18,6 @@
import java.io.Serializable;
-import org.apache.commons.math.MathException;
import org.apache.commons.math.util.MathUtils;
/**
@@ -54,7 +53,8 @@
super();
if (numberOfSuccesses populationSize) {
throw new IllegalArgumentException(
-number of successes must be less than or equal to population
size);
+ number of successes must be less than or equal to +
+ population size);
}
if (sampleSize populationSize) {
throw new IllegalArgumentException(
@@ -69,10 +69,8 @@
* For this disbution, X, this method returns P(X le; x).
* @param x the value at which the PDF is evaluated.
* @return PDF for this distribution.
- * @throws MathException if the cumulative probability can not be
- *computed due to convergence or other numerical errors.
*/
-public double cumulativeProbability(int x) throws MathException{
+public double cumulativeProbability(int x) {
double ret;
int n = getPopulationSize();
@@ -84,11 +82,10 @@
ret = 0.0;
} else if(x = domain[1]) {
ret = 1.0;
+} else if (x - domain[0] domain[1] - x) {
+ret = lowerCumulativeProbability(domain[0], x, n, m, k);
} else {
-ret = 0.0;
-for (int i = domain[0]; i = x; ++i){
-ret += probability(n, m, k, i);
-}
+ ret = 1.0 - upperCumulativeProbability(x + 1, domain[1], n, m,
k);
}
return ret;
@@ -182,6 +179,28 @@
}
/**
+ * For this disbution, X, this method returns P(x0 le; X le; x1). This
+ * probability is computed by summing the point probabilities for the
values
+ * x0, x0 + 1, x0 + 2, ..., x1, in that order.
+ * @param x0 the inclusive, lower bound
+ * @param x1 the inclusive, upper bound
+ * @param n the population size.
+ * @param m number of successes in the population.
+ * @param k the sample size.
+ * @return P(x0 le; X le; x1).
+ */
+private double lowerCumulativeProbability(
+int x0, int x1, int n, int m, int k)
+{
+ double ret;
+ ret = 0.0;
+ for (int i = x0; i = x1; ++i) {
+ ret += probability(n, m, k, i);
+ }
+ return ret;
+ }
+
+/**
* For this disbution, X, this method returns P(X = x).
*
* @param x the value at which the PMF is evaluated.
@@ -203,7 +222,7 @@
return ret;
}
-
+
/**
* For the disbution, X, defined by the given hypergeometric distribution
* parameters, this method returns P(X = x).
@@ -219,7 +238,7 @@
MathUtils.binomialCoefficientLog(n - m, k - x) -
MathUtils.binomialCoefficientLog(n, k));
}
-
+
/**
* Modify the number of successes.
* @param num the new number of successes.
@@ -245,8 +264,8 @@
}
populationSize = size;
}
-
-/**
+
+ /**
* Modify the sample size.
* @param size the new sample size.
* @throws IllegalArgumentException if codesize/code is negative.
@@ -258,4 +277,52 @@
}
sampleSize = size;
}
+
+/**
+ * For this disbution, X, this method returns P(X ge; x).
+ * @param x the value at which the CDF is evaluated.
+ * @return upper tail CDF for this distribution.
+ */
+ public double upperCumulativeProbability(int x) {
+ double ret;
+
+int n = getPopulationSize();
+int m =
DO NOT REPLY [Bug 36215] - [Math] HypergeometricDistributionImpl cumulativeProbability calculation overflown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36215. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36215 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 05:16 --- Addressed. SVN revision 233412. Committed to MATH_1_1 branch. Added upper tail cumulative probability method to HypergeometricDistributionImpl. Note, this new method was not added to the HypergeometricDistribution interface to avoid binary incompatiblities with older versions. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233427 - in /jakarta/commons/sandbox/exec/trunk/src: bin/ main/java/org/apache/commons/exec/ main/java/org/apache/commons/exec/launcher/ test/java/org/apache/commons/exec/
Author: brett
Date: Thu Aug 18 21:07:50 2005
New Revision: 233427
URL: http://svn.apache.org/viewcvs?rev=233427view=rev
Log:
PR: 36159
remove support for Java 1.1 to simplify
Removed:
jakarta/commons/sandbox/exec/trunk/src/bin/
Modified:
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Exec.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Execute.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/ProcessDestroyer.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherFactory.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherImpl.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/CommandLauncherProxy.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/Java11CommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/Java13CommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/MacCommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/OS2CommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/PerlScriptCommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/ScriptCommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/VmsCommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/launcher/WinNTCommandLauncher.java
jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/TestUtil.java
Modified:
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Exec.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Exec.java?rev=233427r1=233426r2=233427view=diff
==
---
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Exec.java
(original)
+++
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Exec.java
Thu Aug 18 21:07:50 2005
@@ -46,11 +46,6 @@
private boolean incompatibleWithSpawn = false;
-/**
- * Controls whether the VM (1.3 and above) is used to execute the command.
- */
-private boolean vmLauncher = true;
-
public Exec() {
// default cnstr
}
@@ -300,18 +295,6 @@
*/
/**
- * Sets a flag indicating if we want to launch new process with VM,
- * otherwise use the OS's shell. Default value of the flag is true.
- *
- * @param vmLauncher
- *true if we want to launch new process with VM, false if we
- *want to use the OS's shell.
- */
-public void setVMLauncher(final boolean vmLauncher) {
-this.vmLauncher = vmLauncher;
-}
-
-/**
* Create an Execute instance with the correct working directory set.
*
* @param error
@@ -339,7 +322,6 @@
createWatchdog());
exe.setWorkingDirectory(dir);
-exe.setVMLauncher(vmLauncher);
exe.setNewEnvironment(newEnvironment);
exe.setEnvironment(env.getVariables());
Modified:
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Execute.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Execute.java?rev=233427r1=233426r2=233427view=diff
==
---
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Execute.java
(original)
+++
jakarta/commons/sandbox/exec/trunk/src/main/java/org/apache/commons/exec/Execute.java
Thu Aug 18 21:07:50 2005
@@ -52,17 +52,11 @@
private boolean newEnvironment = false;
-/** Controls whether the VM is used to launch commands, where possible */
-private boolean useVMLauncher = true;
-
private static String userWorkingDirectory =
System.getProperty(user.dir);
private static CommandLauncher vmLauncher = CommandLauncherFactory
.createVMLauncher();
-private static CommandLauncher shellLauncher = CommandLauncherFactory
-.createShellLauncher();
-
/** Used to destroy processes when the VM exits. */
private static ProcessDestroyer processDestroyer = new ProcessDestroyer();
@@ -212,20 +206,6 @@
}
/**
- * Launch this execution through the VM, where possible, rather than
through
- * the OS's shell. In some cases and operating systems using the shell will
-
DO NOT REPLY [Bug 36181] - [exec][patch] ant get-deps target fails to download dependency
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36181. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36181 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233428 - /jakarta/commons/sandbox/exec/trunk/build.xml
Author: brett
Date: Thu Aug 18 21:10:51 2005
New Revision: 233428
URL: http://svn.apache.org/viewcvs?rev=233428view=rev
Log:
PR: 36181
make the directory for the artifact before downloading
also filed MNG-749 to later correct the ant script generation
Modified:
jakarta/commons/sandbox/exec/trunk/build.xml
Modified: jakarta/commons/sandbox/exec/trunk/build.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/build.xml?rev=233428r1=233427r2=233428view=diff
==
--- jakarta/commons/sandbox/exec/trunk/build.xml (original)
+++ jakarta/commons/sandbox/exec/trunk/build.xml Thu Aug 18 21:10:51 2005
@@ -71,7 +71,7 @@
/condition
/target
target name=get-deps depends=test-offline description=Download all
dependencies unless=maven.mode.offline
-mkdir dir=${maven.repo.local}/
+mkdir
dir=${maven.repo.local}/commons-logging/commons-logging-api/1.0.4//
get
src=http://repo1.maven.org/maven2/commons-logging/commons-logging-api/1.0.4/commons-logging-api-1.0.4.jar;
dest=${maven.repo.local}/commons-logging/commons-logging-api/1.0.4/commons-logging-api-1.0.4.jar
usetimestamp=true ignoreerrors=true/
/target
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233429 - /jakarta/commons/sandbox/exec/trunk/build.xml
Author: brett
Date: Thu Aug 18 21:16:08 2005
New Revision: 233429
URL: http://svn.apache.org/viewcvs?rev=233429view=rev
Log:
PR: 36183
add destination for test reports
Modified:
jakarta/commons/sandbox/exec/trunk/build.xml
Modified: jakarta/commons/sandbox/exec/trunk/build.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/build.xml?rev=233429r1=233428r2=233429view=diff
==
--- jakarta/commons/sandbox/exec/trunk/build.xml (original)
+++ jakarta/commons/sandbox/exec/trunk/build.xml Thu Aug 18 21:16:08 2005
@@ -49,7 +49,7 @@
pathelement location=${maven.build.output}/
pathelement location=${maven.test.output}/
/classpath
- batchtest
+ batchtest todir=${maven.test.reports}
fileset dir=src/test/java
include name=**/*Test.java/
exclude name=**/*Abstract*Test.java/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36183] - [exec][patch] make ant stores junit test reports in correct directory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36183. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36183 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 06:16 --- applied, thanks -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r233430 - in /jakarta/commons/sandbox/exec/trunk/src/test: java/org/apache/commons/exec/ExecTest.java scripts/test.bat scripts/test.sh
Author: brett
Date: Thu Aug 18 21:20:31 2005
New Revision: 233430
URL: http://svn.apache.org/viewcvs?rev=233430view=rev
Log:
use a non-collapsable character for testing
Modified:
jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/ExecTest.java
jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.bat
jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.sh
Modified:
jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/ExecTest.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/ExecTest.java?rev=233430r1=233429r2=233430view=diff
==
---
jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/ExecTest.java
(original)
+++
jakarta/commons/sandbox/exec/trunk/src/test/java/org/apache/commons/exec/ExecTest.java
Thu Aug 18 21:20:31 2005
@@ -41,7 +41,7 @@
exec.execute(cl, baos, baos);
-assertEquals(FOO, baos.toString().trim());
+assertEquals(FOO.., baos.toString().trim());
}
public void testExecuteWithArg() throws Exception {
@@ -52,7 +52,7 @@
cl.addArgument(BAR);
exec.execute(cl, baos, baos);
-assertEquals(FOO BAR, baos.toString().trim());
+assertEquals(FOO..BAR, baos.toString().trim());
}
public void testExecuteWithEnv() throws Exception {
@@ -66,7 +66,7 @@
exec.execute(cl, env, baos, baos);
-assertEquals(FOO XYZ, baos.toString().trim());
+assertEquals(FOO.XYZ., baos.toString().trim());
}
protected void tearDown() throws Exception {
Modified: jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.bat
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.bat?rev=233430r1=233429r2=233430view=diff
==
--- jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.bat (original)
+++ jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.bat Thu Aug 18
21:20:31 2005
@@ -16,4 +16,4 @@
REM
REM
[EMAIL PROTECTED] FOO %TEST_ENV_VAR% %1
\ No newline at end of file
[EMAIL PROTECTED] FOO.%TEST_ENV_VAR%.%1
Modified: jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.sh
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.sh?rev=233430r1=233429r2=233430view=diff
==
--- jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.sh (original)
+++ jakarta/commons/sandbox/exec/trunk/src/test/scripts/test.sh Thu Aug 18
21:20:31 2005
@@ -17,4 +17,4 @@
#
#
-echo FOO $TEST_ENV_VAR $1
\ No newline at end of file
+echo FOO.$TEST_ENV_VAR.$1
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36182] - [exec][patch] ExecTest fails due to improperly formatted src/test/scripts/test.sh
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36182. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36182 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Summary|[exec][patch] ExecTest fails|[exec][patch] ExecTest fails |due to improperly formatted |due to improperly formatted |src/test/scripts/test.sh|src/test/scripts/test.sh --- Additional Comments From [EMAIL PROTECTED] 2005-08-19 06:20 --- changed to use '.' as it is more obvious -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
