DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-10-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36261


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-10-10 01:15 ---
After the refactoring this bug is no longer valid.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-10-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36261


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-23 Thread Joerg Heinicke
 Any suggestion how to handle that otherwise?

Continueing this topic in the other thread 'Handling compilation errors':
http://marc.theaimsgroup.com/?t=11245564832r=1w=4

Joerg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-19 Thread Joerg Heinicke
  http://issues.apache.org/bugzilla/show_bug.cgi?id=36261
  
  wait a sec ...let's discuss that on the list first.
  while I agree that it makes sense to remove
  the counting from the problem handler interface
  I am not too sure I like the other changes too much.

Off-list you talked about possibly introducing a lifecycle to the
CompilationProblemHandler. IMO their purpose is to different to get a common
lifecycle. Many purposes do not even need a lifecycle at all (e.g. logging the
compilation problems, or (as in my adapter to XSP) delegating the problem to
Cocoon. The so-called CompilationProblemCounter (in the patch) is a special case
for the CompilingListener, so the CL should also care about its lifecycle, not
the compilers. There are even other lifecycles conceivable - shall the compilers
manage all of them? I have the Avalon interfaces in mind ... ;-)

At the end this means I like the idea of having a most simple
CompilationProblemHandler interface with just the one method (also as in the
DiagnosticListener of JSR 199). The classes registering the handlers have to
care about the rest, they know their purpose.

Remains the question of passing the handlers to the compilers. Passing a factory
is not possible I think as the registering classes might need access to the
handlers like the CompilingListener needs to reset the error counter. At the end
I come back to my patch - with details debatable of course ;-)

WDYT?

Joerg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36261





--- Additional Comments From [EMAIL PROTECTED]  2005-08-18 22:32 ---
Created an attachment (id=16106)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16106action=view)
Patch to CompilationProblemHandler stuff.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36261





--- Additional Comments From [EMAIL PROTECTED]  2005-08-18 22:47 ---
The tests do not compile at the moment, but patch will follow.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36261.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36261


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-08-18 22:54 ---
wait a sec ...let's discuss that on the list first.
while I agree that it makes sense to remove
the counting from the problem handler interface
I am not too sure I like the other changes too much.

We could also make use of a factory pattern here.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [Bug 36261] - [jci] no class could be loaded after a compilation error occured

2005-08-18 Thread Joerg Heinicke
 http://issues.apache.org/bugzilla/show_bug.cgi?id=36261
 
 wait a sec ...let's discuss that on the list first.
 while I agree that it makes sense to remove
 the counting from the problem handler interface
 I am not too sure I like the other changes too much.
 
 We could also make use of a factory pattern here.

And instead of a CPHandler instance you pass a CPHandlerFactory?

Sounds good.

Joerg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]