[jira] Commented: (TRANSACTION-11) Improve relationship between ResourceManager and FileResourceManager
[ https://issues.apache.org/jira/browse/TRANSACTION-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512958 ] Jörg Heinicke commented on TRANSACTION-11: -- Yes, the two methods should definitely be added to the interface(s). I haven't had a look on the new stuff so I don't know exactly where they have to be added to. If there is a TransactionManager interface it should have the setDefaultTransactionTimeout(long) method. If there is a ResourceManager and reset() is of general use (which I'd assume if there is an implementation for FileResourceManager) reset() has to be added to that interface. Improve relationship between ResourceManager and FileResourceManager Key: TRANSACTION-11 URL: https://issues.apache.org/jira/browse/TRANSACTION-11 Project: Commons Transaction Issue Type: Improvement Affects Versions: 1.1 Reporter: Jeremy Fujimoto-Johnson Assignee: Jörg Heinicke Fix For: 2.0 Attachments: commons-transaction-rm-patch.txt Add the reset method to ResourceManager so that classes using a ResourceManager won't have to cast it to FileResourceManager to call this method. Add new constructors to FileResourceManager so that it can be constructed with the default timeout period for transactions already specified so that you don't have to cast to FileResourceManager to set it later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-11) Improve relationship between ResourceManager and FileResourceManager
[ https://issues.apache.org/jira/browse/TRANSACTION-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512566 ] Oliver Zeigermann commented on TRANSACTION-11: -- Is this still valid for 2.0? Improve relationship between ResourceManager and FileResourceManager Key: TRANSACTION-11 URL: https://issues.apache.org/jira/browse/TRANSACTION-11 Project: Commons Transaction Issue Type: Improvement Affects Versions: 1.1 Reporter: Jeremy Fujimoto-Johnson Assignee: Jörg Heinicke Fix For: 2.0 Attachments: commons-transaction-rm-patch.txt Add the reset method to ResourceManager so that classes using a ResourceManager won't have to cast it to FileResourceManager to call this method. Add new constructors to FileResourceManager so that it can be constructed with the default timeout period for transactions already specified so that you don't have to cast to FileResourceManager to set it later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-11) Improve relationship between ResourceManager and FileResourceManager
[ http://issues.apache.org/jira/browse/TRANSACTION-11?page=comments#action_12425218 ] Jörg Heinicke commented on TRANSACTION-11: -- I don't like the idea of adding getters and setters to interfaces, but as the corresponding getter getDefaultTransactionTimeout() does already exist, I'm ok with adding the setter as well. Adding reset() makes sense for me. BTW, in association with your changes what do you think of my suggested changes at http://marc.theaimsgroup.com/?t=11528064431r=1w=4 (please respond on the mailing list as it is quite off-topic here)? I don't know Slide's usage FileResourceManager yet. Improve relationship between ResourceManager and FileResourceManager Key: TRANSACTION-11 URL: http://issues.apache.org/jira/browse/TRANSACTION-11 Project: Commons Transaction Issue Type: Improvement Affects Versions: 1.1, 1.2 Reporter: Jeremy Fujimoto-Johnson Assigned To: Oliver Zeigermann Attachments: commons-transaction-rm-patch.txt Add the reset method to ResourceManager so that classes using a ResourceManager won't have to cast it to FileResourceManager to call this method. Add new constructors to FileResourceManager so that it can be constructed with the default timeout period for transactions already specified so that you don't have to cast to FileResourceManager to set it later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-11) Improve relationship between ResourceManager and FileResourceManager
[ http://issues.apache.org/jira/browse/TRANSACTION-11?page=comments#action_12425272 ] Jeremy Fujimoto-Johnson commented on TRANSACTION-11: Actually, in the attached patch there isn't a setDefaultTransactionTimeout() method added to the ResourceManager interface. But that solution would meet my needs as well. I can see that that there would be an advantage in not making as big of a change as adding new constructors to FileResourceManager. Improve relationship between ResourceManager and FileResourceManager Key: TRANSACTION-11 URL: http://issues.apache.org/jira/browse/TRANSACTION-11 Project: Commons Transaction Issue Type: Improvement Affects Versions: 1.1, 1.2 Reporter: Jeremy Fujimoto-Johnson Assigned To: Oliver Zeigermann Attachments: commons-transaction-rm-patch.txt Add the reset method to ResourceManager so that classes using a ResourceManager won't have to cast it to FileResourceManager to call this method. Add new constructors to FileResourceManager so that it can be constructed with the default timeout period for transactions already specified so that you don't have to cast to FileResourceManager to set it later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-11) Improve relationship between ResourceManager and FileResourceManager
[ http://issues.apache.org/jira/browse/TRANSACTION-11?page=comments#action_12424899 ] Jeremy Fujimoto-Johnson commented on TRANSACTION-11: I apologize for marking this issue with too high of a priority. I just took the default and didn't pay enough attention. However, on the second point: the reason I want this change is that I am implementing another implementation of ResourceManager. I want to be able to switch between FileResourceManager and my new implementation by configuration for use in the Slide project. It would be significantly easier for me to do so if FileResourceManager implemented an interface that could be used as the type referenced in AbstractTxFileStoreService and XMLResourceDescriptor. Fortunately there almost is one: ResourceManager. Unfortunately there are two methods used that aren't part of the ResourceManager interface: setDefaultTransactoinTimeout and reset. Thus my patch. Now my new implementation of ResourceManager and FileResourceManager can each be used in Slide. Improve relationship between ResourceManager and FileResourceManager Key: TRANSACTION-11 URL: http://issues.apache.org/jira/browse/TRANSACTION-11 Project: Commons Transaction Issue Type: Improvement Affects Versions: 1.1, 1.2 Reporter: Jeremy Fujimoto-Johnson Assigned To: Oliver Zeigermann Attachments: commons-transaction-rm-patch.txt Add the reset method to ResourceManager so that classes using a ResourceManager won't have to cast it to FileResourceManager to call this method. Add new constructors to FileResourceManager so that it can be constructed with the default timeout period for transactions already specified so that you don't have to cast to FileResourceManager to set it later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
