DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-02-18 05:42 --- Hi Kurt, After further thought, I think you're right. The old behaviour is just a bug, so a change in behaviour is ok, not an incompatibility. I've committed your patch. Thanks very much for your contribution - and your patience! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2006-02-08 04:41 --- Hi Kurt, Sorry this issue has been open so long. I'll try to get around to addressing this in the next couple of days. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2006-02-02 15:45 --- About three months ago I created this patch and a test case. Please let me know the status of this bug. Thank you, Kurt. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-10-24 16:26 --- (In reply to comment #4) Probably worth creating a unit test for the case where there is no namespace, though. I took the liberty of creating that test case. I ran it against the previous version of the code and the code with my updates. The non-namespaced attribute test works with both, proving that the current functionality of handling non-namespaced attributes has not changed. Let me know if I can do anything else to help get this change commited. Thanks, Kurt -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #16490|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2005-10-24 16:33 --- Created an attachment (id=16790) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16790action=view) Updated Patch with additonal Test Case (Replaces the original patch) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-10-22 12:50 --- Digester2 is mostly my work, with some input from others. I'm one of the main maintainers of digester1 (along with Robert Donkin). Of about a dozen significant changes from digester1 planned, approximately half have been done. There's still quite a bit of work to do, though, before it's a functional product. If you are interested please start an email thread on the commons-dev email list rather than commenting here as this bugreport is not the right venue for that discussion. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-10-22 00:11 --- You are quite right that Digester's general handling of namespaces is very poor. This is acknowledged in the package.html file for digester. However there is no way to fix this across the whole app without major binary incompatibilities, and we just can't break that many users. You can find the digester2 project in subversion: http://svn.apache.org/repos/asf/jakarta/commons/proper/digester/branches/digester2/ Because this uses the package name org.apache.commons.digester2, it can happily co-exist with digester1. It is intended to fix many issues with the digester1 design, including the namespaces one. However I don't currently have much time to work on digester2, and there isn't anyone else actively moving it forward. So if you need robust namespace support right now, unfortunately you will need to use something other than Digester. The specific namespace problem you originally raised in this bugrequest is somehting we should think about, as Robert indicated. Hopefully Robert or I will get around to this soon, but unfortunately we're both very busy people right now and as noted this is a little tricky from a backwards-compatibility viewpoint :-(. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-10-22 01:09 --- Ok, who created digester2 it and what state is it in? How can you add me to commit for that branch? My apache username is kevinross. I just determined that my CLA is not on file so it will be a few days before I can begin contributing directly to svn. Please let me know, I have several projects that require this functionality that are active. I have a team of four working an them, so I feel confident that there will be several contributions and I can screen them. Thanks, Kevin -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-10-20 19:13 --- The fact that the digester allows for loose interpretation of the standard does support: 1. old parsers 2. developers lacking knowledge about proper use of namespaces. If we want to maintain backward support for incorrect behavior, then that is fine, make it the exception, not the rule. Incorrect behavior SHOULD break. Don't discourage forward progress and use of the digester for modern purposes because people want to use what is actually buggy software in terms of the new specs or modern parsers. This leads to nothing but confusion, and now stands as a barrier to adoption for those who want to start using it but cannot get it to work. I understand how we got here, and thats ok. We have to move forward. I believe the solution is: 1. commit the code, it is correct 2. allow the code to be incompatible with previous versions. For those who want to stay at a historical point in time, the maven repository has all releases There are even more changes that I've run across that I've been hesitant to change, and it is to the point that either the digester fully understands namespaces or I need to find a new project that will do the same thing. I just need something that exhibits behavior that is concurrent with the standards and understand namespaces. -Kevin (In reply to comment #4) Hi Kurt Please understand's not quite as simple as that. 1. Digester is used extensively where loosy binding is perfectly accceptable. 2. Digester is old and flexible enough to have to worry about maintaining compatibility with parsers which are not namespace aware. However, in this case I've taken a look at the DOM specification and believe that the passage of code in question is just buggy. DOM expects the qualified (and not the local) name. I suspect that this is so that it can extract the prefix for it's own uses. My reading of the API implies that the Element parses the qualified name to extract the local name itself. Therefore, applying this patch should not change the existing behaviour and so will do no harm. Probably worth creating a unit test for the case where there is no namespace, though. Opinions? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-09-29 20:51 --- Hi Kurt Please understand's not quite as simple as that. 1. Digester is used extensively where loosy binding is perfectly accceptable. 2. Digester is old and flexible enough to have to worry about maintaining compatibility with parsers which are not namespace aware. However, in this case I've taken a look at the DOM specification and believe that the passage of code in question is just buggy. DOM expects the qualified (and not the local) name. I suspect that this is so that it can extract the prefix for it's own uses. My reading of the API implies that the Element parses the qualified name to extract the local name itself. Therefore, applying this patch should not change the existing behaviour and so will do no harm. Probably worth creating a unit test for the case where there is no namespace, though. Opinions? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-09-28 14:30 --- I disagree. Although digester usage is widespread, I doubt namespaced attributes being digested is used at all since it doesn't work. If anyone was trying to use namespaced attributes with the digester in the past, they would have abandoned the cause. I can't imagine a scenario where someone would have just accepted the behavior as good enough and continued to use namespaced attributes even though they get lost as they are digested and can't be re-serialized as XML. Since that would have caused everyone to use non-namespaced attributes, they won't notice a difference because local-name and qualified-name are the same in that case. Thanks, Kurt (In reply to comment #2) Looks correct to me. The only potential issue is that this will change the existing behaviour of digester. Formerly, calling getName on the attribute would return the localname part. After this fix it would return the qualified name, which is correct. But this *could* break existing applications. Does anyone think this breakage is a significant problem? If so, we could add some kind of flag on the Digester class to select the old (wrong) or new (right) behaviour, at least for a release or two, eg: Digester.setRetainAttributePrefixes(boolean) which would default to false (the old behaviour). I personally think this would be wise; digester usage is fairly widely spread so incompatible changes can cause significant grief. Regards, Simon -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-09-25 06:01 --- Looks correct to me. The only potential issue is that this will change the existing behaviour of digester. Formerly, calling getName on the attribute would return the localname part. After this fix it would return the qualified name, which is correct. But this *could* break existing applications. Does anyone think this breakage is a significant problem? If so, we could add some kind of flag on the Digester class to select the old (wrong) or new (right) behaviour, at least for a release or two, eg: Digester.setRetainAttributePrefixes(boolean) which would default to false (the old behaviour). I personally think this would be wise; digester usage is fairly widely spread so incompatible changes can cause significant grief. Regards, Simon -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 36773] - [digester] [PATCH] NodeCreateRule does not correctly handle namespaced attributes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36773. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36773 --- Additional Comments From [EMAIL PROTECTED] 2005-09-22 18:41 --- Created an attachment (id=16490) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=16490action=view) patch in diff -u format -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
