DO NOT REPLY [Bug 39534] - [scxml] External Digester does not addCustomActions

2006-05-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39534.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39534





--- Additional Comments From [EMAIL PROTECTED]  2006-05-10 20:04 ---
That will definitely be a larger change for the users, but also conceptually, 
since the custom actions are meant to be in other XML namespaces, the approach 
used is similar to how Mozilla does XTF for its plugins (you define a backing 
bean for each element in the namespace). If we take the POJO approach, then it 
does imply higher reflection overheads (at runtime, reflection is our bread-n-
butter at parsing time) and is probably strange as an XML namespace. After 
all, the actions are called custom actions since their utility and 
implementation preferences are subjective.

As a library, Commons SCXML provides opportunities to customize most of its 
internals, be it parsing, custom actions or engine semantics. Together, these 
should allow users to build atop with their ideas (and the useful ones can 
hopefully come back in to Commons SCXML). There is only so much that will come 
out of the box, especially for the first release. I have some cleanup done 
that fixes this issue about not parsing custom actions in src'ed in 
documents, but the repository seems down ATM.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39534] - [scxml] External Digester does not addCustomActions

2006-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39534.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39534


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Summary|External Digester does not  |[scxml] External Digester
   |addCustomActions|does not addCustomActions




--- Additional Comments From [EMAIL PROTECTED]  2006-05-09 21:53 ---
Indeed, the approach to adding custom actions after calling newInstance() on 
the digester does not address the case where the external documents pulled in 
contain custom actions. It seems best to take this opportunity to refactor a 
couple of related bits in the SCXMLDigester related to custom action parsing.

Thanks for reporting this, I'll take a look later tonight.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39534] - [scxml] External Digester does not addCustomActions

2006-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39534.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39534





--- Additional Comments From [EMAIL PROTECTED]  2006-05-09 22:50 ---
I think that this approach is weird if nothing else ;)
I guess a cleaner approach would be to go the Xalan way, either have an entity
resolver to find out the mapping or support java: namespace,
the second would be a lot more easier/intuitive to use.
in my example I would have used
xmlns:hello=java://com.mycompany.customactions.Hello
instead of the 
xmlns:hello=http://some.bakar.com/HELLO;
Which does not serve any purpose at all!!
hello:sayhi would call Hello.sayhi

However, doing this would mean a lot of change, also, it will mean that the old
code where ppl implemented SayHi.class to say a hi will be deprecated (Though
not broken, they should still be able to do what they do, only the java:
namespace can have this semantic)

Anyways, this was just my thought. 
(In reply to comment #1)
 Indeed, the approach to adding custom actions after calling newInstance() on 
 the digester does not address the case where the external documents pulled in 
 contain custom actions. It seems best to take this opportunity to refactor a 
 couple of related bits in the SCXMLDigester related to custom action parsing.
 
 Thanks for reporting this, I'll take a look later tonight.
 
 



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]