[jira] [Updated] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erlend Garåsen updated CONNECTORS-430: -- Attachment: CONNECTORS-430.patch Adds an error message with a list of invalid URLs in the seeds list, based on JavaScript. An error should be returned if invalid seeds are typed into the seeds list for the web connector Key: CONNECTORS-430 URL: https://issues.apache.org/jira/browse/CONNECTORS-430 Project: ManifoldCF Issue Type: Improvement Components: Web connector Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3, ManifoldCF 0.4, ManifoldCF 0.5 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Priority: Minor Fix For: ManifoldCF 0.6 Attachments: CONNECTORS-430.patch If you create a job for the web connector and enter an invalid URL into the seeds list, any value is accepted. An error message should be returned to the user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erlend Garåsen updated CONNECTORS-430: -- Status: Patch Available (was: Open) I have created a patch which adds URL validation to the seeds list. The regular expression for URL validation is not perfect, but IP addresses and localhosts are accepted in addition to domains. If it looks ok, I can committ my changes with Japaneese translation of the error message as well. An error should be returned if invalid seeds are typed into the seeds list for the web connector Key: CONNECTORS-430 URL: https://issues.apache.org/jira/browse/CONNECTORS-430 Project: ManifoldCF Issue Type: Improvement Components: Web connector Affects Versions: ManifoldCF 0.4, ManifoldCF 0.3, ManifoldCF 0.2, ManifoldCF 0.1, ManifoldCF 0.5 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Priority: Minor Fix For: ManifoldCF 0.6 Attachments: CONNECTORS-430.patch If you create a job for the web connector and enter an invalid URL into the seeds list, any value is accepted. An error message should be returned to the user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235765#comment-13235765 ] Karl Wright commented on CONNECTORS-430: Hi Erlend, All looks good except the check for editjob.seeds == undefined. That's not supported. The whole conditional should be unneeded because there is always a editjobs.seeds.value available, either as a hidden or as a text box. An error should be returned if invalid seeds are typed into the seeds list for the web connector Key: CONNECTORS-430 URL: https://issues.apache.org/jira/browse/CONNECTORS-430 Project: ManifoldCF Issue Type: Improvement Components: Web connector Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3, ManifoldCF 0.4, ManifoldCF 0.5 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Priority: Minor Fix For: ManifoldCF 0.6 Attachments: CONNECTORS-430.patch If you create a job for the web connector and enter an invalid URL into the seeds list, any value is accepted. An error message should be returned to the user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-432) Quotation marks in translated messages should be removed
Quotation marks in translated messages should be removed Key: CONNECTORS-432 URL: https://issues.apache.org/jira/browse/CONNECTORS-432 Project: ManifoldCF Issue Type: Task Components: Framework core Affects Versions: ManifoldCF 0.4 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Fix For: ManifoldCF 0.6 Quotation marks exist in some translated messages, e.g. in common_en_US.properties for the Web Connector. These should be removed and added elsewhere. An example: editjob.ExpirationIntervalMustBeAValidIntegerOrNull=Expiration interval must be a valid integer or null The quotation marks should in the example above be placed in the JSP file instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235781#comment-13235781 ] Erlend Garåsen commented on CONNECTORS-430: --- bq. The whole conditional should be unneeded because there is always a editjobs.seeds.value available, either as a hidden or as a text box. I'm afraid not, and that's the reason why I added this check. Sorry, I thought it was the typeof function that wasn't supported by the browser simulator. Anyway, I'll double-check the requirement for this check later. If it's required, I'll add the necessary hidden element instead. An error should be returned if invalid seeds are typed into the seeds list for the web connector Key: CONNECTORS-430 URL: https://issues.apache.org/jira/browse/CONNECTORS-430 Project: ManifoldCF Issue Type: Improvement Components: Web connector Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3, ManifoldCF 0.4, ManifoldCF 0.5 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Priority: Minor Fix For: ManifoldCF 0.6 Attachments: CONNECTORS-430.patch If you create a job for the web connector and enter an invalid URL into the seeds list, any value is accepted. An error message should be returned to the user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[
https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235805#comment-13235805
]
Karl Wright commented on CONNECTORS-430:
bq. I'm afraid not...
All tabs are coded so that either the displayed form element is output, or
instead a corresponding hidden is output. The web connector's tabs are no
different. The code is:
{code}
if (tabName.equals(Messages.getString(locale,WebcrawlerConnector.Seeds)))
{
out.print(
table class=\displaytable\\n+
trtd class=\separator\ colspan=\2\hr//td/tr\n+
tr\n+
td class=\value\ colspan=\2\\n+
textarea rows=\25\ cols=\80\
name=\seeds\+org.apache.manifoldcf.ui.util.Encoder.bodyEscape(seeds)+/textarea\n+
/td\n+
/tr\n+
/table\n
);
}
else
{
out.print(
input type=\hidden\ name=\seeds\
value=\+org.apache.manifoldcf.ui.util.Encoder.attributeEscape(seeds)+\/\n
);
}
{code}
An error should be returned if invalid seeds are typed into the seeds list
for the web connector
Key: CONNECTORS-430
URL: https://issues.apache.org/jira/browse/CONNECTORS-430
Project: ManifoldCF
Issue Type: Improvement
Components: Web connector
Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3,
ManifoldCF 0.4, ManifoldCF 0.5
Reporter: Erlend Garåsen
Assignee: Erlend Garåsen
Priority: Minor
Fix For: ManifoldCF 0.6
Attachments: CONNECTORS-430.patch
If you create a job for the web connector and enter an invalid URL into the
seeds list, any value is accepted. An error message should be returned to the
user in order to prevent invalid seeds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[
https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235854#comment-13235854
]
Erlend Garåsen commented on CONNECTORS-430:
---
If I comment out the if check, I get the following error in my Error console
(Firefox):
{code}
Timestamp: 22.03.12 19.25.43
Error: editjob.seeds is undefined
Source File: http://localhost:8345/mcf-crawler-ui/editjob.jsp
Line: 243
{code}
This happens when I press the Connection tab just after I have named my new
job. I _think_ it is due to a missing hidden element, something I will figure
out tomorrow.
An error should be returned if invalid seeds are typed into the seeds list
for the web connector
Key: CONNECTORS-430
URL: https://issues.apache.org/jira/browse/CONNECTORS-430
Project: ManifoldCF
Issue Type: Improvement
Components: Web connector
Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3,
ManifoldCF 0.4, ManifoldCF 0.5
Reporter: Erlend Garåsen
Assignee: Erlend Garåsen
Priority: Minor
Fix For: ManifoldCF 0.6
Attachments: CONNECTORS-430.patch
If you create a job for the web connector and enter an invalid URL into the
seeds list, any value is accepted. An error message should be returned to the
user in order to prevent invalid seeds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-430) An error should be returned if invalid seeds are typed into the seeds list for the web connector
[ https://issues.apache.org/jira/browse/CONNECTORS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235897#comment-13235897 ] Karl Wright commented on CONNECTORS-430: Ah, I see the problem - you are putting your check in the main UI javascript, not in the javascript that the web connector is supposed to provide. You should be editing the method WebCrawlerConnector.outputSpecificationHeader(), not editing the UI JSP. So please don't commit this change in its current form. An error should be returned if invalid seeds are typed into the seeds list for the web connector Key: CONNECTORS-430 URL: https://issues.apache.org/jira/browse/CONNECTORS-430 Project: ManifoldCF Issue Type: Improvement Components: Web connector Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3, ManifoldCF 0.4, ManifoldCF 0.5 Reporter: Erlend Garåsen Assignee: Erlend Garåsen Priority: Minor Fix For: ManifoldCF 0.6 Attachments: CONNECTORS-430.patch If you create a job for the web connector and enter an invalid URL into the seeds list, any value is accepted. An error message should be returned to the user in order to prevent invalid seeds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-432) Quotation marks in translated messages should be removed
[ https://issues.apache.org/jira/browse/CONNECTORS-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright resolved CONNECTORS-432. Resolution: Fixed Assignee: Karl Wright (was: Erlend Garåsen) r1304095 Quotation marks in translated messages should be removed Key: CONNECTORS-432 URL: https://issues.apache.org/jira/browse/CONNECTORS-432 Project: ManifoldCF Issue Type: Task Components: Framework core Affects Versions: ManifoldCF 0.4 Reporter: Erlend Garåsen Assignee: Karl Wright Fix For: ManifoldCF 0.6 Quotation marks exist in some translated messages, e.g. in common_en_US.properties for the Web Connector. These should be removed and added elsewhere. An example: editjob.ExpirationIntervalMustBeAValidIntegerOrNull=Expiration interval must be a valid integer or null The quotation marks should in the example above be placed in the JSP file instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
