Re: [PATCH] gsupplicant: Do P2P detection after interface property load
Good news! Thanks, Tomasz. On Thu, Aug 7, 2014 at 7:43 AM, Tomasz Bursztyka wrote: > Hi Eduardo, > > Finally it seems possible for connman to sync up with wpa_supplicant and > existing interface > (see patch "[PATCH v2] device: Make sure the device is up and running before > enabling it" and logs > from Richard Röjfors http://pastebin.com/4Bsk5B2N ) > > So ACK to this patch! > > Tomasz > ___ > connman mailing list > connman@connman.net > https://lists.connman.net/mailman/listinfo/connman ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH] gsupplicant: Do P2P detection after interface property load
Hi Eduardo, Finally it seems possible for connman to sync up with wpa_supplicant and existing interface (see patch "[PATCH v2] device: Make sure the device is up and running before enabling it" and logs from Richard Röjfors http://pastebin.com/4Bsk5B2N ) So ACK to this patch! Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH v2] device: Make sure the device is up and running before enabling it
On Thu, Aug 7, 2014 at 11:05 AM, Tomasz Bursztyka <
tomasz.burszt...@linux.intel.com> wrote:
> It can happen that, after a unproper ConnMan exit, a device is still up.
> Once ConnMan is restarted cleanup_devices() will put this device down.
> But then, it will never set it up again.
>
> 04:08:45 connmand[254]: src/device.c:__connman_device_init()
> 04:08:45 connmand[254]: src/inet.c:__connman_inet_get_address_netmask()
> index 2
> 04:08:45 connmand[254]: src/device.c:cleanup_devices() cleaning up wlan0
> index 2
> (...)
> 04:08:45 connmand[254]: wlan0 {newlink} index 2 operstate 2
> (...)
> 04:08:45 connmand[254]: plugins/wifi.c:wifi_newlink() index 2 flags 36866
> change 0
> 04:08:45 connmand[254]: src/technology.c:__connman_technology_add_device()
> device 0x35e8a8 type WiFi
> 04:08:45 connmand[254]: src/technology.c:technology_get() type 3
> 04:08:45 connmand[254]: src/technology.c:technology_find() type 3
> 04:08:45 connmand[254]: src/device.c:__connman_device_enable() device
> 0x35e8a8
>
> Reported by Richard Röjfors
>
Ack from me, now connman can be restarted in my setup without leaving the
wifi interface down.
> ---
> src/device.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/device.c b/src/device.c
> index a97d790..1a5f0e6 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -185,6 +185,10 @@ int __connman_device_enable(struct connman_device
> *device)
> if (device->powered_pending == PENDING_NONE && device->powered)
> return -EALREADY;
>
> + err = connman_inet_ifup(device->index);
> + if (err < 0 && err != -EALREADY)
> + return err;
> +
> device->powered_pending = PENDING_ENABLE;
>
> err = device->driver->enable(device);
> --
> 1.8.5.5
>
> ___
> connman mailing list
> connman@connman.net
> https://lists.connman.net/mailman/listinfo/connman
>
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
[PATCH v2] device: Make sure the device is up and running before enabling it
It can happen that, after a unproper ConnMan exit, a device is still up.
Once ConnMan is restarted cleanup_devices() will put this device down.
But then, it will never set it up again.
04:08:45 connmand[254]: src/device.c:__connman_device_init()
04:08:45 connmand[254]: src/inet.c:__connman_inet_get_address_netmask() index 2
04:08:45 connmand[254]: src/device.c:cleanup_devices() cleaning up wlan0 index 2
(...)
04:08:45 connmand[254]: wlan0 {newlink} index 2 operstate 2
(...)
04:08:45 connmand[254]: plugins/wifi.c:wifi_newlink() index 2 flags 36866
change 0
04:08:45 connmand[254]: src/technology.c:__connman_technology_add_device()
device 0x35e8a8 type WiFi
04:08:45 connmand[254]: src/technology.c:technology_get() type 3
04:08:45 connmand[254]: src/technology.c:technology_find() type 3
04:08:45 connmand[254]: src/device.c:__connman_device_enable() device 0x35e8a8
Reported by Richard Röjfors
---
src/device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/device.c b/src/device.c
index a97d790..1a5f0e6 100644
--- a/src/device.c
+++ b/src/device.c
@@ -185,6 +185,10 @@ int __connman_device_enable(struct connman_device *device)
if (device->powered_pending == PENDING_NONE && device->powered)
return -EALREADY;
+ err = connman_inet_ifup(device->index);
+ if (err < 0 && err != -EALREADY)
+ return err;
+
device->powered_pending = PENDING_ENABLE;
err = device->driver->enable(device);
--
1.8.5.5
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
[PATCH] device: Make sure the device is up and running before enabling it
It can happen that, after a unproper ConnMan exit, a device is still up.
Once ConnMan is restarted cleanup_devices() will put this device down.
But then, it will never set it up again.
04:08:45 connmand[254]: src/device.c:__connman_device_init()
04:08:45 connmand[254]: src/inet.c:__connman_inet_get_address_netmask() index 2
04:08:45 connmand[254]: src/device.c:cleanup_devices() cleaning up wlan0 index 2
(...)
04:08:45 connmand[254]: wlan0 {newlink} index 2 operstate 2
(...)
04:08:45 connmand[254]: plugins/wifi.c:wifi_newlink() index 2 flags 36866
change 0
04:08:45 connmand[254]: src/technology.c:__connman_technology_add_device()
device 0x35e8a8 type WiFi
04:08:45 connmand[254]: src/technology.c:technology_get() type 3
04:08:45 connmand[254]: src/technology.c:technology_find() type 3
04:08:45 connmand[254]: src/device.c:__connman_device_enable() device 0x35e8a8
Reported by Richard Röjfors
---
@Richard: Can you verify if that works for you?
src/device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/device.c b/src/device.c
index a97d790..b4d735b 100644
--- a/src/device.c
+++ b/src/device.c
@@ -185,6 +185,10 @@ int __connman_device_enable(struct connman_device *device)
if (device->powered_pending == PENDING_NONE && device->powered)
return -EALREADY;
+ err = connman_inet_ifup(device->index);
+ if (err < 0)
+ return err;
+
device->powered_pending = PENDING_ENABLE;
err = device->driver->enable(device);
--
1.8.5.5
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH] wifi: Remove useless return statement in interface_added
On Wed, 2014-08-06 at 23:31 -0400, Eduardo Abinader wrote: > Just code cleaning a meaningless return on the last > line of a void function. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH] gsupplicant: Remove duplicated interface assignment on GroupStarted
On Wed, 2014-08-06 at 23:58 -0400, Eduardo Abinader wrote: > Removing a previous interface assignment, although the correct value > was assigned at last. Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH] gsupplicant: Fix the issue about get an invalid group structure
On Thu, 2014-08-07 at 09:35 +0800, Guoqiang Liu wrote: > From: Guoqiang Liu > > peer->groups store group's path, not GSupplicantGroup, so get it > from group_mapping Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
