Re: [PATCH] ipconfig: Do not disable IPv6 in lower up state
On Tue, 2013-01-15 at 16:11 +0200, Jukka Rissanen wrote: Disabling IPv6 in lower up causes problems in IPv6 connectivity. The interface IPv6 status can stay in disabled state because of races. So this patch reverts the commit 4ce90440a70abce7de53 and lets service IPv6 state go to READY when we get an auto configured address for the interface. Fixes BMC#25929 Applied, thanks! Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
[PATCH] ipconfig: Do not disable IPv6 in lower up state
Disabling IPv6 in lower up causes problems in IPv6 connectivity.
The interface IPv6 status can stay in disabled state because of
races. So this patch reverts the commit 4ce90440a70abce7de53
and lets service IPv6 state go to READY when we get an auto
configured address for the interface.
Fixes BMC#25929
---
Hi,
Wagi, can you try if this causes problems in your setup?
The patch lets service IPv6 state go into READY when we
have auto IPv6 address setup to the interface. IMHO, this
should be the correct thing to do but this needs more
testing.
Cheers,
Jukka
src/ipconfig.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 7fba53b..b400894 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -391,18 +391,6 @@ static void __connman_ipconfig_lower_up(struct
connman_ipdevice *ipdevice)
{
DBG(ipconfig ipv4 %p ipv6 %p, ipdevice-config_ipv4,
ipdevice-config_ipv6);
-
- if (ipdevice-config_ipv6 != NULL
- ipdevice-config_ipv6-enabled == TRUE)
- return;
-
- if (ipdevice-ifname == NULL)
- return;
-
- if (__connman_device_isfiltered(ipdevice-ifname) == FALSE) {
- ipdevice-ipv6_enabled = get_ipv6_state(ipdevice-ifname);
- set_ipv6_state(ipdevice-ifname, FALSE);
- }
}
static void __connman_ipconfig_lower_down(struct connman_ipdevice *ipdevice)
--
1.7.11.4
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Re: [PATCH] ipconfig: Do not disable IPv6 in lower up state
Hi Jukka, On 15.01.2013 15:11, Jukka Rissanen wrote: Disabling IPv6 in lower up causes problems in IPv6 connectivity. The interface IPv6 status can stay in disabled state because of races. So this patch reverts the commit 4ce90440a70abce7de53 and lets service IPv6 state go to READY when we get an auto configured address for the interface. Fixes BMC#25929 --- Hi, Wagi, can you try if this causes problems in your setup? I can't remember what the exact setup and problem was. But I played a bit around with AutoConnect=false/true Connect()/Disconnect() and plug/unplug the ethernet cableo on a IPv4/IPv6 network and everything seems to work as expected. I did not test it on a IPv6 only network (don't have that setup here). The patch lets service IPv6 state go into READY when we have auto IPv6 address setup to the interface. IMHO, this should be the correct thing to do but this needs more testing. Yeah, sounds reasonable. Let's see what will happen with that patch applied :) Thanks for digging into this problem, daniel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
Re: [PATCH] ipconfig: Do not disable IPv6 in lower up state
Hi Daniel, On 15 January 2013 17:21, Daniel Wagner w...@monom.org wrote: I can't remember what the exact setup and problem was. But I played a bit around with AutoConnect=false/true Connect()/Disconnect() and plug/unplug the ethernet cableo on a IPv4/IPv6 network and everything seems to work as expected. I did not test it on a IPv6 only network (don't have that setup here). It is possible to simulate IPv6 only network by setting service IPv4 method to OFF and IPv6 method to AUTO (which is the default). In this case IPv4 address is not set to the interface and this is basically the same as if the network does not have IPv4 connectivity. Cheers, Jukka ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
