Re: [PATCH] main: Change cleanup order for proper peer deinit

2014-08-11 Thread Tomasz Bursztyka

Hi Eduardo,

ACK

Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


Re: [PATCH] main: Change cleanup order for proper peer deinit

2014-08-11 Thread Patrik Flykt
On Sun, 2014-08-10 at 22:47 -0400, Eduardo Abinader wrote:
 Cleanup is causing an invalid read during deinitialization
 of an already freed ippool. Just moving the cleanup order,
 ensures proper deinitialization of ippool references.

Applied, thanks!

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


[PATCH] main: Change cleanup order for proper peer deinit

2014-08-10 Thread Eduardo Abinader
Cleanup is causing an invalid read during deinitialization
of an already freed ippool. Just moving the cleanup order,
ensures proper deinitialization of ippool references.
---
 src/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index 4f635de..7cf6c9a 100644
--- a/src/main.c
+++ b/src/main.c
@@ -713,12 +713,12 @@ int main(int argc, char *argv[])
__connman_nat_cleanup();
__connman_firewall_cleanup();
__connman_iptables_cleanup();
+   __connman_peer_cleanup();
__connman_ippool_cleanup();
__connman_device_cleanup();
__connman_network_cleanup();
__connman_dhcp_cleanup();
__connman_service_cleanup();
-   __connman_peer_cleanup();
__connman_agent_cleanup();
__connman_ipconfig_cleanup();
__connman_notifier_cleanup();
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman