Re: [PATCH] service: Move dbg on service_schedule_removed after sanity check

2014-09-04 Thread Patrik Flykt 


On 2014-09-03 06:07, Eduardo Abinader wrote:

Avoid an invalid read by moving debug message after
sanity check.


Applied, thanks!

Patrik
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

[PATCH] service: Move dbg on service_schedule_removed after sanity check

2014-09-02 Thread Eduardo Abinader 
Avoid an invalid read by moving debug message after
sanity check.
---
 src/service.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/service.c b/src/service.c
index f5c0a23..d5f95ed 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4358,13 +4358,13 @@ static void service_schedule_added(struct 
connman_service *service)
 
 static void service_schedule_removed(struct connman_service *service)
 {
-   DBG(service %p %s, service, service-path);
-
if (!service || !service-path) {
DBG(service %p or path is NULL, service);
return;
}
 
+   DBG(service %p %s, service, service-path);
+
g_hash_table_remove(services_notify-add, service-path);
g_hash_table_replace(services_notify-remove, g_strdup(service-path),
NULL);
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman