[PATCH] wifi: Don't allow autoscan for p2p interfaces

2014-07-31 Thread Eduardo Abinader
Accordding to p2p spec, a p2p device is not supposed to carry
wifi scan, specially a client device. Thus this patch avoids
autoscan and solves a segmentation fault issue occuring in
g_supplicant_interface_autoscan, due to a null interface
pointer.
---
 plugins/wifi.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/plugins/wifi.c b/plugins/wifi.c
index ce6d7e7..a44eb37 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -955,6 +955,9 @@ static void start_autoscan(struct connman_device *device)
if (!wifi)
return;
 
+   if (wifi-p2p_device)
+   return;
+
autoscan = wifi-autoscan;
if (!autoscan)
return;
@@ -1039,6 +1042,9 @@ static void finalize_interface_creation(struct wifi_data 
*wifi)
if (!connman_setting_get_bool(BackgroundScanning))
return;
 
+   if (wifi-p2p_device)
+   return;
+
/* Setting up automatic scanning */
if (g_supplicant_interface_autoscan(interface, AUTOSCAN_DEFAULT,
interface_autoscan_callback, wifi)  0) {
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


Re: [PATCH] wifi: Don't allow autoscan for p2p interfaces

2014-07-31 Thread Tomasz Bursztyka

ACK from me.

Thanks Eduardo!
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


Re: [PATCH] wifi: Don't allow autoscan for p2p interfaces

2014-07-31 Thread Patrik Flykt
On Thu, 2014-07-31 at 07:17 -0400, Eduardo Abinader wrote:
 Accordding to p2p spec, a p2p device is not supposed to carry
 wifi scan, specially a client device. Thus this patch avoids
 autoscan and solves a segmentation fault issue occuring in
 g_supplicant_interface_autoscan, due to a null interface
 pointer.

Applied, thanks!

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman