Re: [PATCH 0/2] dnsproxy: Check whether cache cleanup needs to be scheduled

2014-09-18 Thread Patrik Flykt
On Wed, 2014-09-17 at 14:22 +0300, Hannu Mallat wrote:
 One more reworking: unit test needs a few more stubs when compiling
 without optimization.
 
 Hannu Mallat (2):
   dnsproxy: Check whether cache cleanup needs to be scheduled

I applied only patch 1/2 as it wasn't really clear from running the unit
test whether the refcounting underrun condition actually got tested or
not.

Cheers,

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


[PATCH 0/2] dnsproxy: Check whether cache cleanup needs to be scheduled

2014-09-17 Thread Hannu Mallat
Re-sending the previous patch, this time with a unit test that checks
a cleanup timeout isn't scheduled for nonexistent caches. It takes a
few seconds to run the test, as it waits for the cleanup timeout to
complete, but I didn't want to change the source under test just to
speed up the test execution.

Hannu Mallat (2):
  dnsproxy: Check whether cache cleanup needs to be scheduled
  unit: Add unit test for dnsproxy cache cleanup check

 Makefile.am  |   9 ++-
 src/dnsproxy.c   |   3 +-
 unit/test-dnsproxy.c | 160 +++
 3 files changed, 169 insertions(+), 3 deletions(-)
 create mode 100644 unit/test-dnsproxy.c

-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


[PATCH 0/2] dnsproxy: Check whether cache cleanup needs to be scheduled

2014-09-17 Thread Hannu Mallat
One more reworking: unit test needs a few more stubs when compiling
without optimization.

Hannu Mallat (2):
  dnsproxy: Check whether cache cleanup needs to be scheduled
  unit: Add unit test for dnsproxy cache cleanup check

 Makefile.am  |   9 ++-
 src/dnsproxy.c   |   3 +-
 unit/test-dnsproxy.c | 192 +++
 3 files changed, 201 insertions(+), 3 deletions(-)
 create mode 100644 unit/test-dnsproxy.c

-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman