[PATCH 1/1] Update p2p scan status, when disabling wifi

2014-07-29 Thread Eduardo Abinader
Whenever wifi plugin is disabled and p2p find is running,
a double device unref was occurring. By setting scanning to
false, avoids duplicated device unref.
---
 plugins/wifi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/wifi.c b/plugins/wifi.c
index ce6d7e7..5f383bd 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -1119,6 +1119,7 @@ static int wifi_disable(struct connman_device *device)
if (wifi-p2p_find_timeout) {
g_source_remove(wifi-p2p_find_timeout);
wifi-p2p_find_timeout = 0;
+   connman_device_set_scanning(device, CONNMAN_SERVICE_TYPE_P2P, 
false);
connman_device_unref(wifi-device);
}
 
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


Re: [PATCH 1/1] Update p2p scan status, when disabling wifi

2014-07-29 Thread Tomasz Bursztyka

Hi Eduardo,

Can you add wifi: as a prefix of your commit title?

I noticed that your 2 previous accepted patches lacked this prefix rule 
also.

(and got applied, but that's not your mistake)

Besides that, ack on the patch itself.

Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman


Re: [PATCH 1/1] Update p2p scan status, when disabling wifi

2014-07-29 Thread Daniel Wagner
On 07/29/2014 12:23 PM, Tomasz Bursztyka wrote:
 Hi Eduardo,
 
 Can you add wifi: as a prefix of your commit title?
 
 I noticed that your 2 previous accepted patches lacked this prefix rule
 also.
 (and got applied, but that's not your mistake)

Sorry, my bad.
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman