[PATCH 2/2] Let dhcp_server_unref stop dhcp_server

[Eduardo Abinader]

P2P peer was explicit stopping dhcp_server besides dhcp_server_unref,
which already takes care of server stopping.
---
 src/peer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/peer.c b/src/peer.c
index 39877ec..3107f0a 100644
--- a/src/peer.c
+++ b/src/peer.c
@@ -62,7 +62,6 @@ static void stop_dhcp_server(struct connman_peer *peer)
DBG();
 
if (peer-dhcp_server) {
-   g_dhcp_server_stop(peer-dhcp_server);
g_dhcp_server_unref(peer-dhcp_server);
}
peer-dhcp_server = NULL;
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 2/2] Let dhcp_server_unref stop dhcp_server

[Tomasz Bursztyka]

Hi Eduardo,


if (peer-dhcp_server) {
-   g_dhcp_server_stop(peer-dhcp_server);
g_dhcp_server_unref(peer-dhcp_server);
}
peer-dhcp_server = NULL;


You can remove the { ... } then. Just resend that one.

Thanks,

Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

[PATCH 2/2] Let dhcp_server_unref stop dhcp_server

[Eduardo Abinader]

P2P peer was explicit stopping dhcp_server besides dhcp_server_unref,
which already takes care of server stopping.
---
 src/peer.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/peer.c b/src/peer.c
index 39877ec..d627487 100644
--- a/src/peer.c
+++ b/src/peer.c
@@ -61,10 +61,9 @@ static void stop_dhcp_server(struct connman_peer *peer)
 {
DBG();
 
-   if (peer-dhcp_server) {
-   g_dhcp_server_stop(peer-dhcp_server);
+   if (peer-dhcp_server)
g_dhcp_server_unref(peer-dhcp_server);
-   }
+
peer-dhcp_server = NULL;
 
if (peer-ip_pool)
-- 
1.9.1

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman