Re: [PATCH 4/4] wifi: Remove unused pending_network

[Patrik Flykt]

On Tue, 2015-06-23 at 13:35 +0300, Tomasz Bursztyka wrote:
 Hi Patrik,
 
  stop_autoscan(device);

  if (wifi-p2p_find_timeout) {
  @@ -2066,7 +2062,6 @@ static int network_connect(struct connman_network 
  *network)
  ssid_init(ssid, network);

  if (wifi-disconnecting) {
  -   wifi-pending_network = network;
 
  From here
 
  g_free(ssid);
  } else {
  wifi-network = connman_network_ref(network);
  @@ -2099,11 +2094,6 @@ static void disconnect_callback(int result, 
  GSupplicantInterface *interface,

  wifi-disconnecting = false;

  -   if (wifi-pending_network) {
  -   network_connect(wifi-pending_network);
  -   wifi-pending_network = NULL;
 
 and there
 
 This looks like there was a logic about it.
 
 (Not sure this would be hit anyway though)

Yes. But to connect a network in a disconnect callback is what I don't
get.

Cheers,

Patrik

___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 4/4] wifi: Remove unused pending_network

[Tomasz Bursztyka]

Hi Patrik,


stop_autoscan(device);
  
  	if (wifi-p2p_find_timeout) {

@@ -2066,7 +2062,6 @@ static int network_connect(struct connman_network 
*network)
ssid_init(ssid, network);
  
  	if (wifi-disconnecting) {

-   wifi-pending_network = network;


From here


g_free(ssid);
} else {
wifi-network = connman_network_ref(network);
@@ -2099,11 +2094,6 @@ static void disconnect_callback(int result, 
GSupplicantInterface *interface,
  
  	wifi-disconnecting = false;
  
-	if (wifi-pending_network) {

-   network_connect(wifi-pending_network);
-   wifi-pending_network = NULL;


and there

This looks like there was a logic about it.

(Not sure this would be hit anyway though)

Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman