Re: send patches where?
Not yet :) So as Brett mentioned, I'll attach patches to the cases in Jira. - Brill Pappin Jason van Zyl wrote: On 30 Aug 06, at 12:04 AM 30 Aug 06, Brill Pappin wrote: I decided to take some time and tackle some of the very large number of issues in Jira... however I don't have svn commit access. Is there any particular place I should send patches... and what format should the patches be in? Are you an Apache committer? We are setting up a sandbox where Apache committers can collaborate. - Brill Pappin Jason van Zyl [EMAIL PROTECTED]
Re: svn commit: r437073 - in /maven/continuum/trunk: continuum-api/src/main/java/org/apache/maven/continuum/execution/ continuum-core/src/main/java/org/apache/maven/continuum/core/action/ continuum-co
Should this have a Submitted By: line? Wondering who you are thanking :) On 26/08/2006, at 2:29 PM, [EMAIL PROTECTED] wrote: Author: jmcconnell Date: Fri Aug 25 21:29:06 2006 New Revision: 437073 URL: http://svn.apache.org/viewvc?rev=437073view=rev Log: applied CONTINUUN-819 and CONTINUUM-309 and modified a bit to get working with latest trunk, thanks much
Re: Building from Trunk fails.
On 8/28/06, Barrie Treloar [EMAIL PROTECTED] wrote: Revision 437522 of trunk fails with NPE during the build.bat process when trying to stop continuum on a Windows XP machine. The 1.0.3 tagged version also has the same NPE problem. The reason is that I have CVSNT installed on my machine. The command cvs init causes the CVSNT lock server to start. Deleting the cvs-root directory fails because the lock server process is using that directory. My work around is to go into the CVSNT installation directory and rename cvslock.exe to cvslock.exe.off.
[1.0.3] NoSuchMethodError: org.codehaus.plexus.util.cli.Commandline.setPid during build
I am on a Windows XP machine and running build.bat. Has anyone else seen this error before? 2006-08-31 08:55:49,497 [Thread-2] ERROR Action:execute-builder - Error running build java.lang.NoSuchMethodError: org.codehaus.plexus.util.cli.Commandline.setPid(J)V at org.apache.maven.continuum.utils.shell.DefaultShellCommandHelper.executeShellCommand(DefaultShellCommandHelper.java:64) at org.apache.maven.continuum.utils.shell.DefaultShellCommandHelper.executeShellCommand(DefaultShellCommandHelper.java:51) at org.apache.maven.continuum.execution.AbstractBuildExecutor.executeShellCommand(AbstractBuildExecutor.java:186) at org.apache.maven.continuum.execution.maven.m2.MavenTwoBuildExecutor.build(MavenTwoBuildExecutor.java:98) at org.apache.maven.continuum.core.action.ExecuteBuilderContinuumAction.execute(ExecuteBuilderContinuumAction.java:127) at org.apache.maven.continuum.buildcontroller.DefaultBuildController.build(DefaultBuildController.java:275) at org.apache.maven.continuum.buildcontroller.BuildProjectTaskExecutor.executeTask(BuildProjectTaskExecutor.java:47) at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:103) at java.lang.Thread.run(Thread.java:534)
Re: [1.0.3] NoSuchMethodError: org.codehaus.plexus.util.cli.Commandline.setPid during build
Seems like you are picking up an old version of plexus-utils somewhere. - Brett On 31/08/2006, at 9:40 AM, Barrie Treloar wrote: I am on a Windows XP machine and running build.bat. Has anyone else seen this error before? 2006-08-31 08:55:49,497 [Thread-2] ERROR Action:execute-builder - Error running build java.lang.NoSuchMethodError: org.codehaus.plexus.util.cli.Commandline.setPid(J)V at org.apache.maven.continuum.utils.shell.DefaultShellCommandHelper.execu teShellCommand(DefaultShellCommandHelper.java:64) at org.apache.maven.continuum.utils.shell.DefaultShellCommandHelper.execu teShellCommand(DefaultShellCommandHelper.java:51) at org.apache.maven.continuum.execution.AbstractBuildExecutor.executeShel lCommand(AbstractBuildExecutor.java:186) at org.apache.maven.continuum.execution.maven.m2.MavenTwoBuildExecutor.bu ild(MavenTwoBuildExecutor.java:98) at org.apache.maven.continuum.core.action.ExecuteBuilderContinuumAction.e xecute(ExecuteBuilderContinuumAction.java:127) at org.apache.maven.continuum.buildcontroller.DefaultBuildController.buil d(DefaultBuildController.java:275) at org.apache.maven.continuum.buildcontroller.BuildProjectTaskExecutor.ex ecuteTask(BuildProjectTaskExecutor.java:47) at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor $ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:103) at java.lang.Thread.run(Thread.java:534)
unit testing headache
all I want to do it write a regression test for some code before I make any changes... But I seem to be unable to inject my fakes into the code under test (members not exposed). So I took a look at some of the other test that use an abstract base test... however it initializes a whole in memory database. it also doesn't seem to work as I keep getting a jpox error about bad mappings: org.jpox.metadata.InvalidMetaDataException: Error in MetaData for field projectGroup in class Project : this is declared as org.apache.maven.continuum.model.project.ProjectGroup with persistence-modifier=none yet has either default-fetch-group=true or primary-key=true specified! These should be false. at org.jpox.metadata.AbstractPropertyMetaData.populate(AbstractPropertyMetaData.java:818) at org.jpox.metadata.ClassMetaData.populatePropertyMetaData(ClassMetaData.java:418) at org.jpox.metadata.ClassMetaData.populate(ClassMetaData.java:238) at org.jpox.metadata.MetaDataManager.populateClassesInterfacesInFile(MetaDataManager.java:1308) at org.jpox.metadata.MetaDataManager.loadMetaDataForClass(MetaDataManager.java:1430) at org.jpox.metadata.MetaDataManager.getMetaDataForClassOrInterface(MetaDataManager.java:544) at org.jpox.metadata.MetaDataManager.getMetaDataForClassInternal(MetaDataManager.java:509) at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:392) at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:378) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.getReferencedClasses(RDBMSManager.java:2852) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTables(RDBMSManager.java:2603) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTablesAndValidate(RDBMSManager.java:2915) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.run(RDBMSManager.java:2540) at org.jpox.store.rdbms.RDBMSManager$MgmtTransaction.execute(RDBMSManager.java:2397) at org.jpox.store.rdbms.RDBMSManager.addClasses(RDBMSManager.java:603) at org.jpox.SchemaTool.createSchemaTables(SchemaTool.java:279) at org.apache.maven.continuum.AbstractContinuumTest.getStore(AbstractContinuumTest.java:132) at org.apache.maven.continuum.AbstractContinuumTest.setUp(AbstractContinuumTest.java:62) at org.apache.maven.continuum.buildcontroller.DefaultBuildControllerTest.setUp(DefaultBuildControllerTest.java:26) If i fix the jdo file manually, I get another one just like this for another mapping... and so on, and so on... Do I really need to use this base test, or does someone have a way to write a simple unit test? - Brill Pappin
test frustrated
Ok, I've mentioned the unit tests already... I've been fighting with them all night with no luck (getting quite frustrated). Can someone with a clean environment run them and tell me that they are not failing? I could go ahead and start making changes without them, but I consider that very sloppy... and I'd like what I work on to be properly tested. I could also start refactoring so I don't have to use that base test, but I don't want to start doing that until I have more experience with the code base and understand the patterns better. So... a very loud help! from me is in order. - Brill Pappin
Re: unit testing headache
could you generate a diff with what you are trying to do and I'll apply the to a fresh checkout and see what I can figure out can't help much unless I can see what your trying to do specifically :) jesse On 8/30/06, Brill Pappin [EMAIL PROTECTED] wrote: all I want to do it write a regression test for some code before I make any changes... But I seem to be unable to inject my fakes into the code under test (members not exposed). So I took a look at some of the other test that use an abstract base test... however it initializes a whole in memory database. it also doesn't seem to work as I keep getting a jpox error about bad mappings: org.jpox.metadata.InvalidMetaDataException: Error in MetaData for field projectGroup in class Project : this is declared as org.apache.maven.continuum.model.project.ProjectGroup with persistence-modifier=none yet has either default-fetch-group=true or primary-key=true specified! These should be false. at org.jpox.metadata.AbstractPropertyMetaData.populate(AbstractPropertyMetaData.java:818) at org.jpox.metadata.ClassMetaData.populatePropertyMetaData(ClassMetaData.java:418) at org.jpox.metadata.ClassMetaData.populate(ClassMetaData.java:238) at org.jpox.metadata.MetaDataManager.populateClassesInterfacesInFile(MetaDataManager.java:1308) at org.jpox.metadata.MetaDataManager.loadMetaDataForClass(MetaDataManager.java:1430) at org.jpox.metadata.MetaDataManager.getMetaDataForClassOrInterface(MetaDataManager.java:544) at org.jpox.metadata.MetaDataManager.getMetaDataForClassInternal(MetaDataManager.java:509) at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:392) at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:378) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.getReferencedClasses(RDBMSManager.java:2852) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTables(RDBMSManager.java:2603) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTablesAndValidate(RDBMSManager.java:2915) at org.jpox.store.rdbms.RDBMSManager$ClassAdder.run(RDBMSManager.java:2540) at org.jpox.store.rdbms.RDBMSManager$MgmtTransaction.execute(RDBMSManager.java:2397) at org.jpox.store.rdbms.RDBMSManager.addClasses(RDBMSManager.java:603) at org.jpox.SchemaTool.createSchemaTables(SchemaTool.java:279) at org.apache.maven.continuum.AbstractContinuumTest.getStore(AbstractContinuumTest.java:132) at org.apache.maven.continuum.AbstractContinuumTest.setUp(AbstractContinuumTest.java:62) at org.apache.maven.continuum.buildcontroller.DefaultBuildControllerTest.setUp(DefaultBuildControllerTest.java:26) If i fix the jdo file manually, I get another one just like this for another mapping... and so on, and so on... Do I really need to use this base test, or does someone have a way to write a simple unit test? - Brill Pappin -- jesse mcconnell [EMAIL PROTECTED]
