[contribteam] [Bug 12516] Wrong Servers output from template
https://bugs.koozali.org/show_bug.cgi?id=12516
--- Comment #3 from John Crisp ---
As a wider issue (maybe clone to a new bug) I can also see some inconsistent
naming.
custom.conf/10All
my $max_children = $pool->prop('MaxChildren') || '15';
www.conf/00Default30Childrens
pm.max_children = { $MaxChildren }
www.conf/15phpmyadmin
my $max_children = $phpmyadmin{'PHPmaxChildren'}
The same is likely for the other pm settings.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
Mail for each SME Contribs bug report
To unsubscribe, e-mail contribteam-unsubscr...@lists.contribs.org
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
[contribteam] [Bug 12516] Wrong Servers output from template
https://bugs.koozali.org/show_bug.cgi?id=12516 --- Comment #2 from John Crisp --- Created attachment 6859 --> https://bugs.koozali.org/attachment.cgi?id=6859=edit Proposed patch Proposed patch -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ Mail for each SME Contribs bug report To unsubscribe, e-mail contribteam-unsubscr...@lists.contribs.org Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
[contribteam] [Bug 12516] Wrong Servers output from template
https://bugs.koozali.org/show_bug.cgi?id=12516 --- Comment #1 from John Crisp --- As a side thought this also has the effect possibly setting odd values eg set PHPminServers 25 leave PHPmaxServers default = 8 minServers > maxServers so minServers = maxServers/2 = 4 This might also be an issue with startservers as well? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ Mail for each SME Contribs bug report To unsubscribe, e-mail contribteam-unsubscr...@lists.contribs.org Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
[contribteam] [Bug 12516] Wrong Servers output from template
https://bugs.koozali.org/show_bug.cgi?id=12516
Bug ID: 12516
Summary: Wrong Servers output from template
Classification: Contribs
Product: SME Contribs
Version: 10.0
Hardware: ---
OS: ---
Status: CONFIRMED
Severity: normal
Priority: P3
Component: smeserver-phpmyadmin
Assignee: contribteam@lists.contribs.org
Reporter: jcr...@safeandsoundit.co.uk
QA Contact: contribteam@lists.contribs.org
Target Milestone: ---
Created attachment 6858
--> https://bugs.koozali.org/attachment.cgi?id=6858=edit
Test file to check outputs
I was looking at code here to utilise elsewhere and noticed during some test
that the output values were not always correct.
It seems that the printf does not evaluate correctly and it requires sprintf
here:
/etc/e-smith/templates/etc/php-fpm.d/www.conf/15phpmyadmin
These two lines do not produce correct results if they hit the printf section:
$min_spare_servers = ( $min_spare_servers > $max_spare_servers ) ?
printf("%.0f",$max_spare_servers/2) : $min_spare_servers;
$start_servers = ( $start_servers > $max_spare_servers ) ? printf("%.0f",
$max_spare_servers /2 + $min_spare_servers/2 ) : $start_servers;
The printf needs changing to sprintf like this
$min_spare_servers = ( $min_spare_servers > $max_spare_servers ) ?
sprintf("%.0f",$max_spare_servers/2) : $min_spare_servers;
$start_servers = ( $start_servers > $max_spare_servers ) ? sprintf("%.0f",
$max_spare_servers /2 + $min_spare_servers/2 ) : $start_servers;
I've attached a quick PoC file for testing.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
Mail for each SME Contribs bug report
To unsubscribe, e-mail contribteam-unsubscr...@lists.contribs.org
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
