| Re: codebase moved to pagure.io

[Michal Novotny]

On Mon, Oct 31, 2016 at 12:05 PM, Pierre-Yves Chibon 
wrote:

> On Mon, Oct 31, 2016 at 11:59:47AM +0100, Michal Novotny wrote:
> >On Mon, Oct 31, 2016 at 8:40 AM, Pierre-Yves Chibon <
> pin...@pingoured.fr>
> >wrote:
> >
> >  We used to send more info but had to trim it down due to some
> massive
> >  commits
> >  that were basically breaking datagrepper (OutOfMemory), but if
> there is
> >  an
> >  use-case I'm fine with expending the amount of information sent.
> >  Worst case, do the computation client-side, listen to fedmsg, get
> the
> >  start and
> >  stop commits and see which files were touched in between.
> >
> >In the simplest case, we would need directory/file names of level 1
> where
> >there was
> >a change. That's perhaps a little too specific though. I would still
> very
> >much welcome
> >this or overall list of modified paths. Not saying, I can't put
> together
> >some really messy
> >code to get that information from the patches :).
>
> If you're not against shelling out commands, you could try:
>
> Get the list of commits:
>   git rev-list old_commit..new_commit
>
> Get the list of file changed in a specific commit:
>   git diff-tree --no-commit-id --name-only -r 
>

The problem is that we don't have the repository cloned at the point the
fedmsg is received.
And to always clone the repo to run the commands would be a bit troublesome.


>
> Pierre
> ___
> copr-devel mailing list -- copr-devel@lists.fedorahosted.org
> To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org
>
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

| Re: codebase moved to pagure.io

[Pierre-Yves Chibon]

On Mon, Oct 31, 2016 at 11:59:47AM +0100, Michal Novotny wrote:
>On Mon, Oct 31, 2016 at 8:40 AM, Pierre-Yves Chibon 
>wrote:
> 
>  We used to send more info but had to trim it down due to some massive
>  commits
>  that were basically breaking datagrepper (OutOfMemory), but if there is
>  an
>  use-case I'm fine with expending the amount of information sent.
>  Worst case, do the computation client-side, listen to fedmsg, get the
>  start and
>  stop commits and see which files were touched in between.
> 
>In the simplest case, we would need directory/file names of level 1 where
>there was
>a change. That's perhaps a little too specific though. I would still very
>much welcome
>this or overall list of modified paths. Not saying, I can't put together
>some really messy
>code to get that information from the patches :).

If you're not against shelling out commands, you could try:

Get the list of commits:
  git rev-list old_commit..new_commit

Get the list of file changed in a specific commit:
  git diff-tree --no-commit-id --name-only -r 


Pierre
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

| Re: codebase moved to pagure.io

[Michal Novotny]

On Mon, Oct 31, 2016 at 8:40 AM, Pierre-Yves Chibon 
wrote:

> We used to send more info but had to trim it down due to some massive
> commits
> that were basically breaking datagrepper (OutOfMemory), but if there is an
> use-case I'm fine with expending the amount of information sent.
> Worst case, do the computation client-side, listen to fedmsg, get the
> start and
> stop commits and see which files were touched in between.
>

In the simplest case, we would need directory/file names of level 1 where
there was
a change. That's perhaps a little too specific though. I would still very
much welcome
this or overall list of modified paths. Not saying, I can't put together
some really messy
code to get that information from the patches :).

Pierre
> ___
> copr-devel mailing list -- copr-devel@lists.fedorahosted.org
> To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org
>
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

| Re: codebase moved to pagure.io

[Pierre-Yves Chibon]

On Mon, Oct 31, 2016 at 08:30:28AM +0100, Michal Novotny wrote:
>On Thu, Oct 27, 2016 at 7:56 PM, Pierre-Yves Chibon 
>wrote:
> 
>  Pagure supports web-hook as well as fedmsg for notifying of an action.
>  There is also of course the possibility to add COPR as some sort of CI
>  service
>  like we have for jenkins but that would be a little more work on pagure
>  itself.
> 
>  Let me know if I can help with something!
> 
>Thank you. I have already implemented some basic fedmsg listener that
>launches builds
>on pagure.git.receive message. It works but it would be nice to extend the
>message with
>the information about modified paths in the repository so that only the
>corresponding sub-package(s)
>are rebuilt (in COPR repo, there are 10 subpackages at least, which is
>quite a lot of building when
>only one of them has been actually updated). I will gladly send a PR for
>this unless there happens
>to be some better way.

We used to send more info but had to trim it down due to some massive commits
that were basically breaking datagrepper (OutOfMemory), but if there is an
use-case I'm fine with expending the amount of information sent.
Worst case, do the computation client-side, listen to fedmsg, get the start and
stop commits and see which files were touched in between.

Pierre
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org

| Re: codebase moved to pagure.io

[Michal Novotny]

On Thu, Oct 27, 2016 at 7:56 PM, Pierre-Yves Chibon 
wrote:

> Pagure supports web-hook as well as fedmsg for notifying of an action.
> There is also of course the possibility to add COPR as some sort of CI
> service
> like we have for jenkins but that would be a little more work on pagure
> itself.
>
>
> Let me know if I can help with something!
>

Thank you. I have already implemented some basic fedmsg listener that
launches builds
on pagure.git.receive message. It works but it would be nice to extend the
message with
the information about modified paths in the repository so that only the
corresponding sub-package(s)
are rebuilt (in COPR repo, there are 10 subpackages at least, which is
quite a lot of building when
only one of them has been actually updated). I will gladly send a PR for
this unless there happens
to be some better way.

Pierre
> ___
> copr-devel mailing list -- copr-devel@lists.fedorahosted.org
> To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org
>
___
copr-devel mailing list -- copr-devel@lists.fedorahosted.org
To unsubscribe send an email to copr-devel-le...@lists.fedorahosted.org