hg: jdk8/tl/jdk: 7122054: (tz) Windows-only: tzmappings needs update for KB2633952

2011-12-21 Thread masayoshi . okutsu 
Changeset: 1c4fffa22930
Author:okutsu
Date:  2011-12-21 17:09 +0900
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c4fffa22930

7122054: (tz) Windows-only: tzmappings needs update for KB2633952
Reviewed-by: peytoia

! src/windows/lib/tzmappings

hg: jdk8/tl/jdk: 7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results on linux

2011-12-21 Thread michael . x . mcmahon 
Changeset: b1814b3ea6d3
Author:michaelm
Date:  2011-12-21 10:06 +
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1814b3ea6d3

7078386: NetworkInterface.getNetworkInterfaces() may return corrupted results 
on linux
Reviewed-by: michaelm, alanb, chegar
Contributed-by: brandon.passan...@oracle.com

! src/solaris/native/java/net/NetworkInterface.c

RE: Code Review Request for Bug #4802647

2011-12-21 Thread Jason Mehrens 

 Date: Tue, 20 Dec 2011 10:12:02 +1000
 From: david.hol...@oracle.com
 To: brandon.passan...@oracle.com
 Subject: Re: Code Review Request for Bug #4802647
 CC: core-libs-dev@openjdk.java.net
 
 Brandon,
 
 I don't see the purpose of NewAbstractSet. It is identical to 
 NewAbstractCollection.

I would assume the intent was extends AbstractSetE instead of extends 
NewAbstractCollectionE.
 
Jason

Re: Code Review Request for Bug #4802647

2011-12-21 Thread Brandon Passanisi 
Yes, my intent was extends AbstractSetE instead of extends 
NewAbstractCollectionE.  I have reflected this in the updated webrev 
below.  Here's the information:


   Webrev URL: http://cr.openjdk.java.net/~bpassani/4802647/2/webrev/
   Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4802647

1. In MOAT.java, I changed NewAbstractSet to extend AbstractSetE.

2. The changes in 1) resulted in finding out that AbstractSet has the 
same bug behavior with removeAll(null). 
AbstractSet.removeAll(Collection? c) was updated accordingly.


3. I filed bug 7123424 to account for the same bug behavior found in 
CopyOnWriteArrayList and CopyOnWriteArraySet.


4. It was advised that I skip the failing behavior of 
CopyOnWriteArrayList and CopyOnWriteArraySet for 
removeAll(null)/retainAll(null) in MOAT.java and provide a comment about 
how the skip needs to be removed once bug 7123424 is fixed.  This is the 
reason for the instanceof checks that were recently added and the added 
comments.


Thanks.

On 12/21/2011 7:52 AM, Jason Mehrens wrote:

 Date: Tue, 20 Dec 2011 10:12:02 +1000
 From: david.hol...@oracle.com
 To: brandon.passan...@oracle.com
 Subject: Re: Code Review Request for Bug #4802647
 CC: core-libs-dev@openjdk.java.net

 Brandon,

 I don't see the purpose of NewAbstractSet. It is identical to
 NewAbstractCollection.

I would assume the intent was extends AbstractSetE instead 
of extends NewAbstractCollectionE.


Jason


--
Oracle http://www.oracle.com
Brandon Passanisi | Principle Member of Technical Staff

Green Oracle http://www.oracle.com/commitment Oracle is committed to 
developing practices and products that help protect the environment

hg: jdk8/tl/jdk: 6839886: Array overrun in pkcs11

2011-12-21 Thread valerie . peng 
Changeset: a9dfdc523c2c
Author:valeriep
Date:  2011-12-21 14:08 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a9dfdc523c2c

6839886: Array overrun in pkcs11
Summary: Fix the wrong value when dealing w/ month and day.
Reviewed-by: mullan

! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c

hg: jdk8/tl/jdk: 7122169: TcpTimeout fail for various reasons

2011-12-21 Thread weijun . wang 
Changeset: 11698dedbe79
Author:weijun
Date:  2011-12-22 15:35 +0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11698dedbe79

7122169: TcpTimeout fail for various reasons
Reviewed-by: alanb

! test/sun/security/krb5/auto/TcpTimeout.java