hg: jdk8/tl/jdk: 7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed

2012-01-06 Thread alan . bateman
Changeset: 400cc379adb5
Author:alanb
Date:  2012-01-06 15:00 +
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/400cc379adb5

7127235: (fs) NPE in Files.walkFileTree if cached attributes are GC'ed
Reviewed-by: forax, chegar

! src/share/classes/java/nio/file/FileTreeWalker.java



Fwd: Need reviewer: ant script bug in jaxws

2012-01-06 Thread Kelly O'Hair
Still need a reviewer for this small change.  Any volunteers?

-kto

Begin forwarded message:

 From: Kelly O'Hair kelly.oh...@oracle.com
 Subject: Need reviewer: ant script bug in jaxws
 Date: January 4, 2012 17:59:32 PM PST
 To: core-libs-dev Libs core-libs-dev@openjdk.java.net
 Cc: miroslav@oracle.com
 
 For jdk8. Had this on my CR list for a long time. :^(
 
 Need reviewer. This is an ant script change in jaxws
 
 Minor issue of missing files: 
   META-INF/mailcap.default
   META-INF/mimetypes.default
 In the dist/lib/classes.jar file created by the jaxws build and delivered 
 into the jdk.
 
 7096063: /META-INF/mimetypes.default missing in jre\lib\resources.jar
 http://cr.openjdk.java.net/~ohair/openjdk8/jaxws-missing-files/webrev/
 
 -kto
 



hg: jdk8/tl/jdk: 2 new changesets

2012-01-06 Thread valerie . peng
Changeset: cdc128128044
Author:valeriep
Date:  2012-01-05 18:18 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdc128128044

6414899: P11Digest  should support cloning
Summary: Enhanced the PKCS11 Digest implementation to support cloning
Reviewed-by: vinnie

! make/sun/security/pkcs11/mapfile-vers
! src/share/classes/sun/security/pkcs11/P11Digest.java
! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java
! src/share/lib/security/sunpkcs11-solaris.cfg
! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h
+ test/sun/security/pkcs11/MessageDigest/TestCloning.java

Changeset: e6ef778c1df4
Author:valeriep
Date:  2012-01-06 11:02 -0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6ef778c1df4

Merge




Re: Code Review - CR# 7030573 insufficient disk space for large file test

2012-01-06 Thread Gary Adams

On 01/ 5/12 08:30 AM, Alan Bateman wrote:

On 23/12/2011 16:19, Gary Adams wrote:

The LargeFileAvailable regression test had intermittent failures
when there was not sufficient space available to create
a 7G temp file. This webrev presents a simple check to
see if the available usable space is less than 7G and
scales the test back accordingly.

The original bug report suggests that the test be switched
to use the current working directory rather than a temp
file. I think that could be the wrong choice for an embedded
system that might have the tests mounted from a remote
file system. In that scenario, using the local temp file
space provides a better solution for what this test is designed
to check.

  http://cr.openjdk.java.net/~gadams/7030573/
The only thing is that when the test is scaled back too much then it no longer 
tests the original issue. This test will create a sparse file on file systems 
that support it and I suspect the reason it fails on Solaris is that tmp is 
backed by swap. It might be better if we changed the test to create the file 
in the current directory (or a sub-directory of). It will be removed by jtreg 
if the test doesn't delete it.


-Alan



I've updated the webrev with the temp file created in the current directory.

I'm not sure what to do about the case if there is only a little space available
only a small file will be used. Should the test fail and force the test operator
to create a new test environment where 7G space is available?

I lean toward allowing the test to pass using the space that is available.