Re: RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

2015-08-18 Thread Lance @ Oracle 
Hi Alexander 

Looks ok but you will need to make sure the jaxws changes get pushed to the 
standalone project as well

Best,
Lance


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad

 On Aug 18, 2015, at 7:50 AM, Alexander Stepanov 
 alexander.v.stepa...@oracle.com wrote:
 
 Hello,
 
 Could you please review the following fix
 http://cr.openjdk.java.net/~avstepan/8132478/jdk.00/index.html
 http://cr.openjdk.java.net/~avstepan/8132478/jaxws.00/index.html
 for
 https://bugs.openjdk.java.net/browse/JDK-8132478
 
 Just a minor fix for docs (a few tidy warnings + some invalid tags).
 
 Thanks,
 Alexander

RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

2015-08-18 Thread Alexander Stepanov 

Hello,

Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8132478/jdk.00/index.html
http://cr.openjdk.java.net/~avstepan/8132478/jaxws.00/index.html
for
https://bugs.openjdk.java.net/browse/JDK-8132478

Just a minor fix for docs (a few tidy warnings + some invalid tags).

Thanks,
Alexander

Re: RFR [9] 8132478: [tidy] three new warnings from java docs (java.net, javax.annotation)

2015-08-18 Thread Alexander Stepanov 

Hello Lance,

Thanks!

Regards,
Alexander

On 8/18/2015 2:56 PM, Lance @ Oracle wrote:

Hi Alexander

Looks ok but you will need to make sure the jaxws changes get pushed 
to the standalone project as well


Best,
Lance


http://oracle.com/us/design/oracle-email-sig-198324.gifLance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037 
tel:+1.781.442.2037

Oracle Java Engineering
1 Network Drive x-apple-data-detectors://34/0
Burlington, MA 01803 x-apple-data-detectors://34/0
lance.ander...@oracle.com mailto:lance.ander...@oracle.com
Sent from my iPad

On Aug 18, 2015, at 7:50 AM, Alexander Stepanov 
alexander.v.stepa...@oracle.com 
mailto:alexander.v.stepa...@oracle.com wrote:



Hello,

Could you please review the following fix
http://cr.openjdk.java.net/~avstepan/8132478/jdk.00/index.html 
http://cr.openjdk.java.net/%7Eavstepan/8132478/jdk.00/index.html
http://cr.openjdk.java.net/~avstepan/8132478/jaxws.00/index.html 
http://cr.openjdk.java.net/%7Eavstepan/8132478/jaxws.00/index.html

for
https://bugs.openjdk.java.net/browse/JDK-8132478

Just a minor fix for docs (a few tidy warnings + some invalid tags).

Thanks,
Alexander

Re: RFR v6 - 8027634: Support @argfiles for java command-line tool

2015-08-18 Thread Mandy Chung 



On 08/17/2015 09:15 PM, Henry Jen wrote:

v6 is available at

http://cr.openjdk.java.net/~henryjen/jdk9/8027634/v6/webrev/


Thanks for the update.  Looks fine.

Mandy

Re: JDK 9 RFR of JDK-8133808: Place java/lang/ProcessHandle/InfoTest.java on the Problem List

2015-08-18 Thread Lance Andersen 
makes sense to me
On Aug 18, 2015, at 2:39 PM, joe darcy joe.da...@oracle.com wrote:

 Hello,
 
 The test
 
 java/lang/ProcessHandle/InfoTest.java
 
 has been observed to fail intermittent and now with greater frequency on some 
 system with the current HotSpot changes.
 
 While the underlying issues are being sorted out (JDK-8133552), it would be 
 helpful to mark the test as intermittently failing and to place it on the 
 problem list:
 
 diff -r 0940ce86c614 test/ProblemList.txt
 --- a/test/ProblemList.txtThu Aug 13 21:46:05 2015 -0700
 +++ b/test/ProblemList.txtTue Aug 18 11:37:58 2015 -0700
 @@ -129,6 +129,9 @@
 # 8029891
 java/lang/ClassLoader/deadlock/GetResource.java generic-all
 
 +# 8133552
 +java/lang/ProcessHandle/InfoTest.java generic-all
 +
 
 
 # jdk_instrument
 diff -r 0940ce86c614 test/java/lang/ProcessHandle/InfoTest.java
 --- a/test/java/lang/ProcessHandle/InfoTest.javaThu Aug 13 21:46:05 2015 
 -0700
 +++ b/test/java/lang/ProcessHandle/InfoTest.javaTue Aug 18 11:37:58 2015 
 -0700
 @@ -49,10 +49,12 @@
 
 /*
  * @test
 + * @bug 8077350 8081566 8081567 8098852
  * @build jdk.testlibrary.*
  * @library /lib/testlibrary
  * @summary Functions of ProcessHandle.Info
  * @author Roger Riggs
 + * @key intermittent
  */
 
 public class InfoTest {
 
 Thanks,
 
 -Joe



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

JDK 9 RFR of JDK-8133808: Place java/lang/ProcessHandle/InfoTest.java on the Problem List

2015-08-18 Thread joe darcy 

Hello,

The test

 java/lang/ProcessHandle/InfoTest.java

has been observed to fail intermittent and now with greater frequency on 
some system with the current HotSpot changes.


While the underlying issues are being sorted out (JDK-8133552), it would 
be helpful to mark the test as intermittently failing and to place it on 
the problem list:


diff -r 0940ce86c614 test/ProblemList.txt
--- a/test/ProblemList.txtThu Aug 13 21:46:05 2015 -0700
+++ b/test/ProblemList.txtTue Aug 18 11:37:58 2015 -0700
@@ -129,6 +129,9 @@
 # 8029891
 java/lang/ClassLoader/deadlock/GetResource.java generic-all

+# 8133552
+java/lang/ProcessHandle/InfoTest.java generic-all
+
 

 # jdk_instrument
diff -r 0940ce86c614 test/java/lang/ProcessHandle/InfoTest.java
--- a/test/java/lang/ProcessHandle/InfoTest.javaThu Aug 13 21:46:05 
2015 -0700
+++ b/test/java/lang/ProcessHandle/InfoTest.javaTue Aug 18 11:37:58 
2015 -0700

@@ -49,10 +49,12 @@

 /*
  * @test
+ * @bug 8077350 8081566 8081567 8098852
  * @build jdk.testlibrary.*
  * @library /lib/testlibrary
  * @summary Functions of ProcessHandle.Info
  * @author Roger Riggs
+ * @key intermittent
  */

 public class InfoTest {

Thanks,

-Joe

Review request: 8132944: test java/lang/ClassLoader/GetSystemPackage.java writes stuff to Agent stdout

2015-08-18 Thread Mandy Chung 
A trivial one - this takes out the unnecessary debug statement to clean up the 
test output.

diff --git a/test/java/lang/ClassLoader/GetSystemPackage.java 
b/test/java/lang/ClassLoader/GetSystemPackage.java
--- a/test/java/lang/ClassLoader/GetSystemPackage.java
+++ b/test/java/lang/ClassLoader/GetSystemPackage.java
@@ -181,7 +181,6 @@
 private static Package findPackage(String name) {
 Package[] packages = Package.getPackages();
 for (Package p : packages) {
-System.out.println(p);
 if (p.getName().equals(name)) {
 return p;
 }

Mandy

Re: Review request: 8132944: test java/lang/ClassLoader/GetSystemPackage.java writes stuff to Agent stdout

2015-08-18 Thread David Holmes 

Looks fine Mandy!

Thanks,
David

On 19/08/2015 12:26 PM, Mandy Chung wrote:

A trivial one - this takes out the unnecessary debug statement to clean up the 
test output.

diff --git a/test/java/lang/ClassLoader/GetSystemPackage.java 
b/test/java/lang/ClassLoader/GetSystemPackage.java
--- a/test/java/lang/ClassLoader/GetSystemPackage.java
+++ b/test/java/lang/ClassLoader/GetSystemPackage.java
@@ -181,7 +181,6 @@
  private static Package findPackage(String name) {
  Package[] packages = Package.getPackages();
  for (Package p : packages) {
-System.out.println(p);
  if (p.getName().equals(name)) {
  return p;
  }

Mandy