Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

[Ivan Gerasimov]

Hello!

This is a gentle reminder.

The proposed comparator implementation would be particularly useful when 
one will need to compare version strings.
Some popular file managers also use similar comparing algorithm, as the 
results often look more natural to the human eyes (e.g. File Explorer on 
Windows, Files on Ubuntu).


Now, as Java 10 is been worked on, to sort the list of Java names 
correctly, this kind of comparator is needed:


Look: a list { ... "Java 8", "Java 9", "Java 10" } definitely looks 
nicer than { "Java 1", "Java 10", "Java 2", ... }  :-)


Would you please help review the proposal?

With kind regards,
Ivan


On 7/19/17 1:41 AM, Ivan Gerasimov wrote:

Hello!

It is a proposal to provide a String comparator, which will pay 
attention to the numbers embedded into the strings (should they present).


This proposal was initially discussed back in 2014 and seemed to bring 
some interest from the community:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-December/030343.html 



In the latest webrev two methods are added to the public API:
j.u.Comparator.comparingNumerically() and
j.u.Comparator.comparingNumericallyLeadingZerosAhead().

The regression test is extended to exercise this new comparator.

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8134512
WEBREV: http://cr.openjdk.java.net/~igerasim/8134512/01/webrev/

Comments, suggestions are very welcome!



--
With kind regards,
Ivan Gerasimov

Re: RFR: jsr166 jdk10 integration wave 1

[Martin Buchholz]

Finally submitted.

On Tue, Jul 18, 2017 at 9:35 AM, Martin Buchholz 
wrote:

> After a long delay, we are finally ready to try again to get in jsr166
> jdk10 integration wave 1.
>
> The set of changes has grown a lot over the past few months (too much?),
> and contains the usual hard-to-review tck test improvements.  Our
> infrastructure for generating these commits has changed a lot as well, but
> reviewers should see little difference.
>
> We now run errorprone over the jsr166 sources occasionally ("ant
> errorprone").  This set of commits contains the first annotations to
> suppress errorprone warnings, e.g.
>
> +@SuppressWarnings("FutureReturnValueIgnored")
>
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/
>
> On Mon, Apr 10, 2017 at 2:19 PM, Martin Buchholz 
> wrote:
>
>> Non-thread-pool changes committed while we wait for thread-pool CCC.
>>
>>
>