Re: [9] RFR 4154028: Several hotspot tests need to be updated after 8153737 (Unsupported Module)
Thanks Vladimir Alejandro On 4/11/2016 7:19 PM, Vladimir Kozlov wrote: Looks good. Thanks, Vladimir On 4/11/16 5:14 PM, Alejandro Murillo wrote: Can I get a quick review for this fix that's blocking the synching of jdk9/hs with jdk9/dev: Basically, https://bugs.openjdk.java.net/browse/JDK-8153737 introduced some changes that need to be applied to several hotspot tests that were not in jdk9/dev by the time that fix was pushed. They can't be fixed on either repo, the need to be fixed in the merging repo before being pushed back to jdk9/hs (first) Bug https://bugs.openjdk.java.net/browse/JDK-8154028 Webrev: http://cr.openjdk.java.net/~amurillo/9/8154028/ I'm running a sanity test job now, but wanted to get the review going as I need to get the synch done ASAP to start PIT Thanks -- Alejandro
Re: [9] RFR 4154028: Several hotspot tests need to be updated after 8153737 (Unsupported Module)
Thanks Joe. Alejandro On 4/11/2016 6:44 PM, joe darcy wrote: Looks fine Alejandro; thanks, -Joe On 4/11/2016 5:14 PM, Alejandro Murillo wrote: Can I get a quick review for this fix that's blocking the synching of jdk9/hs with jdk9/dev: Basically, https://bugs.openjdk.java.net/browse/JDK-8153737 introduced some changes that need to be applied to several hotspot tests that were not in jdk9/dev by the time that fix was pushed. They can't be fixed on either repo, the need to be fixed in the merging repo before being pushed back to jdk9/hs (first) Bug https://bugs.openjdk.java.net/browse/JDK-8154028 Webrev: http://cr.openjdk.java.net/~amurillo/9/8154028/ I'm running a sanity test job now, but wanted to get the review going as I need to get the synch done ASAP to start PIT Thanks -- Alejandro
[9] RFR 4154028: Several hotspot tests need to be updated after 8153737 (Unsupported Module)
Can I get a quick review for this fix that's blocking the synching of jdk9/hs with jdk9/dev: Basically, https://bugs.openjdk.java.net/browse/JDK-8153737 introduced some changes that need to be applied to several hotspot tests that were not in jdk9/dev by the time that fix was pushed. They can't be fixed on either repo, the need to be fixed in the merging repo before being pushed back to jdk9/hs (first) Bug https://bugs.openjdk.java.net/browse/JDK-8154028 Webrev: http://cr.openjdk.java.net/~amurillo/9/8154028/ I'm running a sanity test job now, but wanted to get the review going as I need to get the synch done ASAP to start PIT Thanks -- Alejandro
Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
It was late for me, so Amy took over and fixed it Thanks Alejandro On 4/6/2016 1:36 AM, Alan Bateman wrote: On 06/04/2016 06:14, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. Would it be possible to add @modules java.base/jdk.internal.misc, as below, and not exclude these tests? -Alan $ hg diff -g . diff --git a/test/java/nio/Buffer/Basic.java b/test/java/nio/Buffer/Basic.java --- a/test/java/nio/Buffer/Basic.java +++ b/test/java/nio/Buffer/Basic.java @@ -22,6 +22,7 @@ */ /* @test + * @modules java.base/jdk.internal.misc * @summary Unit test for buffers * @bug 4413135 4414911 4416536 4416562 4418782 4471053 4472779 4490253 4523725 * 4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529 diff --git a/test/java/nio/Buffer/CopyDirectMemory.java b/test/java/nio/Buffer/CopyDirectMemory.java --- a/test/java/nio/Buffer/CopyDirectMemory.java +++ b/test/java/nio/Buffer/CopyDirectMemory.java @@ -25,6 +25,7 @@ * @summary Test view buffer bulk operations for large buffers. * @bug 4463011 * + * @modules java.base/jdk.internal.misc * @build Basic * @run main CopyDirectMemory */ -- Alejandro
Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
I didn't see that one failing on my jprt sanity job I went to check the code CopyDirectMemory.java, and it doesn't use jdk.internal.misc.Unsafe (at least directly), so doesn't look like it's the same issue. where did you see the failure ? Alejandro On 4/5/2016 11:59 PM, Amy Lu wrote: java/nio/Buffer/CopyDirectMemory.java run into the same issue, maybe it could be problem listed together in this patch? Thanks, Amy On 4/6/16 1:14 PM, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. $ hg -R jdk9.dev/jdk tip -pv changeset: 14082:5c98c9ad8ff2 tag: tip user:amurillo date:Tue Apr 05 22:06:15 2016 -0700 files: test/ProblemList.txt description: 8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed Reviewed-by: tbd diff -r 04f56d4ca167 -r 5c98c9ad8ff2 test/ProblemList.txt --- a/test/ProblemList.txt Tue Apr 05 20:02:21 2016 -0700 +++ b/test/ProblemList.txt Tue Apr 05 22:06:15 2016 -0700 @@ -185,6 +185,8 @@ java/nio/charset/coders/BashStreams.java 8149712 generic-all +java/nio/Buffer/BasicByte.java 8153563 generic-all + # jdk_rmi -- Alejandro
[9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. $ hg -R jdk9.dev/jdk tip -pv changeset: 14082:5c98c9ad8ff2 tag: tip user:amurillo date:Tue Apr 05 22:06:15 2016 -0700 files: test/ProblemList.txt description: 8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed Reviewed-by: tbd diff -r 04f56d4ca167 -r 5c98c9ad8ff2 test/ProblemList.txt --- a/test/ProblemList.txt Tue Apr 05 20:02:21 2016 -0700 +++ b/test/ProblemList.txt Tue Apr 05 22:06:15 2016 -0700 @@ -185,6 +185,8 @@ java/nio/charset/coders/BashStreams.java 8149712 generic-all +java/nio/Buffer/BasicByte.java 8153563 generic-all + # jdk_rmi -- Alejandro
Re: FAILS: test/sun/management/jdp/JdpTest.sh: test: argument expected
Dmitry,
you have to use -testset core to run this test via JPRT. It's not run
on regular jobs.
Alejandro
On 2/12/2013 3:18 PM, Dmitry Samersoff wrote:
Kelly,
Do you have an idea why I didn't see this failure under jprt?
http://sthjprt.se.oracle.com/archives/2013/02/2013-02-08-192233.dsamerso.tl/
-Dmitry
On 2013-02-12 21:52, Kelly O'Hair wrote:
+if [ ! -f ${_testclasses} ]
needs to be
+if [ ! -d ${_testclasses} ]
-kto
On Feb 12, 2013, at 9:38 AM, Chris Hegarty wrote:
Dmitry,
This test is now failing on several platforms, on jdk8 and 7u-dev
---
result: Passed. Compilation successful
#section:shell
--messages:(3/154)--
command: shell JdpTest.sh [--jtreg, --no-compile]
reason: User specified action: run shell JdpTest.sh --jtreg --no-compile
elapsed time (seconds): 0.045
--System.out:(0/0)--
--System.err:(1/110)--
/export2/Users/chris/repos/jdk8/tl/master_top/jdk/test/sun/management/jdp/JdpTest.sh:
test: argument expected
result: Failed. Execution failed: exit code 1
test result: Failed. Execution failed: exit code 1
-Chris.
On 02/12/2013 12:04 PM, dmitry.samers...@oracle.com wrote:
Changeset: f7fb173ac833
Author:dsamersoff
Date: 2013-02-12 16:02 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb173ac833
8007786: JDK-8002048 testcase doesn't work on Solaris
Summary: test built in into Solaris shell doesn't have -e operator
Reviewed-by: sla, sspitsyn
! test/sun/management/jdp/JdpTest.sh
